I took a look at quirks.c in linux-next. It's a bit sdio-specific... I
would extend mmc_fixup to contain card type (to know if cis
vendor/device should be checked) as well as name/manfid/oemid and rev
id (which is just a combination of hwrev, fwrev and date).
Feel free to change mmc_fixup.
Rafael,
Any comments here?
It's getting enabled by drivers/pci/pci-driver.c:local_pci_probe(),
before the sdhci-pci probe function runs. local_pci_probe() does:
/* Unbound PCI devices are always set to disabled and suspended.
* During probe, the device is set to enabled
Philip,
And, more important, you will do cond_resched while holding you
spinlock, which is *bad*.
What if the mmc stack will call you again from another thread? deadlock...
Assumptions -- Please Confirm
---
No need to do assumptions, schedule while
nothing negative but reset is meant to reinit the card. This is the power up
sequence for the 1st
time a card is detected.
There is no reason to do this if no card has yet enumerated. If a sdio card
was there I completely
agree with the mod since we need to reset
the card.
What
-Original Message-
From: Linus Walleij [mailto:linus.ml.wall...@gmail.com]
Sent: Monday, January 24, 2011 11:11 PM
To: Chris Ball
Cc: Tardy, Pierre; linux-mmc@vger.kernel.org; Ohad Ben-Cohen; linux-omap
Mailing List
Subject: Re: [PATCH v1 1/3]mmc: implemented runtime pm for mmc
Chris,
(Sorry for top posting)
Seems we have a intel intern disagreement.
Could we have maintainer opinion on this ?
Regards,
Pierre
-Original Message-
From: Dong, Chuanxiao
Sent: Wednesday, January 19, 2011 10:04 AM
To: Tardy, Pierre; linux-mmc@vger.kernel.org
Cc: linux-ker
I'm also worried about this patch not taking in account the 8 clock cycles
before
shutting down the clock, contrary to the clock gating fw.
If you power down hc, you will also gate the clock. So the sdio protocol
might not be
strictly followed.
As mmc spec said, 8 clock cycles is
MMC host has a sysfs interface to let user specify the auto suspended delay.
Each slot of the host controller can have a different delay for runtime
suspended.
out:
+ /* power off host controller */
+ pm_runtime_put(host-class_dev);
If you want to use autosuspend feature, then
