Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-30 Thread Wolfgang Mües
Hi, Am 29.08.2010 23:39, schrieb Ryan Mallon: I see this is already applied, but why all the type trickery here? Why not just: memcpy(dmabuf, sgbuffer, amount); dmabuf += amount / sizeof(dmabuf); Because this is wrong? Maybe you mean sizeof(*dmabuf)? The exact style of the b

Re: [PATCH 1/7] mmc: at91_mci: fix pointer errors

2010-08-30 Thread Wolfgang Mües
Hi, Am 27.08.2010 21:34, schrieb Chris Ball: On Fri, Aug 27, 2010 at 08:33:03PM +0100, Chris Ball wrote: Looks like only the first half of this patch was applied? The kunmap_atomic() line is still present as before in Linus' tree. It was argued that the kunmap_atomic() will truncate the poin

Re: [PATCH 4/7] mmc: at91_mci: use DMA buffer for read

2010-03-02 Thread Wolfgang Mües
subtraction isn't strictly needed. > > And if the subtraction is removed, the (void*) cast can also be removed. I did not know this. Thank you for pointing this out. So this part of the patch (which was purely cosmetic because I have seen no error without the subtraction) can be om

[PATCH] mmc_spi: fail gracefully if host or card do not support the switch command

2009-09-09 Thread Wolfgang Mües
;%s: problem reading switch " --- regards i. A. Wolfgang Mües -- Auerswald GmbH & Co. KG Hardware Development Telefon: +49 (0)5306 9219 0 Telefax: +49 (0)5306 9219 94 E-Mail: wolfgang.m...@auerswald.de Web: http://www.auerswald.de   --