[PATCH] mmc: dw_mmc: dw_mci_get_cd check MMC_CAP_NONREMOVABLE

2015-05-05 Thread Zhangfei Gao
When non-removable is used for emmc, MMC_CAP_NONREMOVABLE should also be checked, otherwise detection fail since present=0 Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- drivers/mmc/host/dw_mmc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host

[PATCH] mmc: dw_mmc: fix dw_mci_get_cd

2014-01-16 Thread Zhangfei Gao
-by: Zhangfei Gao zhangfei@linaro.org Reported-by: Kevin Hilman khil...@linaro.org Reviewed-by: Sachin Kamat sachin.ka...@linaro.org Tested-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/dw_mmc.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git

[PATCH] mmc: dw_mmc: fix dw_mci_get_cd

2014-01-15 Thread Zhangfei Gao
-by: Zhangfei Gao zhangfei@linaro.org Reported-by: Kevin Hilman khil...@linaro.org Reviewed-by: Sachin Kamat sachin.ka...@linaro.org Tested-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/dw_mmc.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH] mmc: dw_mmc: fix dw_mci_get_cd

2014-01-15 Thread Zhangfei Gao
-by: Zhangfei Gao zhangfei@linaro.org Reported-by: Kevin Hilman khil...@linaro.org Reviewed-by: Sachin Kamat sachin.ka...@linaro.org Tested-by: Sachin Kamat sachin.ka...@linaro.org --- drivers/mmc/host/dw_mmc.c | 12 +--- include/linux/mmc/dw_mmc.h |1 + 2 files changed, 10

Re: [PATCH 1/2] clk: hisilicon: add hi3620_mmc_clks

2014-01-14 Thread Zhangfei Gao
+static long mmc_clk_determine_rate(struct clk_hw *hw, unsigned long rate, + unsigned long *best_parent_rate, + struct clk **best_parent_p) +{ + struct clk_mmc *mclk = to_mmc(hw); + unsigned long best = 0; + + if ((rate =

[PATCH] mmc: dw_mmc: fix dw_mci_get_cd

2014-01-14 Thread Zhangfei Gao
Introdeced from commit b7db86adfa58b CDETECT is ingored since IS_ERR_VALUE(!mmc_gpio_get_cd(mmc)) does not work Add spin_lock_bh(host-lock) for atomic accessing DW_MMC_CARD_PRESENT Signed-off-by: Zhangfei Gao zhangfei@linaro.org Reported-by: Kevin Hilman khil...@linaro.org --- drivers/mmc

[PATCH 1/2] clk: hisilicon: add hi3620_mmc_clks

2014-01-13 Thread Zhangfei Gao
Suggest by Arnd: abstract mmc tuning as clock behavior, also because different soc have different tuning method and registers. hi3620_mmc_clks is added to handle mmc clock specifically on hi3620. Signed-off-by: Zhangfei Gao zhangfei@linaro.org Acked-by: Arnd Bergmann a...@arndb.de Acked

[PATCH 2/2] mmc: dw_mmc: k3: remove clk_table

2014-01-13 Thread Zhangfei Gao
Remove clk_table and directly use ios-clock as clock source rate. Abstract init clock rate and max clock limitation in clk.c Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 14 --- drivers/mmc/host/dw_mmc-k3.c

[PATCH 0/2] mmc: dw_mmc: k3 remove clk_table

2014-01-13 Thread Zhangfei Gao
clk_table is used to set clock source in each mode, as well as limitation, max_rate and init rate. It concerned many experts though, and Seungwon recommended some limitation can be hide in clk.c. Also soc is updated as the limitation now same as max_rate, so directly using ios-clock. Zhangfei

[PATCH] clk: hisilicon: add hi3620_mmc_clks

2014-01-13 Thread Zhangfei Gao
Suggest by Arnd: abstract mmc tuning as clock behavior, also because different soc have different tuning method and registers. hi3620_mmc_clks is added to handle mmc clock specifically on hi3620. Signed-off-by: Zhangfei Gao zhangfei@linaro.org Acked-by: Arnd Bergmann a...@arndb.de Acked

Re: [PATCH v7 0/3] mmc: dw_mmc: add dw_mmc-k3

2014-01-12 Thread Zhangfei Gao
On Mon, Jan 13, 2014 at 12:35 AM, Chris Ball ch...@printf.net wrote: Hi, I've pushed patches 1 and 2 to mmc-next for 3.14, with Arnd and Jaehoon's ACK -- since patch 3 depends on files that aren't in my tree, please can you push that one through arm-soc? Great, thanks Chris. The 3rd patch

[PATCH v7 0/3] mmc: dw_mmc: add dw_mmc-k3

2014-01-09 Thread Zhangfei Gao
Zhangfei Gao (3): mmc: dw_mmc: use slot-gpio to handle cd pin mmc: dw_mmc: add dw_mmc-k3 for k3 platform clk: hisilicon: add hi3620_mmc_clks .../bindings/arm/hisilicon/hisilicon.txt | 14 ++ .../devicetree/bindings/clock/hi3620-clock.txt |1 + .../devicetree/bindings/mmc/k3-dw

[PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2014-01-09 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 + drivers/mmc/host/Kconfig | 10 ++ drivers

[PATCH 3/3] clk: hisilicon: add hi3620_mmc_clks

2014-01-09 Thread Zhangfei Gao
Suggest by Arnd: abstract mmc tuning as clock behavior, also because different soc have different tuning method and registers. hi3620_mmc_clks is added to handle mmc clock specifically on hi3620. Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- .../bindings/arm/hisilicon/hisilicon.txt

[PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2014-01-01 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 + drivers/mmc/host/Kconfig | 10 ++ drivers

Re: [PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-29 Thread Zhangfei Gao
On Mon, Dec 30, 2013 at 7:55 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 12/30/2013 06:05 AM, Arnd Bergmann wrote: On Saturday 28 December 2013, Zhangfei Gao wrote: Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Signed-off-by: Zhigang

[PATCH v6 0/3] mmc: dw_mmc: add dw_mmc-k3

2013-12-28 Thread Zhangfei Gao
sending cmd 0002: Follow suggestion from Chris, Kumar and Seungwon Sync to latest mmc-next, which is 3.12-rc2 Remove enum dw_mci_k3_type etc v2: Follow Jaehoon's suggestion Use slot-gpio.c handle cd pin Move table out to dts other suggestion Zhangfei Gao (3): mmc: dw_mmc: use slot-gpio to handle cd

[PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-28 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 ++ drivers/mmc/host/Kconfig | 10 ++ drivers

[PATCH 3/3] clk: hisilicon: add hi3620_mmc_clks

2013-12-28 Thread Zhangfei Gao
Suggest by Arnd: abstract mmc tuning as clock behavior, also because different soc have different tuning method and registers. hi3620_mmc_clks is added to handle mmc clock specifically on hi3620. Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- .../bindings/arm/hisilicon/hisilicon.txt

[PATCH 1/3] mmc: dw_mmc: use slot-gpio to handle cd pin

2013-12-28 Thread Zhangfei Gao
Suggested by Jaehoon: Use slot-gpio to handle cd-gpio Add function dw_mci_of_get_cd_gpio to check cd-gpios from dts. mmc_gpio_request_cd and mmc_gpio_get_cd are used to handle cd pin Signed-off-by: Zhangfei Gao zhangfei@linaro.org Acked-by: Jaehoon Chung jh80.ch...@samsung.com --- drivers

[PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-16 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 + drivers/mmc/host/Kconfig | 10 ++ drivers

Re: [PATCHv6 1/5] mmc: dw_mmc: Add support to set the SDR and DDR timing through clock framework

2013-12-15 Thread Zhangfei Gao
On 16 December 2013 11:24, Dinh Nguyen dinh.li...@gmail.com wrote: @@ -2478,6 +2480,27 @@ int dw_mci_probe(struct dw_mci *host) dev_dbg(host-dev, ciu clock not available\n); host-bus_hz = host-pdata-bus_hz; } else { +/* If the CIU clk is available, we

[PATCH 3/3] clk: hisilicon: add hi3620_mmc_clks

2013-12-13 Thread Zhangfei Gao
Suggest by Arnd: abstract mmc tuning as clock behavior, also because different soc have different tuning method and registers. hi3620_mmc_clks is added to handle mmc clock specifically on hi3620. Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- .../bindings/arm/hisilicon/hisilicon.txt

[PATCH v5 0/3] mmc: dw_mmc: add dw_mmc-k3

2013-12-13 Thread Zhangfei Gao
slot-gpio.c handle cd pin Move table out to dts other suggestion Zhangfei Gao (3): mmc: dw_mmc: use slot-gpio to handle cd pin mmc: dw_mmc: add dw_mmc-k3 for k3 platform clk: hisilicon: add hi3620_mmc_clks .../bindings/arm/hisilicon/hisilicon.txt | 14 ++ .../devicetree/bindings

[PATCH 1/3] mmc: dw_mmc: use slot-gpio to handle cd pin

2013-12-13 Thread Zhangfei Gao
Suggested by Jaehoon: Use slot-gpio to handle cd-gpio Add function dw_mci_of_get_cd_gpio to check cd-gpios from dts. mmc_gpio_request_cd and mmc_gpio_get_cd are used to handle cd pin Signed-off-by: Zhangfei Gao zhangfei@linaro.org Acked-by: Jaehoon Chung jh80.ch...@samsung.com --- drivers

[PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-13 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 60 + drivers/mmc/host/Kconfig | 10 ++ drivers

[PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-12 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Signed-off-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 59 + drivers/mmc/host/Kconfig | 10 ++ drivers

[PATCH 3/3] clk: hisilicon: add hi3620_mmc_clks

2013-12-11 Thread Zhangfei Gao
hi3620_mmc_clks is added to handle mmc clock specifically on hi3620 Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- .../bindings/arm/hisilicon/hisilicon.txt | 14 ++ .../devicetree/bindings/clock/hi3620-clock.txt |1 + drivers/clk/hisilicon/clk-hi3620.c

[PATCH v4 0/3] mmc: dw_mmc: add dw_mmc-k3

2013-12-11 Thread Zhangfei Gao
before sending cmd 0002: Follow suggestion from Chris, Kumar and Seungwon Sync to latest mmc-next, which is 3.12-rc2 Remove enum dw_mci_k3_type etc v2: Follow Jaehoon's suggestion Use slot-gpio.c handle cd pin Move table out to dts other suggestion Zhangfei Gao (3): mmc: dw_mmc: use slot-gpio

[PATCH 1/3] mmc: dw_mmc: use slot-gpio to handle cd pin

2013-12-11 Thread Zhangfei Gao
Suggested by Jaehoon: Use slot-gpio to handle cd-gpio Add function dw_mci_of_get_cd_gpio to check cd-gpios from dts. mmc_gpio_request_cd and mmc_gpio_get_cd are used to handle cd pin Signed-off-by: Zhangfei Gao zhangfei@linaro.org Acked-by: Jaehoon Chung jh80.ch...@samsung.com --- drivers

[PATCH 2/3] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-11 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Tested-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 51 drivers/mmc/host/Kconfig | 10 ++ drivers/mmc

Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-10 Thread Zhangfei Gao
Dear Arnd On Fri, Dec 6, 2013 at 9:39 AM, Arnd Bergmann a...@arndb.de wrote: On Friday 08 November 2013, Zhangfei Gao wrote: Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Tested-by: Zhigang Wang brooke.wangzhig...@huawei.com We are currently

Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-10 Thread Zhangfei Gao
Dear Seungwon On Thu, Dec 5, 2013 at 10:00 PM, Seungwon Jeon tgih@samsung.com wrote: +static DEFINE_SPINLOCK(mmc_tuning_lock); Can the above variables be involved in dw_mci_k3_priv_data instead of global declaration? Unfortunately, this can be be put in priv_data, which is different

Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-12-10 Thread Zhangfei Gao
Dear Rob On Thu, Dec 5, 2013 at 10:29 PM, Rob Herring robherri...@gmail.com wrote: On Thu, Nov 7, 2013 at 11:38 PM, Zhangfei Gao zhangfei@linaro.org wrote: +++ b/Documentation/devicetree/bindings/mmc/k3-dw-mshc.txt @@ -0,0 +1,83 @@ +* Hisilicon specific extensions to the Synopsys

[PATCH 1/2] mmc: dw_mmc: add dw_mci_of_get_cd_gpio to handle cd pin

2013-12-02 Thread Zhangfei Gao
Change function dw_mci_of_get_cd_gpio type to void suggested by Jaehoon And check any other comments Thanks Add function dw_mci_of_get_cd_gpio to check cd-gpios from dts. mmc_gpio_request_cd and mmc_gpio_get_cd are used to handle cd pin Signed-off-by: Zhangfei Gao zhangfei@linaro.org CC

[PATCH 1/2] mmc: dw_mmc: add dw_mci_of_get_cd_gpio to handle cd pin

2013-11-07 Thread Zhangfei Gao
Add function dw_mci_of_get_cd_gpio to check cd-gpios from dts. mmc_gpio_request_cd and mmc_gpio_get_cd are used to handle cd pin Signed-off-by: Zhangfei Gao zhangfei@linaro.org CC: Jaehoon Chung jh80.ch...@samsung.com --- drivers/mmc/host/dw_mmc.c | 52

[PATCH v3 0/2] mmc: dw_mmc: add dw_mmc-k3

2013-11-07 Thread Zhangfei Gao
suggestion Use slot-gpio.c handle cd pin Move table out to dts other suggestion Zhangfei Gao (2): mmc: dw_mmc: add dw_mci_of_get_cd_gpio to handle cd pin mmc: dw_mmc: add dw_mmc-k3 for k3 platform .../devicetree/bindings/mmc/k3-dw-mshc.txt | 83 +++ drivers/mmc/host/Kconfig

[PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-11-07 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Tested-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 83 +++ drivers/mmc/host/Kconfig | 10 + drivers/mmc/host

Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-11-01 Thread zhangfei gao
Dear Seungwon Thanks for giving suggestion. On Thu, Oct 31, 2013 at 11:24 PM, Seungwon Jeon tgih@samsung.com wrote: Hi Zhangfei, +static void dw_mci_k3_set_ios(struct dw_mci *host, struct mmc_ios *ios) +{ + struct dw_mci_k3_priv_data *priv = host-priv; + + if (priv-type ==

Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-11-01 Thread zhangfei gao
On Fri, Nov 1, 2013 at 1:21 AM, Seungwon Jeon tgih@samsung.com wrote: On Fri, November 01, 2013, zhangfei gao wrote: Dear Seungwon Thanks for giving suggestion. On Thu, Oct 31, 2013 at 11:24 PM, Seungwon Jeon tgih@samsung.com wrote: Hi Zhangfei, +static void dw_mci_k3_set_ios

Re: [PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-10-29 Thread zhangfei gao
Dear Kumar Thanks for the careful review. On Sun, Oct 27, 2013 at 11:29 PM, Kumar Gala ga...@codeaurora.org wrote: On Oct 23, 2013, at 8:03 AM, Zhangfei Gao wrote: +Required Properties: + +* compatible: should be + - hisilicon,hi4511-dw-mshc: for controllers with hi4511

[PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-10-23 Thread Zhangfei Gao
update: fix typo Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Tested-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 77 + drivers/mmc/host/Kconfig | 10

[PATCH 1/2] mmc: dw_mmc: add dw_mci_of_get_cd_gpio to handle cd pin

2013-10-21 Thread Zhangfei Gao
Add function dw_mci_of_get_cd_gpio to check cd-gpios from dts. mmc_gpio_request_cd and mmc_gpio_get_cd are used to handle cd pin Signed-off-by: Zhangfei Gao zhangfei@linaro.org CC: Jaehoon Chung jh80.ch...@samsung.com --- drivers/mmc/host/dw_mmc.c | 34 ++ 1

[v2 PATCH 0/2] mmc: dw_mmc: add dw_mmc-k3

2013-10-21 Thread Zhangfei Gao
v2: Follow Jaehoon's suggestion Use slot-gpio.c handle cd pin Move table out to dts other suggestion Zhangfei Gao (2): mmc: dw_mmc: add dw_mci_of_get_cd_gpio to handle cd pin mmc: dw_mmc: add dw_mmc-k3 for k3 platform .../devicetree/bindings/mmc/k3-dw-mshc.txt | 77 + drivers

[PATCH 2/2] mmc: dw_mmc: add dw_mmc-k3 for k3 platform

2013-10-21 Thread Zhangfei Gao
Add dw_mmc-k3.c for k3v2, support sd/emmc Signed-off-by: Zhangfei Gao zhangfei@linaro.org Tested-by: Zhigang Wang brooke.wangzhig...@huawei.com --- .../devicetree/bindings/mmc/k3-dw-mshc.txt | 77 + drivers/mmc/host/Kconfig | 10 + drivers/mmc/host

Re: [PATCH 2/2] mmc: add dw-mmc-k3

2013-10-18 Thread zhangfei gao
Dear Jaehoon Thanks for the valueable suggestion. On Mon, Oct 14, 2013 at 5:27 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi, If you will send the patch, plz, add the prefix mmc: dw_mmc: xxx at subject. OK, got it. And i think good that device-tree and mmc patch is separated. It is

[PATCH 1/2] mmc: dw_mmc: change definition of get_cd

2013-10-10 Thread Zhangfei Gao
int (*get_cd)(struct dw_mci *host, u32 slot_id) Add host info to pass priv, where contains cd pin Signed-off-by: Zhangfei Gao zhangfei@linaro.org --- drivers/mmc/host/dw_mmc.c |2 +- include/linux/mmc/dw_mmc.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH V3 3/4] mmc: block: Enable runtime pm for mmc blkdevice

2013-05-28 Thread zhangfei gao
Maybe I make misunderstood, or do some mistake. since CONFIG_MMC_UNSAFE_RESUME has to be set, is that mean sd card can not be unpluged with the feature enabled. It can be reproduced here if unplug card in suspend or not. static void mmc_sd_detect(struct mmc_host *host) { err =

Re: [PATCH V4 1/4] mmc: core: Stop bkops for eMMC only from mmc suspend

2013-05-25 Thread zhangfei gao
On Thu, May 2, 2013 at 8:02 PM, Ulf Hansson ulf.hans...@stericsson.com wrote: From: Ulf Hansson ulf.hans...@linaro.org Move mmc suspend specific operations to be executed from the .suspend callback in the mmc bus_ops. This simplifies the mmc_suspend_host function which is supposed to handle

Re: [PATCH v5 07/13] mmc: sdhci-pxav3: controller can't get base clock

2012-09-29 Thread zhangfei gao
-by: Kevin Liu kl...@marvell.com Acked-by: Zhangfei Gao zhangfei@marvell.com -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v5 10/13] mmc: sdhci-pxav3: add quirks2

2012-09-29 Thread zhangfei gao
On Fri, Sep 28, 2012 at 3:56 PM, Kevin Liu keyuan@gmail.com wrote: From: Kevin Liu kl...@marvell.com Signed-off-by: Kevin Liu kl...@marvell.com Acked-by: Zhangfei Gao zhangfei@marvell.com --- drivers/mmc/host/sdhci-pxav3.c |2 ++ include/linux/platform_data

Re: [PATCH v5 13/13] mmc: sdhci-pxav3: remove set_uhs_signaling function

2012-09-29 Thread zhangfei gao
On Fri, Sep 28, 2012 at 3:56 PM, Kevin Liu keyuan@gmail.com wrote: From: Kevin Liu kl...@marvell.com Because sdhci can do the same thing so no need to implement this. Signed-off-by: Kevin Liu kl...@marvell.com Acked-by: Zhangfei Gao zhangfei@marvell.com If so, (*set_uhs_signaling

Re: [PATCH v4 04/15] mmc: sdhci: keep the saved clock var up to date

2012-09-27 Thread zhangfei gao
On Wed, Sep 26, 2012 at 7:38 PM, Kevin Liu keyuan@gmail.com wrote: From: Kevin Liu kl...@marvell.com The clock rate set to the sdh controller may not exactly as requested by the mmc core, this patch make the clock rate saved in the mmc_ios and sdhci_host updated with the actual setting as

Re: [PATCH v4 06/15] mmc: sdhci-pxav3: controller can't get base clock

2012-09-27 Thread zhangfei gao
On Wed, Sep 26, 2012 at 7:38 PM, Kevin Liu keyuan@gmail.com wrote: From: Kevin Liu kl...@marvell.com Enable the quirk SDHCI_QUIRK_CAP_CLOCK_BASE_BROKEN since SD_CAPABILITIES_1[15:8](BASE_FREQ) can't get correct base clock value. It return a fixed pre-set value like 200 on some

Re: [PATCH v4 11/15] mmc: sdhci-pxav3: add signal_voltage_switch function

2012-09-27 Thread zhangfei gao
+ if (pdata pdata-signal_voltage_switch) + pdata-signal_voltage_switch(set); +} + #ifdef CONFIG_OF diff --git a/include/linux/platform_data/pxa_sdhci.h b/include/linux/platform_data/pxa_sdhci.h index fdf38d6..3b94ab1 100644 ---

Re: [PATCH v4 09/15] mmc: sdhci-pxav3: add quirks2

2012-09-27 Thread zhangfei gao
diff --git a/include/linux/platform_data/pxa_sdhci.h b/include/linux/platform_data/pxa_sdhci.h index 59acd98..fdf38d6 100644 --- a/include/linux/platform_data/pxa_sdhci.h +++ b/include/linux/platform_data/pxa_sdhci.h @@ -38,6 +38,7 @@ * @max_speed: the maximum speed supported *

Re: [PATCH v4 01/15] mmc: sdhci: fix transfer mode setting bug for cmds w/o data transfer

2012-09-26 Thread zhangfei gao
cmd18/cmd25 will have timeout error since audo cmd23 has been enabled. Signed-off-by: Jialing Fu j...@marvell.com Signed-off-by: Tim Wang wan...@marvell.com Signed-off-by: Kevin Liu kl...@marvell.com --- Reviewed-by: Zhangfei Gao zhangfei@marvell.com -- To unsubscribe from this list: send

Re: [PATCH] mmc: sdhci-pxav3: Use sdhci_get_of_property for parsing DT quirks

2012-09-19 Thread zhangfei gao
a better idea to discard that patch and use this one instead.) Thanks Chris, it's really better. Acked-by: Zhangfei Gao zhangfei@marvell.com -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH] mmc: sdhci-pxav3: dt: Support power-gpios property

2012-09-10 Thread zhangfei gao
On Sun, Sep 9, 2012 at 11:06 AM, Chris Ball c...@laptop.org wrote: Tested on OLPC XO-4/MMP3, where the card power for two of the controllers is a sideband GPIO. The third cell in the power-gpios property controls whether the GPIO is active high/active low. (Also, pass host_caps2 through from

Re: [PATCH] mmc: sdhci-pxa: Add device tree support

2012-06-12 Thread zhangfei gao
On Wed, Jun 13, 2012 at 3:05 AM, Chris Ball c...@laptop.org wrote: Tested on an OLPC XO-1.75.  (MMP2, sdhci-pxav3, CONFIG_MACH_MMP2_DT=y) Signed-off-by: Chris Ball c...@laptop.org ---  .../devicetree/bindings/mmc/sdhci-pxa.txt          |   21  drivers/mmc/host/sdhci-pxav2.c          

Re: [PATCH] mmc: sdhci-pxa: Check pdata before using its members

2011-09-14 Thread zhangfei gao
On Wed, Sep 14, 2011 at 1:59 PM, Tanmay Upadhyay tanmay.upadh...@einfochips.com wrote: Signed-off-by: Tanmay Upadhyay tanmay.upadh...@einfochips.com Acked-by: Zhangfei Gao zhangfei@marvell.com Thanks ---  drivers/mmc/host/sdhci-pxav2.c |    4 ++--  1 files changed, 2 insertions(+), 2

[PATCH v3 0/2] mmc add vsdio to dynamically control sdio power

2011-08-25 Thread Zhangfei Gao
v2-v3, change vmmc to vsdio In v2, vmmc is reused, however, sd may be impacted if move vmmc to set_ios. When no card inserted, CD is high, vmmc will be disabled when detect fail, CD will pull low accordingly, controller may treat as card inserted and re-detect. Zhangfei Gao (2): mmc: sdio add

[PATCH v3 1/2] mmc: sdio add regulator vsdio

2011-08-25 Thread Zhangfei Gao
sdio client may be required power on/off dynamically. With regulator vsdio, sdio client power on/off could be executed by mmc_power_up/down CC: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- drivers/mmc/host/sdhci.c | 22

[PATCH v3 2/2] ARM: mmp2: support sdio with regulator vsdio

2011-08-25 Thread Zhangfei Gao
/stop_host Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- arch/arm/mach-mmp/brownstone.c | 60 ++- 1 files changed, 58 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp/brownstone.c index c79162a..752c5bf 100644

Re: [PATCH 1/2] mmc: sdhci move vmmc to set_ios

2011-08-24 Thread zhangfei gao
On Tue, Jul 26, 2011 at 3:06 PM, Zhangfei Gao zhangfei@marvell.com wrote: Move vmmc to set_ios, as a result mmc_power_up/down handles regulator_enable/disable vmmc Move regulator outof spin_lock, since usually i2c operation is called Remove vmmc from suspend/resume function, instead vmmc

Re: [PATCH 2/2] ARM: mmp2: support sdio device 8787

2011-07-27 Thread zhangfei gao
+ +static struct fixed_voltage_config sdio_power = { +     .supply_name            = vmmc, +     .microvolts             = 300, +     .gpio                   = mfp_to_gpio(MFP_PIN_GPIO57), +     .enable_high            = 1, +     .enabled_at_boot        = 0, +     .init_data            

Re: [PATCH 2/2] ARM: mmp2: support sdio device 8787

2011-07-27 Thread zhangfei gao
On Thu, Jul 28, 2011 at 12:23 PM, Philip Rakity prak...@marvell.com wrote: On Jul 27, 2011, at 7:44 PM, zhangfei gao wrote: + +static struct fixed_voltage_config sdio_power = { +     .supply_name            = vmmc, +     .microvolts             = 300, +     .gpio

[PATCH v2 0/2] set_ios handle vmmc

2011-07-26 Thread Zhangfei Gao
v2: reuse vmmc vmmc is controled inside set_ios according to mmc_power_up/down Brownstone add support of sdio device 8787 Zhangfei Gao (2): mmc: sdhci move vmmc to set_ios ARM: mmp2: support sdio device 8787 arch/arm/mach-mmp/brownstone.c | 60

[PATCH 2/2] ARM: mmp2: support sdio device 8787

2011-07-26 Thread Zhangfei Gao
-by: Zhangfei Gao zhangfei@marvell.com --- arch/arm/mach-mmp/brownstone.c | 60 ++- 1 files changed, 58 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp/brownstone.c index c79162a..46a67b9 100644 --- a/arch/arm/mach-mmp

Re: [PATCH] mmc: sdio add regulator vsdio

2011-07-22 Thread zhangfei gao
On Fri, Jul 22, 2011 at 2:50 PM, Daniel Drake d...@laptop.org wrote: On 21 July 2011 03:34, Zhangfei Gao zhangfei@marvell.com wrote: sdio client may be required power on/off dynamically. With regulator vsdio, sdio client power on/off could be executed by mmc_power_up/down I think you

Re: [PATCH] mmc: sdhci: fix retuning timer wrongly deleted in sdhci_tasklet_finish

2011-07-22 Thread zhangfei gao
On Thu, Jul 21, 2011 at 6:03 PM, Aaron Lu aaron...@amd.com wrote: On Thu, Jul 21, 2011 at 05:35:02PM +0800, zhangfei gao wrote: Does the execute_tuning is called again? del_timer is not delete timer really, but deactivate the timer, which could be re-activated by mod_timer. So

Re: mmc: sdio add regulator vsdio

2011-07-21 Thread zhangfei gao
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 790f959..61fff10 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -1295,6 +1295,18 @@ static void sdhci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)       sdhci_set_clock(host, ios-clock); +    

Re: mmc: sdio add regulator vsdio

2011-07-21 Thread zhangfei gao
+ +static int __init brownstone_init_mmc(void) +{ +      /* +       * PDn: GPIO58; RESETn: GPIO57 +       * 8787, RESETn keeps high, PDn control power +       * on: PDn 1; off: PDn 0; +       */ Comment unclear GPIO57 is power GPIO58 is reset yes, typo, thanks +      int RESETn =

[PATCH] sdio add regulator vsdio to dynamic control sdio power

2011-07-20 Thread Zhangfei Gao
sdio client has the requirement to dynamically power on/off With regulator vsdio, so sdio client power on/off when mmc_power_up/down Add brownstone support sdio with regulator vsdio, Zhangfei Gao (2): mmc: sdio add regulator vsdio ARM: mmp2: support sdio with regulator vsdio arch/arm/mach

[PATCH] mmc: sdio add regulator vsdio

2011-07-20 Thread Zhangfei Gao
sdio client may be required power on/off dynamically. With regulator vsdio, sdio client power on/off could be executed by mmc_power_up/down CC: Ohad Ben-Cohen o...@wizery.com Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- drivers/mmc/host/sdhci.c | 24

[PATCH] ARM: mmp2: support sdio with regulator vsdio

2011-07-20 Thread Zhangfei Gao
/stop_host Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- arch/arm/mach-mmp/brownstone.c | 60 ++- 1 files changed, 58 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-mmp/brownstone.c b/arch/arm/mach-mmp/brownstone.c index c79162a..63315e2 100644

Re: [PATCH] sdhci: pxav3 controller needs 32 bit ADMA addressing

2011-07-13 Thread zhangfei gao
*/        host-mmc-caps |= MMC_CAP_1_8V_DDR; -- 1.7.0.4 Acked-by: Zhangfei Gao zhangfei@marvell.com -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3] arm: mach-mmp: brownstone.c support multiple sd slots

2011-07-06 Thread zhangfei gao
On Wed, Jul 6, 2011 at 4:20 AM, Philip Rakity prak...@marvell.com wrote: Subject: [PATCH V3] arm: mach-mmp: brownstone.c support multiple sd slots V3 == Change since V2 -- delete mmc3 since it was committed to linux next. enable mmc1 used for wifi (8688) and marked PERMANENT. Wifi

Re: [PATCH v2] arm: mach-mmp: brownstone.c support multiple sd slots

2011-07-05 Thread zhangfei gao
On Tue, Jul 5, 2011 at 2:52 PM, Eric Miao eric.y.m...@gmail.com wrote: On Fri, Apr 29, 2011 at 4:45 AM, Philip Rakity prak...@marvell.com wrote: Support multiple sd/eMMC interfaces. enable mmc1, 2, and 3. mmc2 is used eMMC and slot is marked PERMANENT and 8 bit device. mmc1 is used for Wifi

Re: [PATCH] mmc: sdio: reset card during power_restore

2011-06-29 Thread zhangfei gao
So wlan probe function should be called for re-downloading, is it be achieved by calling pm_runtime_get_sync and mmc_power_restore_host? Not really; I assume you refer to libertas_sdio, which AFAICT, is built to power on the device (and configure it) on -probe(), and then power it off on

Re: [PATCH] mmc: sdio: reset card during power_restore

2011-06-28 Thread zhangfei gao
Hi, Ohad One question :( Under pm_runtime mechanism, how to dynamically open/close wlan. If the wlan chip really power off, the firmware should be reloaded, since the firmware is download to ram and disappear after power off. So wlan probe function should be called for re-downloading, is it be

[PATCH] mmc: sdhci-pxa move platform data to include/linux/platform_data

2011-06-20 Thread Zhangfei Gao
-by: Zhangfei Gao zhangfei@marvell.com CC: Arnd Bergmann a...@arndb.de --- arch/arm/mach-mmp/include/mach/mmp2.h |2 +- drivers/mmc/host/Kconfig |2 ++ drivers/mmc/host/sdhci-pxav2.c |2 +- drivers/mmc/host/sdhci-pxav3.c

[PATCH] mmc: sdhci-pxa move platform data to include/linux/platform_data

2011-06-20 Thread Zhangfei Gao
: Stephen Rothwell s...@canb.auug.org.au Signed-off-by: Zhangfei Gao zhangfei@marvell.com Acked-by: Arnd Bergmann a...@arndb.de --- arch/arm/mach-mmp/include/mach/mmp2.h |2 +- drivers/mmc/host/Kconfig |2 ++ drivers/mmc/host/sdhci-pxav2.c

Re: UHS-I bus speed mode should be set last in UHS initialization

2011-06-17 Thread zhangfei gao
Rakity; zhangfei gao; c...@laptop.org; linux- m...@vger.kernel.org; Lu, Aaron Subject: RE: UHS-I bus speed mode should be set last in UHS initialization Adding Philip and Zhangfei. Hi Subhash, Does your controller follow some non-standard steps for initialization? I referred to Figure 3-14

Re: [PATCH v4 2/5] mmc: support sdhci-pxav2.c

2011-06-14 Thread zhangfei gao
+static void pxav2_set_private_registers(struct sdhci_host *host, u8 mask) +{ +     struct platform_device *pdev = to_platform_device(mmc_dev(host-mmc)); +     struct sdhci_pxa_platdata *pdata = pdev-dev.platform_data; + +     if (mask == SDHCI_RESET_ALL) { +             u16 tmp = 0; + +  

Re: MMC runtime PM patches break libertas probe

2011-06-10 Thread zhangfei gao
On Fri, Jun 10, 2011 at 12:28 PM, Ohad Ben-Cohen o...@wizery.com wrote: Hi Zhangfei, On Fri, Jun 10, 2011 at 5:02 AM, zhangfei gao zhangfei@gmail.com wrote: Here is answer got from the sd8686 maintainer. For 8686, the SDIO state machine can only handle init sequence (CMD5, 5, 3, 7) from

[PATCH v4 1/5] mmc: support sdhci-pxav3.c

2011-06-08 Thread Zhangfei Gao
SDHCI driver for PXAV3 SoCs, such as MMP2, the driver based on sdhci-pltfm to handle resource etc. Signed-off-by: Zhangfei Gao zhangfei@marvell.com Signed-off-by: Philip Rakity prak...@marvell.com --- arch/arm/plat-pxa/include/plat/sdhci.h | 35 - drivers/mmc/host/Kconfig

[PATCH v4 2/5] mmc: support sdhci-pxav2.c

2011-06-08 Thread Zhangfei Gao
SDHCI driver for PXAV2 SoCs, such as pxa910, the driver based on sdhci-pltfm to handle resource etc. Signed-off-by: Zhangfei Gao zhangfei@marvell.com Signed-off-by: Jun Nie n...@marvell.com Signed-off-by: Qiming Wu w...@marvell.com --- drivers/mmc/host/Kconfig | 12

[PATCH v4 3/5] ARM: mmp2: update mmp2 mmc resource

2011-06-08 Thread Zhangfei Gao
mmp2 mmc driver name update to sdhci-pxav3 according to sdhci-pxav3.c Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- arch/arm/mach-mmp/brownstone.c | 10 +- arch/arm/mach-mmp/jasper.c |2 +- arch/arm/mach-mmp/mmp2.c | 16 3 files

Re: [PATCH v3 2/4] mmc: support sdhci-pxav2.c

2011-06-07 Thread zhangfei gao
On Sat, Jun 4, 2011 at 8:04 AM, Philip Rakity prak...@marvell.com wrote: On Jun 3, 2011, at 11:42 AM, Philip Rakity wrote: On Jun 3, 2011, at 2:50 AM, Zhangfei Gao wrote:     SDHCI driver for pxav2 SoCs, such as pxa910, the driver based on sdhci-pltfm to handle resource etc. Signed

Re: [PATCH v2 1/3] mmc: support sdhci-mmp2

2011-06-07 Thread zhangfei gao
On Wed, Jun 8, 2011 at 7:51 AM, Philip Rakity prak...@marvell.com wrote: On May 29, 2011, at 10:42 PM, zhangfei gao wrote: There is a little room for simplification, I think: +static unsigned int mmp2_get_ro(struct sdhci_host *host) +{ +     /* Micro SD does not support write-protect

Re: [PATCH v3 0/3] provide sdhci driver for mmp2 and pxa910

2011-06-06 Thread zhangfei gao
On Sat, Jun 4, 2011 at 5:08 AM, Philip Rakity prak...@marvell.com wrote: Please update mmp2 and pxa defconfigs. The trend is replacing defconfig with device tree, it may not acceptable to update defconfig. regards, Philip On Jun 3, 2011, at 2:48 AM, zhangfei gao wrote: v2-v3, modify

Re: [PATCH] mmc: support sdhci-mmp2

2011-05-31 Thread zhangfei gao
On Tue, May 31, 2011 at 4:47 AM, Philip Rakity prak...@marvell.com wrote: On May 30, 2011, at 6:15 AM, zhangfei gao wrote: On Sat, May 28, 2011 at 1:00 AM, Philip Rakity prak...@marvell.com wrote: Hi Zhangfei, comments below. (based on V1 patch but change to V2 affect (31) typo. Philip

Re: [PATCH v2 1/3] mmc: support sdhci-mmp2

2011-05-30 Thread zhangfei gao
On Mon, May 30, 2011 at 3:11 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 30 May 2011 07:42:04 zhangfei gao wrote: On Fri, May 27, 2011 at 11:46 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 25 May 2011, Zhangfei Gao wrote: +static unsigned int mmp2_get_ro(struct sdhci_host *host

Re: [PATCH v2 1/3] mmc: support sdhci-mmp2

2011-05-29 Thread zhangfei gao
On Fri, May 27, 2011 at 11:46 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 25 May 2011, Zhangfei Gao wrote:       Instead of sharing sdhci-pxa.c, use sdhci-mmp2.c specificlly for mmp2.       sdhci-pxa.c is used to share among pxa serious, like pxa910, mmp2, etc.       The platfrom

Re: [PATCH] mmc: support sdhci-mmp2

2011-05-25 Thread zhangfei gao
On Mon, May 23, 2011 at 11:01 AM, Arnd Bergmann a...@arndb.de wrote: On Monday 23 May 2011, Zhangfei Gao wrote:         Delete sdhci-pxa.c and replace with sdhci-mmp2.c specificlly for mmp2 Signed-off-by: Zhangfei Gao zhangfei@marvell.com ---  arch/arm/plat-pxa/include/plat/sdhci.h

Re: [PATCH] mmc: support sdhci-mmp2

2011-05-25 Thread zhangfei gao
without adding hook for 74 clock generation. On May 23, 2011, at 6:21 AM, Zhangfei Gao wrote:        Delete sdhci-pxa.c and replace with sdhci-mmp2.c specificlly for mmp2 Signed-off-by: Zhangfei Gao zhangfei@marvell.com --- arch/arm/plat-pxa/include/plat/sdhci.h |   43 - drivers

[PATCH v2 0/3] provide sdhci driver for mmp2 and pxa910

2011-05-25 Thread zhangfei gao
Here are patches to provide separate sdhci driver for mmp2 and pxa910 based on sdhci-platfm. Remove sdhci-pxa.c, which is used to share among pxa serious, since under this method, platform difference have to be put under arch/arm, which is not easy to track. As a result, mmp2 mmc resource should

[PATCH v2 1/3] mmc: support sdhci-mmp2

2011-05-25 Thread Zhangfei Gao
Instead of sharing sdhci-pxa.c, use sdhci-mmp2.c specificlly for mmp2. sdhci-pxa.c is used to share among pxa serious, like pxa910, mmp2, etc. The platfrom difference are put under arch/arm, while is not easy to track. Signed-off-by: Zhangfei Gao zhangfei@marvell.com

[PATCH v2 2/3] mmc: support sdhci-pxa910

2011-05-25 Thread Zhangfei Gao
SDHCI driver for pxa910 SoCs, the driver based on sdhci-pltfm to handle resource etc. Signed-off-by: Zhangfei Gao zhangfei@marvell.com Signed-off-by: Jun Nie n...@marvell.com Signed-off-by: Qiming Wu w...@marvell.com --- drivers/mmc/host/Kconfig| 13 ++ drivers/mmc/host

  1   2   3   >