[RFC PATCH] mmc: move clock gating work to power efficient workqueue

2014-01-31 Thread Zoran Markovic
Cc: Guennadi Liakhovetski Cc: Ulf Hansson Cc: H Hartley Sweeten Cc: Andrew Morton Cc: Simon Baatz Cc: Laurent Pinchart Cc: Tejun Heo Signed-off-by: Shaibal Dutta [zoran.marko...@linaro.org: Rebased to latest kernel. Added commit message. Fixed code alignment.] Signed-off-by: Zoran Markovic

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-10-10 Thread Zoran Markovic
I like the simplified approach taken in this patch. Shortening the awake time by trying to call __pm_relax() in all corner cases turned out to be too complex. Reviewed-by: Zoran Markovic Regards, Zoran On 1 October 2013 02:22, Ulf Hansson wrote: > Hi John, > >> So how does the

Re: [RFC/PATCH] mmc: core: Signal wakeup event at card insert/removal

2013-09-23 Thread Zoran Markovic
Hi Ulf, I like the fact that wakeups are now quite simplified. A couple of comments below: > By signaling the wakeup event for a time of 5 s for devices configured > as wakeup capable, we likely will be prevent a sleep long enough to let > user space consume the event. Given that there is no pm_re

Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-09-05 Thread Zoran Markovic
Hi Ulf, Thanks for reviewing this, it was very helpful! > 1. mmc_detect_change does obviously not have to be run the same number > of times as the mmc_rescan function. In other words, the calls to > __pm_stay_awake is not paired with __pm_relay, I suppose this does not > matter? It shouldn't, sinc

Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-08-22 Thread Zoran Markovic
Ulf, > I got confirmation from Broadcom that all cell phone reference designs > have card insert/removal configured as a wakeup IRQ. Unless our > customers change that - which I doubt - this results in a considerable > number of products implementing this feature. > > Please let me know how you wis

Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-08-01 Thread Zoran Markovic
proceed. Cheers, Zoran On 26 June 2013 13:57, Ulf Hansson wrote: > On 24 June 2013 21:58, Zoran Markovic wrote: >>>> This patch is ported from the Android common tree, so you've probably >>>> been using it. >>> >>> We removed more or less all An

Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-06-24 Thread Zoran Markovic
>> This patch is ported from the Android common tree, so you've probably >> been using it. > > We removed more or less all Android code in the mmc subsystem, since > it just didn't work. :-) > > The "deferred resume" was very useful though, so after some rework we > kept it and could then improve t

Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-06-14 Thread Zoran Markovic
> I am not sure I understand why this patch is needed. When a new card > is inserted/removed and the upper levels gets notification about the > new card, triggering the mounting/un-mounting of the file system, why > should it be the lowest layer (mmc) that prevents the platform from > enter suspend

[RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-06-13 Thread Zoran Markovic
ed to use wakeup_source_register/unregister instead of wakeup_source_init/trash, added the missing __pm_relax() for non-removable devices in mmc_rescan().] Signed-off-by: Zoran Markovic --- drivers/mmc/core/core.c | 31 +-- drivers/mmc/core/host.c |7 +++ in