Re: [PATCH 1/4] clk: st: STiH410: Fix pdiv and fdiv divisor when setting rate

2015-01-20 Thread Mike Turquette
tly when booting an upstream kernel. > > Signed-off-by: Peter Griffin > Signed-off-by: Giuseppe Cavallaro Applied to clk-next. Regards, Mike > --- > drivers/clk/st/clk-flexgen.c | 19 +++ > 1 file changed, 15 insertions(+), 4 deletions(-) > > diff --git a/

Re: [RFC 0/3] mmc: Add dynamic frequency scaling

2015-01-17 Thread Mike Turquette
Quoting Ulf Hansson (2015-01-15 02:04:04) > On 15 January 2015 at 10:20, Krzysztof Kozlowski > wrote: > > On czw, 2015-01-15 at 09:20 +0100, Ulf Hansson wrote: > >> + Mike, Stephen (Clock maintainers) > >> > >> On 12 January 2015 at 10:23, Krz

Re: [PATCH 2/2] mmc/host/sdhci-of-arasan.c: Skip EPROBE_DEFER error messages

2014-10-28 Thread Mike Looijmans
As discussed here, I'll post a new patch which simply removes the error messages. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] mmc/host/sdhci-of-arasan.c: Omit superfluous error messages

2014-10-28 Thread Mike Looijmans
sdhci_add_host and sdhci_platfm_init already report failure, so don't emit error messages when a failure occurs. This prevents occurences of "deferred" messages when required power supplies are not ready for operation yet. Signed-off-by: Mike Looijmans --- drivers/mmc/host/sd

[PATCH 1/2] mmc/host/sdhci-of-arasan.c: Use signed formatting in error messages

2014-10-23 Thread Mike Looijmans
"ret" is a signed int, so use "%d" in format strings instead of "%u". This prevents cryptic codes in error messages like this: sdhci-arasan e0101000.sdhci: platform register failed (4294966779) Signed-off-by: Mike Looijmans Reviewed-by: Michal Simek --- driv

[PATCH 2/2] mmc/host/sdhci-of-arasan.c: Skip EPROBE_DEFER error messages

2014-10-23 Thread Mike Looijmans
When the error code is -EPROBE_DEFER, this will already be reported so don't emit an error message in that case. Signed-off-by: Mike Looijmans --- drivers/mmc/host/sdhci-of-arasan.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/sdhci-of-ara

Re: [PATCH v3 03/12] clk: Add a function to retrieve phase

2014-09-27 Thread Mike Turquette
e (e.g. coming out of idle). Correct me if I am wrong, but it looks like we retrieve the phase only once at init and then never again? The rest of the time we rely on clk->phase to always be accurate... Regards, Mike > + > + /* > * Set clk's rate. The preferred metho

Re: [PATCH v2 10/12] clk: sunxi: mod0: Introduce MMC proper phase handling

2014-09-01 Thread Mike Turquette
, and the other values being the number of periods from the MMC parent > clock to outphase the clock of. > > Signed-off-by: Maxime Ripard Looks good. Thanks a lot for revisiting this after talking to your hardware team! Regards, Mike > --- > Documentation/devicetree/binding

Re: [PATCH v2 03/12] clk: Add a function to retrieve phase

2014-09-01 Thread Mike Turquette
ers may be much slower than to memory. Do you expect the phase to be changed behind our backs? E.g. firmware changes it, or coming in and out of idle state, etc. If not then we can store the phase at clock registration time and use a cached value. See how the CLK_GET_RATE_NOCACHE and CLK_GET_ACC

[PATCH] davinci-mmc: Use IRQ to detect "card not busy" status change

2014-08-28 Thread Mike Looijmans
ce or reliability. Tested on a custom board with an OMAP-L138 CPU. Patch originally applied to a 2.6.37 kernel and ported to 3.14. Signed-off-by: Mike Looijmans --- drivers/mmc/host/davinci_mmc.c | 52 +--- 1 file changed, 33 insertions(+), 19 deletions(-)

Re: [PATCH] davinci-mmc: Use IRQ to detect "card not busy" status change

2014-08-28 Thread Mike Looijmans
Note: I have not been able to test or even compile this on recent kernels. Can somebody verify that this does not kill the SD driver? Mike. On 08/29/2014 08:41 AM, Mike Looijmans wrote: The davinci-mmc driver uses a busy wait loop to wait for the card to become ready (BUSY signal). The MMC

Re: sdhci_s3c_consider_clock scheduling while atomic - clk_round_rate

2014-08-18 Thread Mike Turquette
On Tue, Jun 24, 2014 at 8:52 AM, Tomasz Figa wrote: > Hi Daniel, > > [adding Ulf, Chris and Mike to the discussion] > > On 24.06.2014 11:48, Daniel Drake wrote: >> sdhci_s3c_set_clock is called from sdhci_do_set_ios with interrupts >> disabled, and this calls in

determine erased regions (was: mmc-utils on android)

2014-07-07 Thread Mike Wilson
e how much of the storage that has been explicitly erased? (looking at mmc-utils source it seems it is not what I need) Thanks Mike Mike Wilson wrote: > I'm trying to recover some data from the eMMC on an Android > phone (Samsung Galaxy S3). Is there a build of mmc-utils I > ca

mmc-utils on android

2014-07-05 Thread Mike Wilson
I'm trying to recover some data from the eMMC on an Android phone (Samsung Galaxy S3). Is there a build of mmc-utils I can push to the phone? Thanks Mike -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org

Re: [GIT PULL] MMC updates for 3.16-rc1

2014-06-10 Thread Mike Turquette
t merged in two different trees. > It's clearly the same patches and drivers, but I got them first > through the MFD tree (Realtek) and the clock tree (sunxi) trees and > now the MMC tree. Bummer. The sunxi mmc driver came through the clock tree to handle a linux-next merge i

Re: [PATCH v10 00/15] ARM: sunxi: Add driver for SD/MMC hosts found on Allwinner sunxi SoCs

2014-05-06 Thread Mike Turquette
Quoting Hans de Goede (2014-05-02 08:57:14) > The first 2 patches are depenencies which should go in through the clk tree, > Mike can you pick these 2 up please ? : Taken into clk-next. > > "clk: sunxi: factors: automatic reparenting support" > Is uncontroversi

Re: [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-04-07 Thread Mike Looijmans
On 04/07/2014 02:51 PM, Arnd Bergmann wrote: On Monday 07 April 2014 14:32:20 Mike Looijmans wrote: On 04/07/2014 02:25 PM, Arnd Bergmann wrote: Judging from the kernel output, regulator_get_optional returns -ENODEV if the supply wasn't found. Maybe the API is confusing (or wrong?) here

Re: [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-04-07 Thread Mike Looijmans
On 04/07/2014 02:25 PM, Arnd Bergmann wrote: On Monday 07 April 2014 13:18:54 Ben Dooks wrote: On 07/04/14 13:16, Ben Dooks wrote: On 07/04/14 13:09, Mike Looijmans wrote: On 04/07/2014 10:11 AM, Arnd Bergmann wrote: On Monday 07 April 2014 08:38:28 Mike Looijmans wrote: index 34aef81

Re: [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-04-07 Thread Mike Looijmans
On 04/07/2014 10:11 AM, Arnd Bergmann wrote: On Monday 07 April 2014 08:38:28 Mike Looijmans wrote: index 34aef81..43b90c1 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2972,6 +2972,8 @@ int sdhci_add_host(struct sdhci_host *host) host->vq

[PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-04-06 Thread Mike Looijmans
that has an I2C regulator for one of the sdhcis and no regulators at all for the other. This patch enables such a system to work correctly. v2: Do not change logging output Signed-off-by: Mike Looijmans --- drivers/mmc/host/sdhci.c |4 1 file changed, 4 insertions(+) diff --git a

[PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-04-06 Thread Mike Looijmans
that has an I2C regulator for one of the sdhcis and no regulators at all for the other. This patch enables such a system to work correctly. Signed-off-by: Mike Looijmans --- drivers/mmc/host/sdhci.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host

[PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-03-28 Thread Mike Looijmans
If vmmc or vqmmc regulators are controlled by an I2C device, the request for the regulator is likely to fail because the I2C bus has not been probed yet. The sdhci then incorrectly assumes that the user never wanted to use a regulator anyway and continues without ever enabling or configuring the re

Re: [PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-03-27 Thread Mike Looijmans
On 26-3-2014 16:09, Georgi Djakov wrote: On 03/07/2014 04:18 PM, Mike Looijmans wrote: If vmmc or vqmmc regulators are controlled by an I2C device, the request for the regulator is likely to fail because the I2C bus has not been probed yet. The sdhci then incorrectly assumes that the user never

Re: [PATCH v2] mmc: sdhci: add quirk for broken write protect detection

2014-03-20 Thread Mike Looijmans
in XPS and/or Vivado that the pinmuxing for the WP line is actually routed to MIO0 when you request it to be unrouted or to EMIO, this made the WP line on our systems appear as semi-random. Mike. On 03/20/2014 01:39 PM, Eli Billauer wrote: Hello Michal. The Zybo board doesn't have any W

[PATCH] sdhci: Forward EPROBE_DEFER on vmmc and vqmmc regulators

2014-03-07 Thread Mike Looijmans
If vmmc or vqmmc regulators are controlled by an I2C device, the request for the regulator is likely to fail because the I2C bus has not been probed yet. The sdhci then incorrectly assumes that the user never wanted to use a regulator anyway and continues without ever enabling or configuring the re

Re: [PATCH v2] mmc: sdhci: add quirk for broken write protect detection

2014-03-06 Thread Mike Looijmans
#x27;t know (and I don't care either) to which logic level the wp happens to think it's wired. I just want to be able to tell the driver that the WP line is free-floating-and-might-have-any-random-value-at-any-given-moment which is a bit long, so I'd go for disable-wp instead.

Re: [PATCH] clk: hisilicon: add hi3620_mmc_clks

2014-02-26 Thread Mike Turquette
gt; Acked-by: Arnd Bergmann > Acked-by: Jaehoon Chung Taken into clk-next (again! This one got lost when migrating my early branch from 3.14-rcX to the new clk-next) Regards, Mike > --- > .../bindings/arm/hisilicon/hisilicon.txt | 14 + > .../devicetree/bindings/clo

[PATCH] sdhci: Add a quirk to disable write-protect

2014-02-23 Thread Mike Looijmans
When a board does not have the WP line wired at all, the card may be detected as read-only. Add a quirk and a device property to disable WP detection. Signed-off-by: Mike Looijmans --- drivers/mmc/host/sdhci-pltfm.c |3 +++ drivers/mmc/host/sdhci.c |3 ++- include/linux/mmc

Re: [PATCHv9 1/4] clk: socfpga: Add a clk-phase property to the "altr, socfpga-gate-clk"

2014-02-05 Thread Mike Turquette
Quoting Dinh Nguyen (2014-01-15 04:36:52) > Hi Mike, > > Can you apply this to your clk tree? The patch looks good to me, but I think it depends on your pending pull request. Can you add this to that pull request and rebase it to 3.14-rc1? Thanks, Mike > > Thanks, > Dinh &g

Re: [PATCH 2/2] mmc: dw_mmc: k3: remove clk_table

2014-01-17 Thread Mike Turquette
in patch #1 through the clk tree but have not yet pushed it out to my public mirror. Chris, I'm happy to take it if you haven't yet. Regards, Mike > > Thanks, > sw-j -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] clk: hisilicon: add hi3620_mmc_clks

2014-01-15 Thread Mike Turquette
Quoting Haojian Zhuang (2014-01-14 21:59:40) > > On 01/15/2014 11:53 AM, Mike Turquette wrote: > > Quoting zhangfei (2014-01-14 17:40:25) > >> Dear Mike > >> > >> On 01/15/2014 04:17 AM, Mike Turquette wrote: > >>> Quoting Zhangfei Gao (2014-0

Re: [PATCH 1/2] clk: hisilicon: add hi3620_mmc_clks

2014-01-14 Thread Mike Turquette
Quoting zhangfei (2014-01-14 17:40:25) > Dear Mike > > On 01/15/2014 04:17 AM, Mike Turquette wrote: > > Quoting Zhangfei Gao (2014-01-13 01:14:28) > >> Suggest by Arnd: abstract mmc tuning as clock behavior, > >> also because different soc have diff

Re: [PATCH 1/2] clk: hisilicon: add hi3620_mmc_clks

2014-01-14 Thread Mike Turquette
gt; Acked-by: Arnd Bergmann > Acked-by: Jaehoon Chung Patch looks good to me with one exception. I do not have Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt in the clk-next branch. Is there a stable branch I can pull in as a dependency? Thanks, Mike > --- > .../bindings/

Re: [RESEND LIST PATCHv7 1/4] clk: socfpga: Add a clk-phase property to the "altr, socfpga-gate-clk"

2013-12-18 Thread Mike Turquette
king at this again, I have a hard time understanding the values in the clk-phase property. You reference some functions in the property definition above, but they are not obvious to me. Additionally I wonder if the binding would better if the clock-phase property was simply the value in degrees. E.g:

Re: [PATCHv6 2/5] clk: socfpga: Add a clock type for the SD/MMC driver

2013-12-18 Thread Mike Turquette
). 2) what is the input parameter to clk_set_phase? I guess the two best options are degrees (zero to 359), or a fraction of the clock period (1/4, 1/2, etc). Any thoughts? Regards, Mike > > > I also saw a similar requirement from the gmac people (on cc too), who > > needed to

Re: [RESEND LIST PATCHv7 1/4] clk: socfpga: Add a clk-phase property to the "altr, socfpga-gate-clk"

2013-12-17 Thread Mike Turquette
hs_timing); > >> +} > >> +return 0; > >> +} > > > > So reusing gate-clk here and check the node of "altr,sys-mgr". > > I think it is good and simple. > > Also can define new clock combined with no

Re: [PATCHv6 2/5] clk: socfpga: Add a clock type for the SD/MMC driver

2013-12-14 Thread Mike Turquette
MMC driver passes this clock phase information into the clock driver to > >> use. > >> > >> This enables the SD/MMC driver to touch registers that are located outside > >> of > >> the SD/MMC IP, which helps make the core SD/MMC driver generic. > >

[PATCH [mmc-utils] 2/2] start a README

2013-12-12 Thread Mike Frysinger
Signed-off-by: Mike Frysinger --- README | 12 1 file changed, 12 insertions(+) create mode 100644 README diff --git a/README b/README new file mode 100644 index 000..e7d5210 --- /dev/null +++ b/README @@ -0,0 +1,12 @@ +Userspace tools for MMC/SD devices + +Useful for doing

[PATCH [mmc-utils] 1/2] fix make handling

2013-12-12 Thread Mike Frysinger
From: Mike Frysinger Fix the recurisve make targets by using $(MAKE). Otherwise we get lots of warnings and issues with parallel builds. Fix the install target -- the man subdir was missing a dummy target. Add proper .PHONY markings. Signed-off-by: Mike Frysinger --- Makefile | 8

Re: [PATCH v3 5/7] clk: add basic Rockchip rk3066a clock support

2013-06-11 Thread Mike Turquette
t; + > + for (i = 0; i < qty; i++) { > + of_property_read_string_index(node, "clock-output-names", > + i, &clk_name); > + > + /* ignore empty slots */ > + if

Re: [PATCH v3 1/7] clk: divider: add flag to limit possible dividers to even numbers

2013-06-11 Thread Mike Turquette
f CLK_DIVIDER_ONE_BASED? Maybe something like this would be more correct: if (divider->flags & CLK_DIVIDER_EVEN && (div % 2) != 0) { if (divider->flags & CLK_DIVIDER_ONE_BASED && div == 1) return true; retu

Re: process hangs on do_exit when oom happens

2012-10-26 Thread Mike Galbraith
On Fri, 2012-10-26 at 10:03 -0700, Mike Galbraith wrote: > The bug is in the patch that used sched_setscheduler_nocheck(). Plain > sched_setscheduler() would have replied -EGOAWAY. sched_setscheduler_nocheck() should say go away too methinks. This isn't about permissions, it's

Re: process hangs on do_exit when oom happens

2012-10-26 Thread Mike Galbraith
le warm fuzzy, so a complete runtime RT_GROUP_SCHED on/off switch with default to off, ie rt tasks cannot be moved until switched on would fix some annoying "Oopsie, I forgot" allocation troubles. If you turn it on, shame on you if you fail to allocate, you asked for it, you're not just stuck with it because your distro enabled it in their config. Or, perhaps just make zero rt_runtime always mean traverse up to first non-zero rt_runtime, ie zero allocation children may consume parental runtime as they see fit on first come first served basis, when it's gone, tough, parent/children all wait for refill. Or whatever, as long as you don't bust distribution/tracking for those crazy people who intentionally use RT_GROUP_SCHED ;-) The bug is in the patch that used sched_setscheduler_nocheck(). Plain sched_setscheduler() would have replied -EGOAWAY. -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Tracking down suspend/resume ext3/mmc issues on imx233

2012-09-08 Thread Mike Thompson
ug an issue that is probably already dealt with. Mike On Thu, Sep 6, 2012 at 11:05 PM, Shawn Guo wrote: > Copy a few more lists to get wider audience ... > > Regards, > Shawn > > On Thu, Sep 06, 2012 at 10:03:35PM -0700, Mike Thompson wrote: >> I'm working on addin

Re: [PATCH 3/4] mmc: Logging neatening

2011-11-16 Thread Mike Frysinger
think that tab is needed this "DW MMC controller at irq " ? looks to me like this was the only part you replied to. could you please snip the unrelated context in the future ? no reason to include ~1700 lines of context when you only replying to like ~10 lines. -mike signature.asc Description: This is a digitally signed message part.

[PATCH] mmc: bfin_sdh: fix alloc size for private data

2011-01-11 Thread Mike Frysinger
From: Sonic Zhang The bfin_sdh driver allocates the wrong size for the private data in the mmc_host. The first parameter of mmc_alloc_host should be the size of the local driver struct rather than the common mmc_host. Signed-off-by: Sonic Zhang Signed-off-by: Mike Frysinger --- drivers/mmc

Re: [PATCH 3/3] mmc: add sdhci-tegra driver for Tegra SoCs

2010-12-22 Thread Mike Rapoport
gt; Signed-off-by: Olof Johansson > Cc: Wolfram Sang > Cc: Mike Rapoport Only one comment below, otherwise feel free to add Acked-by: Mike Rapoport > --- > > arch/arm/mach-tegra/include/mach/sdhci.h | 28 > drivers/mmc/host/Kconfig | 10 ++ > driv

Re: [PATCH 4/4] mmc: add sdhci-tegra driver for Tegra SoCs

2010-12-15 Thread Mike Rapoport
pend_host(host->sdhci, state); > + if (ret) > + pr_err("%s: failed, error = %d\n", __func__, ret); > + > + return ret; > +} > + > +static int tegra_sdhci_resume(struct platform_device *pdev) > +{ > + struct tegra_sdhci_host *host = platform_get_drvdata(pdev); > + int ret; > + > + ret = sdhci_resume_host(host->sdhci); > + if (ret) > + pr_err("%s: failed, error = %d\n", __func__, ret); > + > + return ret; > +} > +#else > +#define tegra_sdhci_suspendNULL > +#define tegra_sdhci_resume NULL > +#endif > + > +static struct platform_driver tegra_sdhci_driver = { > + .probe = tegra_sdhci_probe, > + .remove = tegra_sdhci_remove, > + .suspend = tegra_sdhci_suspend, > + .resume = tegra_sdhci_resume, > + .driver = { > + .name = DRIVER_NAME, > + .owner = THIS_MODULE, > + }, > +}; > + > +static int __init tegra_sdhci_init(void) > +{ > + return platform_driver_register(&tegra_sdhci_driver); > +} > + > +static void __exit tegra_sdhci_exit(void) > +{ > + platform_driver_unregister(&tegra_sdhci_driver); > +} > + > +module_init(tegra_sdhci_init); > +module_exit(tegra_sdhci_exit); > + > +MODULE_DESCRIPTION("Tegra SDHCI controller driver"); > +MODULE_LICENSE("GPL"); -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: MMC runtime PM patches break libertas probe

2010-11-16 Thread Mike Rapoport
r savings, though. > I'm looping in libertas-dev. > > Thanks, > Ohad. > > ___ > libertas-dev mailing list > libertas-...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/libertas-dev -- Sincerely

[PATCH v4 1/2] MMC: add support for the Marvell Dove SDHCI controller

2010-10-28 Thread Mike Rapoport
Implement an sdhci-pltfm driver for the controller found on Marvell Dove SoC Signed-off-by: Mike Rapoport CC: Saeed Bishara --- drivers/mmc/host/Kconfig | 13 +++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-dove.c | 70

[PATCH v4 2/2] [ARM] Dove: rename SDHCI devices to "sdhci-dove"

2010-10-28 Thread Mike Rapoport
Signed-off-by: Mike Rapoport CC: Saeed Bishara --- arch/arm/mach-dove/common.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c index f7a1258..fe627ab 100644 --- a/arch/arm/mach-dove/common.c +++ b/arch/arm

[PATCH v4 0/2] add support for the Marvell Dove SDHCI controller

2010-10-28 Thread Mike Rapoport
respectively * add dependancy on ARCH_DOVE * remove unneeded includes from the driver Mike Rapoport (2): MMC: add support for the Marvell Dove SDHCI controller [ARM] Dove: rename SDHCI devices to "sdhci-dove" arch/arm/mach-dove/common.c|4 +- drivers/mmc/host/Kconfig

[PATCH v3 2/2] [ARM] Dove: rename SDCHI devices to "sdhci-dove"

2010-10-28 Thread Mike Rapoport
Signed-off-by: Mike Rapoport CC: Saeed Bishara --- arch/arm/mach-dove/common.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c index f7a1258..fe627ab 100644 --- a/arch/arm/mach-dove/common.c +++ b/arch/arm

[PATCH v3 1/2] MMC: add support for the Marvell Dove SDHCI controller

2010-10-28 Thread Mike Rapoport
Implement an sdhci-pltfm driver for the controller found on Marvell Dove SoC Signed-off-by: Mike Rapoport CC: Saeed Bishara --- drivers/mmc/host/Kconfig | 13 +++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-dove.c | 70

[PATCH v3 0/2] add support for the Marvell Dove SDHCI controller

2010-10-28 Thread Mike Rapoport
unneeded includes from the driver Mike Rapoport (2): MMC: add support for the Marvell Dove SDHCI controller [ARM] Dove: rename SDCHI devices to "sdhci-dove" arch/arm/mach-dove/common.c|4 +- drivers/mmc/host/Kconfig | 13 +++ drivers/mmc/host/Makefile |1

Re: [PATCH v2 1/2] MMC: add support for the Marvell Dove SDHCI controller

2010-10-27 Thread Mike Rapoport
On 10/27/10 13:56, Chris Ball wrote: > Hi Mike, adding Wolfram to CC in case he has comments, > > On Wed, Oct 27, 2010 at 01:21:58PM +0200, Mike Rapoport wrote: >> > > Let's add a little text here -- something like "Implement an sdhci-pltfm > driver for the co

[PATCH v2 0/2] add support for the Marvell Dove SDHCI controller

2010-10-27 Thread Mike Rapoport
These patches add support for the Marvell Dove SDHCI controller. v2 changes: * rename drivers/mmc/host/sdhci-mv.c to drivers/mmc/host/sdhci-dove.c and update Kconfig and Makefile respectively * add dependancy on ARCH_DOVE * remove unneeded includes from the driver Mike Rapoport (2): MMC: add

[PATCH v2 1/2] MMC: add support for the Marvell Dove SDHCI controller

2010-10-27 Thread Mike Rapoport
Signed-off-by: Mike Rapoport CC: Saeed Bishara --- drivers/mmc/host/Kconfig | 13 +++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-dove.c | 72 drivers/mmc/host/sdhci-pltfm.c |3 ++ drivers/mmc/host/sdhci-pltfm.h

[PATCH v2 2/2] [ARM] Dove: rename SDCHI devices to "sdhci-dove"

2010-10-27 Thread Mike Rapoport
Signed-off-by: Mike Rapoport CC: Saeed Bishara --- arch/arm/mach-dove/common.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-dove/common.c b/arch/arm/mach-dove/common.c index f7a1258..fe627ab 100644 --- a/arch/arm/mach-dove/common.c +++ b/arch/arm

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-10-27 Thread Mike Rapoport
>> + This selects the Secure Digital Host Controller Interface in >> + Marvell's SoC controllers. >> + >> + If you have a controller with this interface, say Y or M here. >> + >> + If unsure, say N. >> + > Mike, the config name and

[PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-10-27 Thread Mike Rapoport
Signed-off-by: Mike Rapoport CC: Saeed Bishara --- drivers/mmc/host/Kconfig | 13 +++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-mv.c| 77 drivers/mmc/host/sdhci-pltfm.c |3 ++ drivers/mmc/host/sdhci-pltfm.h

Re: [PATCH] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI.

2010-10-16 Thread Mike Frysinger
On Sat, Oct 16, 2010 at 19:01, Chris Ball wrote: > On Sat, Oct 16, 2010 at 05:19:36PM -0400, Mike Frysinger wrote: >> Andrew: we posted this months ago with no feedback ... could you pick it up ? > > Sorry, my fault for missing this -- I've pushed it to mmc-next now, > with

[PATCH] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI.

2010-10-16 Thread Mike Frysinger
. The retry count is set to 5 to ensure the driver pass any stress test. Signed-off-by: Sonic Zhang [cjb: fixed merge conflict against current Linus] Signed-off-by: Chris Ball Signed-off-by: Mike Frysinger --- Andrew: we posted this months ago with no feedback ... could you pick it up ? drivers

Re: [PATCH 0/2] mmc: omap_hsmmc: support SDIO cards (#2)

2010-10-09 Thread Mike Rapoport
Hi Madhu, Madhusudhan wrote: -Original Message- From: Steve Sakoman [mailto:sako...@gmail.com] Sent: Thursday, October 07, 2010 8:57 AM To: Mike Rapoport Cc: Madhusudhan Chikkature; David Vrabel; Chris Ball; linux- m...@vger.kernel.org; linux-o...@vger.kernel.org; Adrian Hunter

Re: [PATCH 0/2] mmc: omap_hsmmc: support SDIO cards (#2)

2010-10-07 Thread Mike Rapoport
work from exactly the same patch! Steve Yes. I think that check breaking the compilation is not needed. How about the below version? It just removes that check. This version should apply fine on the latest kernel. I did a sanity test of MMC/SD cards on OMAP4 SDP. Steve or Mike can check if SDIO

Re: [PATCH 0/2] mmc: omap_hsmmc: support SDIO cards (#2)

2010-10-06 Thread Mike Rapoport
Hi Steve, Steve Sakoman wrote: On Tue, Oct 5, 2010 at 11:17 PM, Mike Rapoport wrote: I've tried to update the patches on top of 2.6.36-rc3 and I've got stuck. The changes Adrian has made to the interrupt synchronization affect the way the SDIO irq should be implemented and I haven

Re: [PATCH 0/2] mmc: omap_hsmmc: support SDIO cards (#2)

2010-10-05 Thread Mike Rapoport
Steve Sakoman wrote: On Mon, Oct 4, 2010 at 10:33 AM, Madhusudhan wrote: -Original Message- From: Steve Sakoman [mailto:sako...@gmail.com] Sent: Monday, October 04, 2010 11:57 AM To: Madhusudhan Cc: Mike Rapoport; David Vrabel; Chris Ball; linux-mmc@vger.kernel.org; linux-o

Re: [Bugme-new] [Bug 18602] New: mmc_block / tifm_sd not completely registering when a new sd card is inserted

2010-09-20 Thread Mike Kelly
SD cards in this reader. The fact that I am occasionally able to get this reader to work under Linux, though does make it seem like some timing or race issue that I'm hitting, though. I may give SDHCI a go at some point, but I'll have to read up on it more. -- Mike Kelly signature.asc Description: PGP signature

Re: [Bugme-new] [Bug 18602] New: mmc_block / tifm_sd not completely registering when a new sd card is inserted

2010-09-19 Thread Mike Kelly
ing output. But, no /dev/mmcblk0 shows up, and mmc_block does not get loaded. -- Mike Kelly signature.asc Description: PGP signature

Re: [Bugme-new] [Bug 18602] New: mmc_block / tifm_sd not completely registering when a new sd card is inserted

2010-09-18 Thread Mike Kelly
t; DEBUG enabled and posting the trace may help to diagnose the problem. Log is attached. It seems that this time, no entry shows up in /dev at all, even if I modprobe mmc_block manually. -- Mike Kelly Sep 18 04:56:54 aether kernel: [ 459.091171] tifm_core: MMC/SD card detected in socket 0:1 Sep

Re: [PATCH 0/2] mmc: omap_hsmmc: support SDIO cards (#2)

2010-09-01 Thread Mike Rapoport
like this patchset wasn't merged. Mike Rapoport replied with a fix for libertas. Would you like to resubmit it? I thought Madhu had picked this up and was going to submit it. Regardless of whether that is the case, I think it needs to be submitted by someone who can run mainline kernels (I can

Re: [PATCH 0/2] mmc: omap_hsmmc: support SDIO cards (#2)

2010-09-01 Thread mike
the FIXME commit on disabling FCLK to better match what really > >> going on (at least I think so anyway). > >> > >> David Vrabel (2): > >> mmc: omap_hsmmc: don't turn SDIO cards off when idle > >> mmc: omap_hsmmc: enable SDIO card interrupts >

Re: [PATCH v2] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI.

2010-07-16 Thread Mike Frysinger
On Fri, Jul 16, 2010 at 06:51, Sonic Zhang wrote: > Any comments? might want to CC akpm so he'll pick this up in case the mmc guys miss it -mike -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More

Re: [Uclinux-dist-devel] [PATCH] MMC:mmc_spi: Recover from CRC error for SD read/write operation over SPI.

2010-07-09 Thread Mike Frysinger
On Fri, Jul 9, 2010 at 04:03, sonic zhang wrote: > SPI bus is not reliable on all platforms when doing large dada transfer. dada -> data > occational CRC error is reported by SD device. This patch makes the occational -> occasional -mike -- To unsubscribe from this list: s

Re: [PATCH 0/2] mmc: omap_hsmmc: support SDIO cards (#2)

2010-02-24 Thread Mike Rapoport
le mmc: omap_hsmmc: enable SDIO card interrupts drivers/mmc/host/omap_hsmmc.c | 114 - 1 files changed, 79 insertions(+), 35 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majo

Re: [PATCH 0/3] mmc: omap_hsmmc: support SDIO cards

2010-02-20 Thread Mike Rapoport
ems to work now, at least with SD card and libertas_sdio: Mike, As per the latest discussion, David replied that this patch is not needed and FRAME sync just works fine. So, without this patch does SDIO int functionality work for you? I had no luck with David's patches for SDIO IRQ, however

Re: [PATCH 0/3] mmc: omap_hsmmc: support SDIO cards

2010-02-17 Thread Mike Rapoport
David Vrabel wrote: > Mike Rapoport wrote: >> Hi David, >> >> David Vrabel wrote: >>> These patches add support for SDIO cards to the omap_hsmmc driver. Less >>> restrictions on the sizes of transfers, power management changes to >>> prevent SDIO

Re: [PATCH 0/3] mmc: omap_hsmmc: support SDIO cards

2010-02-17 Thread Mike Rapoport
Mike Rapoport wrote: > David Vrabel wrote: >> Mike Rapoport wrote: >>> I've started to apply the patches one by one and after the first patch >>> is applied, the SD card works Ok, but libertas fails to initialize with >>> the following messages: >>

Re: [PATCH 0/3] mmc: omap_hsmmc: support SDIO cards

2010-02-11 Thread Mike Rapoport
David Vrabel wrote: > Mike Rapoport wrote: >> I've started to apply the patches one by one and after the first patch >> is applied, the SD card works Ok, but libertas fails to initialize with >> the following messages: >> >>> modprobe libertas_sdio >&g

Re: [PATCH 0/3] mmc: omap_hsmmc: support SDIO cards

2010-02-11 Thread Mike Rapoport
David Vrabel wrote: > Mike Rapoport wrote: >> Hi David, >> >> David Vrabel wrote: >>> These patches add support for SDIO cards to the omap_hsmmc driver. Less >>> restrictions on the sizes of transfers, power management changes to >>> prevent SDIO

Re: [PATCH 0/3] mmc: omap_hsmmc: support SDIO cards

2010-02-11 Thread Mike Rapoport
enable SDIO card interrupts > > drivers/mmc/host/omap_hsmmc.c | 123 > ++--- > 1 files changed, 78 insertions(+), 45 deletions(-) > -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] OMAP35xx:SDIO IRQ Support for OMAP35xx

2010-01-20 Thread Mike Rapoport
Hi Dirk, Dirk Behme wrote: > On 21.12.2009 17:46, Mike Rapoport wrote: >> Hi, >> >> Phaneendra Kumar Alapati wrote: >>> This patch adds SDIO IRQ support for OMAP35xx. Tested on OMAP3530EVM >>> with Marvell 88W8686 card and below are the observed throug

[PATCH 3/3] mmc: bfin_sdh: set timeout based on actual card data

2010-01-19 Thread Mike Frysinger
From: Cliff Cai The hardcoded value doesn't really work for all cards. Signed-off-by: Cliff Cai Signed-off-by: Mike Frysinger --- drivers/mmc/host/bfin_sdh.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc

[PATCH 2/3] mmc: bfin_sdh: drop redundant MMC depend string

2010-01-19 Thread Mike Frysinger
The host/Kconfig file is only included when MMC is selected. Signed-off-by: Mike Frysinger --- drivers/mmc/host/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index ce1d288..f6af92a 100644 --- a/drivers/mmc

[PATCH 1/3] mmc: bfin_sdh: fix unused sg warning on BF51x/BF52x systems

2010-01-19 Thread Mike Frysinger
The local sg variable is only used with BF54x code. Signed-off-by: Mike Frysinger --- drivers/mmc/host/bfin_sdh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/mmc/host/bfin_sdh.c b/drivers/mmc/host/bfin_sdh.c index 3343a57..f218a99 100644 --- a/drivers/mmc

Re: [PATCH] OMAP35xx:SDIO IRQ Support for OMAP35xx

2009-12-21 Thread Mike Rapoport
ioremap(host->mapbase, SZ_4K); > host->power_mode = -1; > + host->sdio_int = 0; > > platform_set_drvdata(pdev, host); > INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect); > @@ -1744,6 +1783,10 @@ static int __init omap_hsmmc_probe(struct > platform_device *pdev) > if (mmc_slot(host).nonremovable) > mmc->caps |= MMC_CAP_NONREMOVABLE; > > + mmc->caps |= MMC_CAP_SDIO_IRQ; > + OMAP_HSMMC_WRITE(host->base, CON, > + OMAP_HSMMC_READ(host->base, CON) | (CTPL | CLKEXTFREE)); > + > omap_hsmmc_conf_bus_power(host); > > /* Select DMA lines */ -- Sincerely yours, Mike. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver

2009-12-03 Thread Mike Frysinger
>sg_cpu[i].cfg, host->sg_cpu[i].x_count, >                                host->sg_cpu[i].x_modify); >        } this change also has an error in it ... the new opening brace brace stole the closing brace from the for_each_sg() -mike

Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver

2009-11-29 Thread Mike Frysinger
On Wed, Nov 25, 2009 at 17:43, Andrew Morton wrote: > On Wed, 25 Nov 2009 17:25:20 -0500 Mike Frysinger wrote: >> > Arguably wrong from a coding-style POV and looks weird IMO. __Adds a bit >> > of risk that subsequent coders will think they're writing in python adn >&g

Re: [PATCH v4][mmc/host]:Blackfin SD Host Controller Driver

2009-11-25 Thread Mike Frysinger
nd looks weird IMO.  Adds a bit > of risk that subsequent coders will think they're writing in python adn > will add bugs. i dont really get what you're referring to here. the code in question looks ifne to me, and i dont see anything "python-esque" about it > Fixes:

Re: [PATCH v3][mmc/host]:Blackfin SD Host Controller Driver

2009-11-24 Thread Mike Frysinger
ter. > + */ any reason you dropped '2007-' ? we developed the code back then and certainly have copyright domain over it. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] [mmc/host]:Blackfin SD Host Controller Driver

2009-11-24 Thread Mike Frysinger
On Tue, Nov 24, 2009 at 22:58, Cliff Cai wrote: > On Wed, Nov 25, 2009 at 11:51 AM, Mike Frysinger wrote: >> On Wed, Nov 25, 2009 at 06:25,   wrote: >>> From: Cliff Cai >>> >>> v2-v1 change:remove mmc host before releasing it in sdh_probe

Re: [PATCH v2] [mmc/host]:Blackfin SD Host Controller Driver

2009-11-24 Thread Mike Frysinger
Bryan Wu Signed-off-by: Mike Frysinger -mike -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH][mmc/host]:Blackfin SD Host Controller Driver

2009-11-24 Thread Mike Frysinger
On Tue, Nov 24, 2009 at 10:39, wrote: > From: Cliff Cai > > Signed-off-by: Cliff Cai you dropped some people's s-o-b tags > +out4: > +       free_irq(host->irq, host); you didnt address the feedback given last time here: You need a mmc_remove_host() here. -mike

mmc-spi on pxa2xx, flipping sph bit

2009-11-09 Thread Mike Borsuk
Hello, I am working on getting mmc_spi to work with a an ARM PXA270 on 2.6.31 I am able to successfully mount the fs on a Transcend mini-sd card (though some i/o errors are reported during init sequence), but some cards such as SanDisk Ultra II MiniSD 2GB fail to initialize. The card is identified