Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-05-13 Thread Tony Lindgren
* Andrew Morton [100513 12:36]: > On Thu, 13 May 2010 12:29:35 -0700 > Tony Lindgren wrote: > > > * Cory Maccarrone [100307 09:44]: > > > From: Marek Belisko > > > > > > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > > > a modification of the register addresses in

Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-05-13 Thread Andrew Morton
On Thu, 13 May 2010 12:29:35 -0700 Tony Lindgren wrote: > * Cory Maccarrone [100307 09:44]: > > From: Marek Belisko > > > > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > > a modification of the register addresses in the mmc-omap driver. To resolve > > this, a bit

Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-05-13 Thread Tony Lindgren
Hi Andrew, * Cory Maccarrone [100307 09:44]: > From: Marek Belisko > > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > a modification of the register addresses in the mmc-omap driver. To resolve > this, a bit shift is performed on base register addresses, either by

Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-03-08 Thread Ben Dooks
On Sun, Mar 07, 2010 at 10:59:01PM +, Ben Dooks wrote: > On Sun, Mar 07, 2010 at 09:47:58AM -0800, Cory Maccarrone wrote: > > From: Marek Belisko > > > > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > > a modification of the register addresses in the mmc-omap driv

Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-03-07 Thread Cory Maccarrone
On Sun, Mar 7, 2010 at 2:59 PM, Ben Dooks wrote: > On Sun, Mar 07, 2010 at 09:47:58AM -0800, Cory Maccarrone wrote: >> From: Marek Belisko >> >> The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring >> a modification of the register addresses in the mmc-omap driver.  To resolv

Re: [PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-03-07 Thread Ben Dooks
On Sun, Mar 07, 2010 at 09:47:58AM -0800, Cory Maccarrone wrote: > From: Marek Belisko > > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > a modification of the register addresses in the mmc-omap driver. To resolve > this, a bit shift is performed on base register add

[PATCH] mmc-omap: Add support for 16-bit and 32-bit registers

2010-03-07 Thread Cory Maccarrone
From: Marek Belisko The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring a modification of the register addresses in the mmc-omap driver. To resolve this, a bit shift is performed on base register addresses, either by 1 or 2 bits depending on the CPU in use. This yields the

Re: [PATCH] [mmc-omap] Add support for 16-bit and 32-bit registers

2009-11-18 Thread Ladislav Michl
On Wed, Nov 18, 2009 at 01:09:22PM -0800, Cory Maccarrone wrote: > On Wed, Nov 18, 2009 at 10:41 AM, Ladislav Michl > wrote: > > Did you test it? It does not work on 5910, see here: > > http://thread.gmane.org/gmane.linux.kernel.mmc/649 > > Not sure why it wouldn't work on the 5910. I tested it

Re: [PATCH] [mmc-omap] Add support for 16-bit and 32-bit registers

2009-11-18 Thread Cory Maccarrone
On Wed, Nov 18, 2009 at 10:41 AM, Ladislav Michl wrote: > On Sat, Nov 14, 2009 at 07:24:55PM -0800, Cory Maccarrone wrote: >> The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring >> a modification of the register addresses in the mmc-omap driver.  To >> make this as portable a

Re: [PATCH] [mmc-omap] Add support for 16-bit and 32-bit registers

2009-11-18 Thread Ladislav Michl
On Sat, Nov 14, 2009 at 07:24:55PM -0800, Cory Maccarrone wrote: > The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring > a modification of the register addresses in the mmc-omap driver. To > make this as portable as possible, I made the following changes: Hmm, I would not tr

[PATCH] [mmc-omap] Add support for 16-bit and 32-bit registers

2009-11-14 Thread Cory Maccarrone
The omap850 and omap730 use 16-bit registers instead of 32-bit, requiring a modification of the register addresses in the mmc-omap driver. To make this as portable as possible, I made the following changes: * Moved register address offsets from drivers/mmc/host/omap.c to drivers/mmc/host/omap.h