Re: [PATCH] MMC: OMAP HS-MMC: convert to dev_pm_ops

2010-05-18 Thread Kevin Hilman
Matt Fleming writes: > On Fri, May 14, 2010 at 09:51:21AM -0700, Kevin Hilman wrote: >> >> I don't see a reason either, but it requires patching the MMC core as >> well as all the users. As I'm not an MMC core person, I thought this >> best left to someone in that domain. >> >> Fixing the core

Re: [PATCH] MMC: OMAP HS-MMC: convert to dev_pm_ops

2010-05-14 Thread Matt Fleming
On Fri, May 14, 2010 at 09:51:21AM -0700, Kevin Hilman wrote: > > I don't see a reason either, but it requires patching the MMC core as > well as all the users. As I'm not an MMC core person, I thought this > best left to someone in that domain. > > Fixing the core and callers could easily be do

Re: [PATCH] MMC: OMAP HS-MMC: convert to dev_pm_ops

2010-05-14 Thread Kevin Hilman
Matt Fleming writes: > On Tue, 11 May 2010 14:57:16 -0700, Kevin Hilman > wrote: >> >> Note that dev_pm_ops version of the suspend hook no longer takes a >> 'state' argument. However, the MMC core function mmc_suspend_host() >> still takes a 'state' argument, but it is unused, so a dummy >> s

Re: [PATCH] MMC: OMAP HS-MMC: convert to dev_pm_ops

2010-05-13 Thread Matt Fleming
On Tue, 11 May 2010 14:57:16 -0700, Kevin Hilman wrote: > > Note that dev_pm_ops version of the suspend hook no longer takes a > 'state' argument. However, the MMC core function mmc_suspend_host() > still takes a 'state' argument, but it is unused, so a dummy > state variable was created to pas

[PATCH] MMC: OMAP HS-MMC: convert to dev_pm_ops

2010-05-11 Thread Kevin Hilman
Convert PM operations to use dev_pm_ops. This will facilitate the runtime PM coversion which will add to dev_pm_ops hooks. Note that dev_pm_ops version of the suspend hook no longer takes a 'state' argument. However, the MMC core function mmc_suspend_host() still takes a 'state' argument, but it