Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-10-27 Thread Mike Rapoport
On 10/27/10 10:46, Saeed Bishara wrote: > > >> +config MMC_SDHCI_MV >> +bool "SDHCI support on Marvell's SoC" >> +depends on MMC_SDHCI >> +depends on MMC_SDHCI_PLTFM >> +select MMC_SDHCI_IO_ACCESSORS >> +help >> + This selects the Secure Digital Host Controller Interfac

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-10-27 Thread Chris Ball
Hi Mike, I concur with Saeed, and please also fold this patch into the submission: http://marc.info/?l=linux-kernel&m=128458441031769&q=raw Thanks! -- Chris Ball One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the bod

RE: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-10-27 Thread Saeed Bishara
>+config MMC_SDHCI_MV >+ bool "SDHCI support on Marvell's SoC" >+ depends on MMC_SDHCI >+ depends on MMC_SDHCI_PLTFM >+ select MMC_SDHCI_IO_ACCESSORS >+ help >+This selects the Secure Digital Host Controller Interface in >+Marvell's SoC controllers. >+ >

[PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-10-27 Thread Mike Rapoport
Signed-off-by: Mike Rapoport CC: Saeed Bishara --- drivers/mmc/host/Kconfig | 13 +++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-mv.c| 77 drivers/mmc/host/sdhci-pltfm.c |3 ++ drivers/mmc/host/sdhci-pltfm.h |

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-09-10 Thread Chris Ball
Hi Saeed, On Tue, Jun 22, 2010 at 05:09:02PM +0300, Saeed Bishara wrote: > This patch implements the driver for the platfrom SDHCI controllers > that found on some of Marvell's SoC's. Applied to mmc-next with some minor language fixes, thanks. -- Chris Ball One Laptop

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-08-25 Thread Andrew Morton
On Wed, 25 Aug 2010 23:39:58 +0100 Matt Fleming wrote: > On Tue, 22 Jun 2010 17:09:02 +0300 > Saeed Bishara wrote: > > > This patch implements the driver for the platfrom SDHCI controllers that > > found on some of Marvell's SoC's. > > > > Signed-off-by: Saeed Bishara > > --- > > drivers/mm

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-08-25 Thread Matt Fleming
On Tue, 22 Jun 2010 17:09:02 +0300 Saeed Bishara wrote: > This patch implements the driver for the platfrom SDHCI controllers that > found on some of Marvell's SoC's. > > Signed-off-by: Saeed Bishara > --- > drivers/mmc/host/Kconfig| 12 ++ > drivers/mmc/host/Makefile |1 + > driv

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-06-23 Thread Matt Fleming
On Wed, 23 Jun 2010 15:11:04 +0300, saeed bishara wrote: > the point behind the devm_ (device managed) resouce allocation is not > to do the free explicitly, the kernel does that on behalf of the > driver. Oops, sorry I missed that. I must have been hungry, it was near lunchtime. -- To unsubscri

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-06-23 Thread saeed bishara
On Wed, Jun 23, 2010 at 2:52 PM, Matt Fleming wrote: > On Tue, 22 Jun 2010 17:09:02 +0300, Saeed Bishara wrote: >> This patch implements the driver for the platfrom SDHCI controllers that >> found on some of Marvell's SoC's. >> >> Signed-off-by: Saeed Bishara > > That's a nice, small driver ;-)

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-06-23 Thread Matt Fleming
On Tue, 22 Jun 2010 17:09:02 +0300, Saeed Bishara wrote: > This patch implements the driver for the platfrom SDHCI controllers that > found on some of Marvell's SoC's. > > Signed-off-by: Saeed Bishara That's a nice, small driver ;-) [...] > + > + if (!devm_request_mem_region(&pdev->dev,

[PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-06-22 Thread Saeed Bishara
This patch implements the driver for the platfrom SDHCI controllers that found on some of Marvell's SoC's. Signed-off-by: Saeed Bishara --- drivers/mmc/host/Kconfig| 12 ++ drivers/mmc/host/Makefile |1 + drivers/mmc/host/sdhci-mv.c | 243 +++

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-05-25 Thread saeed bishara
guys, any comments for the attached patch? saeed 0001-MMC-add-support-for-the-Marvell-platform-SDHCI-cont.patch Description: Binary data

Re: [PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-05-05 Thread saeed bishara
Attached v2 of the patch. changes: 1. added missing files (Makefile and Kconfig) 2. added the force dma quirk 3. removed special treatment for DATA register used fro pio mode please review saeed On Tue, May 4, 2010 at 7:24 PM, Saeed Bishara wrote: > This patch implements the driver for the platf

[PATCH] MMC: add support for the Marvell platform SDHCI controller

2010-05-04 Thread Saeed Bishara
This patch implements the driver for the platfrom SDHCI controllers that found on some of Marvell's SoC's. Signed-off-by: Saeed Bishara --- drivers/mmc/host/sdhci-mv.c | 266 +++ 1 files changed, 266 insertions(+), 0 deletions(-) create mode 100644 driv