Re: [PATCH] MMC: move regulator handling closer to core v2

2010-09-05 Thread Linus Walleij
2010/9/4 Adrian Hunter : > One of our contractors had a look at the patch and had this comment: > > One comment/question: > /host/mmci.c in function > "static int __devexit mmci_remove(struct amba_device *dev)" there is code: >        if (regulator_is_enabled(host->vcc)) >            regulator_dis

Re: [PATCH] MMC: move regulator handling closer to core v2

2010-09-05 Thread Mark Brown
On Fri, Sep 03, 2010 at 09:38:45PM +0200, Linus Walleij wrote: > This has an Reveiwed-by from the regulator maintainer and > seems to address all comments, noone is objection so Andrew > can you pick it up? Just to clarify, I'm only one of the regulator maintainers - Liam also maintains the regul

Re: [PATCH] MMC: move regulator handling closer to core v2

2010-09-03 Thread Adrian Hunter
Linus Walleij wrote: 2010/8/31 Linus Walleij : After discovering a problem in regulator reference counting I took Mark Brown's advice to move the reference count into the MMC core by making the regulator status a member of struct mmc_host. This has an Reveiwed-by from the regulator maintainer

Re: [PATCH] MMC: move regulator handling closer to core v2

2010-09-03 Thread Linus Walleij
2010/8/31 Linus Walleij : > After discovering a problem in regulator reference counting I > took Mark Brown's advice to move the reference count into the > MMC core by making the regulator status a member of > struct mmc_host. This has an Reveiwed-by from the regulator maintainer and seems to add

[PATCH] MMC: move regulator handling closer to core v2

2010-08-31 Thread Linus Walleij
After discovering a problem in regulator reference counting I took Mark Brown's advice to move the reference count into the MMC core by making the regulator status a member of struct mmc_host. I took this opportunity to also implement NULL versions of the regulator functions so as to rid the drive