Re: [PATCH] MMC: tmio: fix a recent regression: restore .set_ios(MMC_POWER_UP) handling

2011-04-22 Thread Paul Parsons
--- On Fri, 22/4/11, Paul Parsons wrote: > As far as I can see the expression > > (ios->clock == 0 && ios->power_mode == > MMC_POWER_ON) > > will only be true if host->f_init == 0 at the time > MMC_POWER_ON is invoked in mmc_power_up(). Presumably that > case is intentional. Sorry, ignore this;

Re: [PATCH] MMC: tmio: fix a recent regression: restore .set_ios(MMC_POWER_UP) handling

2011-04-21 Thread Paul Parsons
Yes, Guennadi's patch fixes my problem. As far as I can see the expression (ios->clock == 0 && ios->power_mode == MMC_POWER_ON) will only be true if host->f_init == 0 at the time MMC_POWER_ON is invoked in mmc_power_up(). Presumably that case is intentional. --- On Thu, 21/4/11, Chris Ball wr

Re: [PATCH] MMC: tmio: fix a recent regression: restore .set_ios(MMC_POWER_UP) handling

2011-04-21 Thread Chris Ball
Hi, On Thu, Apr 21 2011, Guennadi Liakhovetski wrote: > The aggressive clock gating for TMIO MMC patch has broken switching > interface power on, using MFD or platform callbacks. Restore the > ios->power_mode == MMC_POWER_UP && ios->clock == 0 case handling. > > Signed-off-by: Guennadi Liakhovetsk

[PATCH] MMC: tmio: fix a recent regression: restore .set_ios(MMC_POWER_UP) handling

2011-04-21 Thread Guennadi Liakhovetski
The aggressive clock gating for TMIO MMC patch has broken switching interface power on, using MFD or platform callbacks. Restore the ios->power_mode == MMC_POWER_UP && ios->clock == 0 case handling. Signed-off-by: Guennadi Liakhovetski --- This one should go in 2.6.39 drivers/mmc/host/tmio_mmc