Re: [PATCH] dw_mmc: fixed regulator control

2011-05-10 Thread Chris Ball
Hi Jaehoon, On Mon, May 02 2011, Jaehoon Chung wrote: Hi Chris.. Thanks for comments... I think that could confuse that message when didn't set CONFIG_REGULATOR. The message *does not appear* when CONFIG_REGULATOR is unset, because NULL -- which the regulator subsystem returns via the

Re: [PATCH] dw_mmc: fixed regulator control

2011-05-10 Thread Jaehoon Chung
Chris Ball wrote: Hi Jaehoon, On Mon, May 02 2011, Jaehoon Chung wrote: Hi Chris.. Thanks for comments... I think that could confuse that message when didn't set CONFIG_REGULATOR. The message *does not appear* when CONFIG_REGULATOR is unset, because NULL -- which the regulator

Re: [PATCH] dw_mmc: fixed regulator control

2011-05-02 Thread Jaehoon Chung
Hi Chris.. Thanks for comments... I think that could confuse that message when didn't set CONFIG_REGULATOR. And i wonder how do you think about regulator control in suspend (dw_mmc.c)? @@ -1769,9 +1771,6 @@ static int dw_mci_suspend(struct platform_device *pdev, pm_message_t mesg) int

Re: [PATCH] dw_mmc: fixed regulator control

2011-04-30 Thread Chris Ball
Hi Jaehoon, On Fri, Apr 29 2011, Jaehoon Chung wrote: This patch fixed regulator control in dw_mmc.c If we didn't set CONFIG_REGULATOR, always entered error condition. But that's not error..because we didn't use regulator framework. So when we only used CONFIG_REGULATOR, i think that need to

[PATCH] dw_mmc: fixed regulator control

2011-04-29 Thread Jaehoon Chung
This patch fixed regulator control in dw_mmc.c If we didn't set CONFIG_REGULATOR, always entered error condition. But that's not error..because we didn't use regulator framework. So when we only used CONFIG_REGULATOR, i think that need to get regulator. And In suspend function,