Re: [PATCH] dw_mmc: fixed wrong regulator_enable in suspend/resume

2011-05-12 Thread Chris Ball
Hi Jaehoon, On Wed, May 11 2011, Jaehoon Chung wrote: > In suspend function, regulator_enable() need not. > regulator_enable() should be locate in resume function. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park > --- > drivers/mmc/host/dw_mmc.c |6 +++--- > 1 files changed,

Re: [PATCH] dw_mmc: fixed wrong regulator_enable in suspend/resume

2011-05-12 Thread Will Newton
On Thu, May 12, 2011 at 4:46 AM, Chris Ball wrote: > Hi, > > On Wed, May 11 2011, Jaehoon Chung wrote: >> Hi Chris.. >> >> I think you're confused something because my explanation. >> >> My means..if we use the regulator, regulator is enabled when probing. >> Then regulator is enabling until we do

Re: [PATCH] dw_mmc: fixed wrong regulator_enable in suspend/resume

2011-05-11 Thread Chris Ball
Hi, On Wed, May 11 2011, Jaehoon Chung wrote: > Hi Chris.. > > I think you're confused something because my explanation. > > My means..if we use the regulator, regulator is enabled when probing. > Then regulator is enabling until we don't disable.. > > In order to power-save, disabled the regulato

Re: [PATCH] dw_mmc: fixed wrong regulator_enable in suspend/resume

2011-05-11 Thread Jaehoon Chung
Hi Chris.. I think you're confused something because my explanation. My means..if we use the regulator, regulator is enabled when probing. Then regulator is enabling until we don't disable.. In order to power-save, disabled the regulator when entered suspend. Already in suspend function, located

[PATCH] dw_mmc: fixed wrong regulator_enable in suspend/resume

2011-05-11 Thread Jaehoon Chung
In suspend function, regulator_enable() need not. regulator_enable() should be locate in resume function. Signed-off-by: Jaehoon Chung Signed-off-by: Kyungmin Park --- drivers/mmc/host/dw_mmc.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc

Re: [PATCH] dw_mmc: fixed wrong regulator_enable in suspend/resume

2011-05-11 Thread Chris Ball
Hi, On Wed, May 11 2011, Jaehoon Chung wrote: > In suspend function, regulator_enable() need not. > regulator_enable() should be locate in resume function. > > Signed-off-by: Jaehoon Chung > Signed-off-by: Kyungmin Park > --- > drivers/mmc/host/dw_mmc.c |6 +++--- > 1 files changed, 3 inser