Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Chris Ball
c: Add architecture dependency for Marvell SoC controller Since the driver is for controllers integrated into Marvell SoCs only offer MMC_SDHCI_MV if we're building for one. Signed-off-by: Mark Brown Cc: Haojian Zhuang Cc: Saeed Bishara [cjb: Use list of arches from Saeed, and updat

Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Haojian Zhuang
t;>linux-mmc@vger.kernel.org; linux-ker...@vger.kernel.org >>Subject: Re: [PATCH] mmc: Add architecture dependency for >>Marvell SoC controller >> >>On Wed, Sep 15, 2010 at 6:06 PM, Saeed Bishara >> wrote: >>> >>>>Which CPUs does the driv

RE: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Saeed Bishara
mmc: Add architecture dependency for >Marvell SoC controller > >On Wed, Sep 15, 2010 at 6:06 PM, Saeed Bishara > wrote: >> >>>Which CPUs does the driver actually support?  The Kconfig and >>>commit log >>>just say "Marvell" so I went for the

Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Haojian Zhuang
On Wed, Sep 15, 2010 at 6:06 PM, Saeed Bishara wrote: > >>Which CPUs does the driver actually support?  The Kconfig and >>commit log >>just say "Marvell" so I went for the conservative option and included >>all Marvell CPUs I was aware of. > The Marvell Dove SoC includes this device, this SoC defi

RE: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Saeed Bishara
>Which CPUs does the driver actually support? The Kconfig and >commit log >just say "Marvell" so I went for the conservative option and included >all Marvell CPUs I was aware of. The Marvell Dove SoC includes this device, this SoC defined by ARCH_DOVE I guess it found also only on mmp (defined

RE: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Saeed Bishara
mmc: Add architecture dependency for >Marvell SoC controller > >On Tue, Sep 14, 2010 at 08:05:49PM +0100, Chris Ball wrote: > >> This is fine with me. Saeed, please can you ACK the choice of >> platforms if you agree? > >If the list of platforms is wrong we should

Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Mark Brown
On Wed, Sep 15, 2010 at 12:55:33PM +0300, Saeed Bishara wrote: > I think the PLAT_PXA it too general, maybe you better specify the > exact ARCH (ARCH_MMP). Which CPUs does the driver actually support? The Kconfig and commit log just say "Marvell" so I went for the conservative option and include

Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-15 Thread Mark Brown
On Tue, Sep 14, 2010 at 08:05:49PM +0100, Chris Ball wrote: > This is fine with me. Saeed, please can you ACK the choice of > platforms if you agree? If the list of platforms is wrong we should probably also improve the help text :) -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-14 Thread Chris Ball
Hi, On Mon, Sep 13, 2010 at 09:24:39AM +0100, Mark Brown wrote: > Since the driver is for controllers integrated into Marvells SoCs only > offer MMC_SDHCI_MV if we're building for one. > > Signed-off-by: Mark Brown > --- > drivers/mmc/host/Kconfig |1 + > 1 files changed, 1 insertions(+), 0

Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-13 Thread Mark Brown
On Mon, Sep 13, 2010 at 12:48:38PM +0200, Arnd Bergmann wrote: > I think we normally try to do the the other way round: in order to increase > build coverage, try to enable all drivers on as many platforms as possible, > just don't have them in the defconfig. This is not the general pattern for o

Re: [PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-13 Thread Arnd Bergmann
On Monday 13 September 2010, Mark Brown wrote: > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig > index ce099c4..5fa4e2b 100644 > --- a/drivers/mmc/host/Kconfig > +++ b/drivers/mmc/host/Kconfig > @@ -133,6 +133,7 @@ config MMC_SDHCI_CNS3XXX > config MMC_SDHCI_MV > tristat

[PATCH] mmc: Add architecture dependency for Marvell SoC controller

2010-09-13 Thread Mark Brown
Since the driver is for controllers integrated into Marvells SoCs only offer MMC_SDHCI_MV if we're building for one. Signed-off-by: Mark Brown --- drivers/mmc/host/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig