Hi Takashi,
On Wed, Dec 22, 2010 at 09:59:44AM +0100, Takashi Iwai wrote:
> Subject: [PATCH] mmc: fix mmc_set_bus_width_ddr() call without bus-width-test
> cap
>
> With the bus-width test patch, mmc_set_bus_width*() isn't called properly
> when the driver doesn't set MMC_CAP_BUS_WIDTH and no DDR
On Wed, Dec 22, 2010 at 3:59 AM, Takashi Iwai wrote:
> At Tue, 21 Dec 2010 22:56:32 -0500,
> zhangfei gao wrote:
>>
>> On Tue, Dec 21, 2010 at 11:36 AM, Philip Rakity wrote:
>> >
>> >
>> > Can you please try this diff and see if it works for you.
>> >
>> > Will do formal patch after your testing.
At Tue, 21 Dec 2010 22:56:32 -0500,
zhangfei gao wrote:
>
> On Tue, Dec 21, 2010 at 11:36 AM, Philip Rakity wrote:
> >
> >
> > Can you please try this diff and see if it works for you.
> >
> > Will do formal patch after your testing. What card is failing ?
> >
> > Please let me know the manufact
On Tue, Dec 21, 2010 at 11:36 AM, Philip Rakity wrote:
>
>
> Can you please try this diff and see if it works for you.
>
> Will do formal patch after your testing. What card is failing ?
>
> Please let me know the manufacturing information so can add card to my test
> suite.
>
> Philip
>
> diff
Zhangfei,
Reproduced the problem on mmp2. Fix enclosed. Slight change from Zhangfei
original suggestion.
Please confirm by adding tested-by.
Philip
>From 8b35e007d67dd593ff5e8a07b564c438e8303aae Mon Sep 17 00:00:00 2001
From: Philip Rakity
Date: Tue, 21 Dec 2010 11:29:33 -0800
Subject: [P
Can you please try this diff and see if it works for you.
Will do formal patch after your testing. What card is failing ?
Please let me know the manufacturing information so can add card to my test
suite.
Philip
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 1d8409f..
On Fri, Dec 17, 2010 at 3:11 AM, Takashi Iwai wrote:
> At Fri, 17 Dec 2010 03:43:42 +,
> Chris Ball wrote:
>>
>> Hi Philip,
>>
>> On Thu, Dec 16, 2010 at 06:33:49PM -0800, Philip Rakity wrote:
>> > It is not possible for bus_width to be not initialized. This would imply
>> > ARRAY_SIZE(bus_w
At Fri, 17 Dec 2010 03:43:42 +,
Chris Ball wrote:
>
> Hi Philip,
>
> On Thu, Dec 16, 2010 at 06:33:49PM -0800, Philip Rakity wrote:
> > It is not possible for bus_width to be not initialized. This would imply
> > ARRAY_SIZE(bus_widths) is 1. Certainly not true.
>
> Right, I agree. We sho
Hi Philip,
On Thu, Dec 16, 2010 at 06:33:49PM -0800, Philip Rakity wrote:
> It is not possible for bus_width to be not initialized. This would imply
> ARRAY_SIZE(bus_widths) is 1. Certainly not true.
Right, I agree. We should fix the warning anyway.
> We could just initialize by changing
> +
Chris,
It is not possible for bus_width to be not initialized. This would imply
ARRAY_SIZE(bus_widths) is 1. Certainly not true.
We could just initialize by changing
+ unsigned idx, bus_width;
to
+ unsigned idx, bus_width = 0;
I wonder what compiler are you using s
Hi Takashi,
On Wed, Dec 15, 2010 at 08:14:24AM +0100, Takashi Iwai wrote:
> From: Aries Lee
>
> Some old MMC devices fail with the 4/8 bits the driver tries to use
> exclusively. This patch adds a test for the given bus setup and falls
> back to the lower bit mode (until 1-bit mode) when the te
From: Aries Lee
Some old MMC devices fail with the 4/8 bits the driver tries to use
exclusively. This patch adds a test for the given bus setup and falls
back to the lower bit mode (until 1-bit mode) when the test fails.
[Major rework and refactoring by tiwai]
[Quirk addition and many fixes by
12 matches
Mail list logo
