Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-28 Thread Ulf Hansson
- Chris and LKML, On 28 August 2015 at 02:38, LIYONG wrote: > Hi Uffe, > > Since Reliable Write depends on the CMD23. I think we need to disable > Reliable Write if the card does not support CMD23(due to performance impact > issue), so I add this patch. > > Do you think we still need to enable

RE: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-27 Thread LIYONG
> Date: Thu, 27 Aug 2015 15:22:44 +0200 > Subject: Re: [PATCH] mmc: block: disable the reliable write If the card does > not support CMD23 > From: ulf.hans...@linaro.org > To: sdliy...@gmail.com > CC: ch...@printf.net; linux-mmc@vger.ker

Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-27 Thread Ulf Hansson
On 25 August 2015 at 14:06, Ulf Hansson wrote: > On 14 August 2015 at 09:30, wrote: >> From: Yong Li >> >> Signed-off-by: Yong Li >> --- >> drivers/mmc/card/block.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.

RE: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-26 Thread LIYONG
ol do_rel_wr = ((req->cmd_flags & REQ_FUA) || > (req->cmd_flags & REQ_META)) && > (rq_data_dir(req) == WRITE) && > - (md->flags & MMC_BLK_REL_WR); > + (md->flags & MMC_BLK_REL_WR) && > + !(card->quirks & MMC_QUIRK_BLK_NO_CMD2

Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-26 Thread Shawn Lin
) == WRITE) && - (md->flags & MMC_BLK_REL_WR); + (md->flags & MMC_BLK_REL_WR) && + !(card->quirks & MMC_QUIRK_BLK_NO_CMD23); Thanks, Yong Li -------------------- Date: Tue, 25 Aug 2015 14:06:43 +0200 Subject: Re: [PATCH] mmc: block: disab

RE: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-25 Thread LIYONG
[PATCH] mmc: block: disable the reliable write If the card does > not support CMD23 > From: ulf.hans...@linaro.org > To: sdliy...@gmail.com > CC: ch...@printf.net; linux-mmc@vger.kernel.org; linux-ker...@vger.kernel.org > > On 14 August 2015 at 09:30, wrote: >> From: Y

Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-25 Thread Ulf Hansson
On 14 August 2015 at 09:30, wrote: > From: Yong Li > > Signed-off-by: Yong Li > --- > drivers/mmc/card/block.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c > index 452782b..d9e3c45 100644 > --- a/drivers/mmc/card

Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-16 Thread Shawn Lin
CMD23. The above code is executed before the "if ((md->flags & MMC_BLK_CMD23)" code. ok, it makes sense.:) Thanks, Yong Li ---- Subject: Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23 To: sdliy

RE: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-15 Thread LIYONG
before the "if ((md->flags & MMC_BLK_CMD23)" code. Thanks, Yong Li > Subject: Re: [PATCH] mmc: block: disable the reliable write If the card does > not support CMD23 > To: sdliy...@gmail.com; ch...@printf.net; ulf.hans..

Re: [PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-14 Thread Shawn Lin
在 2015/8/14 15:30, sdliy...@gmail.com 写道: From: Yong Li Signed-off-by: Yong Li --- drivers/mmc/card/block.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 452782b..d9e3c45 100644 --- a/drivers/mmc/card/block.c

[PATCH] mmc: block: disable the reliable write If the card does not support CMD23

2015-08-14 Thread sdliyong
From: Yong Li Signed-off-by: Yong Li --- drivers/mmc/card/block.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c index 452782b..d9e3c45 100644 --- a/drivers/mmc/card/block.c +++ b/drivers/mmc/card/block.c @@ -1366,7 +136