Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

2013-04-05 Thread Prasanna NAVARATNA
Ulf Hansson ulf.hansson at linaro.org writes: host-ocr is intended for keeping the negotiated ocr mask. Another variable is not needed. A proper patch would in principle remove the workaround, which means the reset of the host-ocr in mmc_power_off is not done any more. Exactly what you

Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

2013-04-05 Thread Ulf Hansson
On 5 April 2013 08:07, Prasanna NAVARATNA prasanna.navara...@gmail.com wrote: Ulf Hansson ulf.hansson at linaro.org writes: host-ocr is intended for keeping the negotiated ocr mask. Another variable is not needed. A proper patch would in principle remove the workaround, which means the

Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

2013-04-04 Thread Prasanna NAVARATNA
Kevin Liu kliu5 at marvell.com writes: host-ocr has been reset in power off but not restored after power up in resume. And operation voltage will be set to the highest after resume back. This patch fix these two bugs. Signed-off-by: Kevin Liu kliu5 at marvell.com ---

Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

2013-04-04 Thread Ulf Hansson
On 4 April 2013 11:44, Prasanna NAVARATNA prasanna.navara...@gmail.com wrote: Kevin Liu kliu5 at marvell.com writes: host-ocr has been reset in power off but not restored after power up in resume. And operation voltage will be set to the highest after resume back. This patch fix these two

Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

2013-04-04 Thread Prasanna NAVARATNA
Ulf Hansson ulf.hansson at linaro.org writes: On 4 April 2013 11:44, Prasanna NAVARATNA prasanna.navaratna at gmail.com wrote: Kevin Liu kliu5 at marvell.com writes: host-ocr has been reset in power off but not restored after power up in resume. And operation voltage will be set to

Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

2013-04-04 Thread Ulf Hansson
On 4 April 2013 12:43, Prasanna NAVARATNA prasanna.navara...@gmail.com wrote: Ulf Hansson ulf.hansson at linaro.org writes: On 4 April 2013 11:44, Prasanna NAVARATNA prasanna.navaratna at gmail.com wrote: Kevin Liu kliu5 at marvell.com writes: host-ocr has been reset in power off but

Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

2013-04-04 Thread Prasanna NAVARATNA
So you agree the ocr mask must not be reset during suspend. The patch over here exactly addresses the problem which you stated :- mmc core should tell the host driver to use the properly negotiated ocr mask to set the voltage level, both at initialization and at resume The patch saves the ocr

Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

2013-04-04 Thread Prasanna NAVARATNA
Prasanna NAVARATNA prasanna.navaratna at gmail.com writes: So you agree the ocr mask must not be reset during suspend. The patch over here exactly addresses the problem which you stated :- mmc core should tell the host driver to use the properly negotiated ocr mask to set the voltage

Re: [PATCH] mmc: core: restore ocr and operation voltage in resume

2013-04-04 Thread Ulf Hansson
On 4 April 2013 16:43, Prasanna NAVARATNA prasanna.navara...@gmail.com wrote: Prasanna NAVARATNA prasanna.navaratna at gmail.com writes: So you agree the ocr mask must not be reset during suspend. The patch over here exactly addresses the problem which you stated :- mmc core should tell the

[PATCH] mmc: core: restore ocr and operation voltage in resume

2013-02-20 Thread Kevin Liu
host-ocr has been reset in power off but not restored after power up in resume. And operation voltage will be set to the highest after resume back. This patch fix these two bugs. Signed-off-by: Kevin Liu kl...@marvell.com --- drivers/mmc/core/core.c |3 ++- include/linux/mmc/host.h |1 +