Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-14 Thread Alim Akhtar
Hi Doug, On Tue, Oct 14, 2014 at 10:21 PM, Doug Anderson wrote: > Hi, > > On Thu, Oct 9, 2014 at 5:36 PM, Doug Anderson wrote: >> Alim, >> >> On Thu, Oct 9, 2014 at 3:19 PM, Alim Akhtar wrote: >>> Thats fine, I think every vendor (most of them) has a custom >>> implementation of dw_mmc, but the

Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-14 Thread Doug Anderson
Hi, On Thu, Oct 9, 2014 at 5:36 PM, Doug Anderson wrote: > Alim, > > On Thu, Oct 9, 2014 at 3:19 PM, Alim Akhtar wrote: >> Thats fine, I think every vendor (most of them) has a custom >> implementation of dw_mmc, but they do have VERID register to check the >> dw_mmc version. >> The reason why I

Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-09 Thread Doug Anderson
Alim, On Thu, Oct 9, 2014 at 3:19 PM, Alim Akhtar wrote: > Thats fine, I think every vendor (most of them) has a custom > implementation of dw_mmc, but they do have VERID register to check the > dw_mmc version. > The reason why I asked is, I have seen inconsistency in card > enumeration on few co

Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-09 Thread Alim Akhtar
Hi Eddie, On Thu, Oct 9, 2014 at 7:43 PM, Eddie Cai(蔡枫) wrote: > Hi Alim > > 2014年10月8日 上午4:28于 "Alim Akhtar" 写道: > > >> >> Hi Sonny/Doug, >> >> On Mon, Oct 6, 2014 at 11:23 PM, Sonny Rao wrote: >> > We've already got a reset of DMA after it's done. Add one before we >> > start DMA too. This f

Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-08 Thread Alim Akhtar
Hi Sonny/Doug, On Mon, Oct 6, 2014 at 11:23 PM, Sonny Rao wrote: > We've already got a reset of DMA after it's done. Add one before we > start DMA too. This fixes a data corruption on Rockchip SoCs which > will get bad data when doing a DMA transfer after doing a PIO transfer. > > We tested thi

Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-07 Thread Jaehoon Chung
Acked-by: Jaehoon Chung On 10/07/2014 03:11 AM, Doug Anderson wrote: > Sonny, > > On Mon, Oct 6, 2014 at 10:53 AM, Sonny Rao wrote: >> We've already got a reset of DMA after it's done. Add one before we >> start DMA too. This fixes a data corruption on Rockchip SoCs which >> will get bad data

Re: [PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-06 Thread Doug Anderson
Sonny, On Mon, Oct 6, 2014 at 10:53 AM, Sonny Rao wrote: > We've already got a reset of DMA after it's done. Add one before we > start DMA too. This fixes a data corruption on Rockchip SoCs which > will get bad data when doing a DMA transfer after doing a PIO transfer. > > We tested this on an

[PATCH] mmc: dw_mmc: Reset DMA before enabling IDMAC

2014-10-06 Thread Sonny Rao
We've already got a reset of DMA after it's done. Add one before we start DMA too. This fixes a data corruption on Rockchip SoCs which will get bad data when doing a DMA transfer after doing a PIO transfer. We tested this on an Exynos 5800 with HS200 and didn't notice any difference in sequentia