Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-25 Thread Girish K S
On 26 July 2012 11:30, Jaehoon Chung wrote: > Hi Girish, > > I re-tested the your patch. > How about locating into dw_mci_setup_bus()? > > And if compare the previously and current busmode, > I think host needs not to re-write at register. > For example, > if (slot->bus_mode == ios->bus_mode) >

Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-25 Thread Jaehoon Chung
Hi Girish, I re-tested the your patch. How about locating into dw_mci_setup_bus()? And if compare the previously and current busmode, I think host needs not to re-write at register. For example, if (slot->bus_mode == ios->bus_mode) return; Then this patch looks good to me. Best Regards,

Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-25 Thread Girish K S
On 24 July 2012 18:37, Jae hoon Chung wrote: > Hi Girish, > > Right, it be mentioned about the open-drain mode in synopsys spec. > But if didn't work on other board, there is some problem. > We can consider the location of set_busmode() . Sure. Currently i am setting the bus mode after sending the

Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-25 Thread Girish K S
On 24 July 2012 19:14, Jae hoon Chung wrote: > 2012/7/24 Girish K S : >> On 24 July 2012 18:37, Jae hoon Chung wrote: >>> Hi Girish, >>> >>> Right, it be mentioned about the open-drain mode in synopsys spec. >>> But if didn't work on other board, there is some problem. >>> We can consider the loc

Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-24 Thread Jae hoon Chung
2012/7/24 Girish K S : > On 24 July 2012 18:37, Jae hoon Chung wrote: >> Hi Girish, >> >> Right, it be mentioned about the open-drain mode in synopsys spec. >> But if didn't work on other board, there is some problem. >> We can consider the location of set_busmode() . > may i know the board on whi

Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-24 Thread Girish K S
On 24 July 2012 18:37, Jae hoon Chung wrote: > Hi Girish, > > Right, it be mentioned about the open-drain mode in synopsys spec. > But if didn't work on other board, there is some problem. > We can consider the location of set_busmode() . may i know the board on which you are testing. i will try t

Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-24 Thread Jae hoon Chung
Hi Girish, Right, it be mentioned about the open-drain mode in synopsys spec. But if didn't work on other board, there is some problem. We can consider the location of set_busmode() . Best Regards, Jaehoon Chung 2012/7/24 Girish K S : > On 24 July 2012 17:06, Girish K S wrote: >> On 24 July 201

Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-24 Thread Girish K S
On 24 July 2012 17:06, Girish K S wrote: > On 24 July 2012 16:39, Jaehoon Chung wrote: >> Hi Girish, >> >> Well..just tested on my board. >> this patch didn't work.(eMMC card didn't initialize) >> meaning of ios->bus_mode and synosys's bus_mode is same? Yes it is same. synopsys spec says this is

Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-24 Thread Girish K S
On 24 July 2012 16:39, Jaehoon Chung wrote: > Hi Girish, > > Well..just tested on my board. > this patch didn't work.(eMMC card didn't initialize) > meaning of ios->bus_mode and synosys's bus_mode is same? > How did you test this patch? Tested it on exynos5 board using dt patches of thomas (with s

Re: [PATCH] mmc: dw_mmc: add busmode selection support

2012-07-24 Thread Jaehoon Chung
Hi Girish, Well..just tested on my board. this patch didn't work.(eMMC card didn't initialize) meaning of ios->bus_mode and synosys's bus_mode is same? How did you test this patch? Best Regards, Jaehoon Chung On 07/23/2012 08:16 PM, Girish K S wrote: > Synopsis Designware host controller has sup

[PATCH] mmc: dw_mmc: add busmode selection support

2012-07-23 Thread Girish K S
Synopsis Designware host controller has suppport for open drain mode selection. During the mmc card initialization the host controller can select the open-drain bit to allow the device initialization in the open-drain mode. Once the device enters the standby mode this bit can be reset to enter push