On Wednesday, March 27, 2013, Grant Grundler wrote:
Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
For easily identifying, it would be good to point the commit id and subject.
But when debugging a related issue (http://crbug.com/221828) I found
It is not easy to catch up
Grant,
Thanks for posting! See below...
On Tue, Mar 26, 2013 at 3:50 PM, Grant Grundler grund...@chromium.org wrote:
Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
But when debugging a related issue (http://crbug.com/221828) I found
the code unreadable. This rewrite
Sorry - please ignore the previous version. Did not include a
copyright (implied to be mine...but it's not) nor license.
Same thing but with proper attribution.
cheers,
grant
On Tue, Mar 26, 2013 at 3:53 PM, Grant Grundler grund...@chromium.org wrote:
I've attached the test program I wrote to
Hi Grant,
On Wed, Mar 27 2013, Grant Grundler wrote:
On Wed, Mar 27, 2013 at 5:25 AM, Seungwon Jeon tgih@samsung.com wrote:
On Wednesday, March 27, 2013, Grant Grundler wrote:
Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
For easily identifying, it would be good to
On Wed, Mar 27, 2013 at 8:07 AM, Doug Anderson diand...@chromium.org wrote:
Grant,
Thanks for posting! See below...
thanks for reviewing/feedback! :)
On Tue, Mar 26, 2013 at 3:50 PM, Grant Grundler grund...@chromium.org wrote:
Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV
Hi Chris,
On Wed, Mar 27, 2013 at 10:58 AM, Chris Ball c...@laptop.org wrote:
Hi Grant,
...
Please use the following (standard) syntax in the commit message:
Commit e419990b5e8 (mmc: dw_mmc: correct the calculation for CLKDIV)
fixed a bug in CLKDIV computation. [..]
Ok - I didn't know that
Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
But when debugging a related issue (http://crbug.com/221828) I found
the code unreadable. This rewrite simplifies the computation and
explains each step.
Signed-off-by: Grant Grundler grund...@chromium.org
---
Tested on Samsung
I've attached the test program I wrote to compare the different
flavors of CLKDIV computation: old (3.4 kernel), current upstream, and
my rewrite.
thanks
grant
On Tue, Mar 26, 2013 at 3:50 PM, Grant Grundler grund...@chromium.org wrote:
Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV