Re: [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

2013-01-11 Thread Russell King - ARM Linux
On Thu, Jan 10, 2013 at 09:29:15PM +0100, Andrew Lunn wrote: A NULL is a valid clk cookie, so we should not be tested with IS_ERR_NULL(). Replace it with IS_ERR(). Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/mmc/host/mvsdio.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

2013-01-11 Thread Thomas Petazzoni
Dear Russell King - ARM Linux, On Fri, 11 Jan 2013 11:02:10 +, Russell King - ARM Linux wrote: What remains? The assumption that GPIO0 means no GPIO rather than testing with gpio_valid() and the IRQ stuff. Patches that I have written have been merged by Jason Cooper and while adding the

Re: [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

2013-01-11 Thread Russell King - ARM Linux
On Fri, Jan 11, 2013 at 12:09:09PM +0100, Thomas Petazzoni wrote: Dear Russell King - ARM Linux, On Fri, 11 Jan 2013 11:02:10 +, Russell King - ARM Linux wrote: What remains? The assumption that GPIO0 means no GPIO rather than testing with gpio_valid() and the IRQ stuff. Patches

[PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

2013-01-10 Thread Andrew Lunn
A NULL is a valid clk cookie, so we should not be tested with IS_ERR_NULL(). Replace it with IS_ERR(). Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/mmc/host/mvsdio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/mvsdio.c

Re: [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

2013-01-10 Thread Jason Cooper
On Thu, Jan 10, 2013 at 09:29:15PM +0100, Andrew Lunn wrote: A NULL is a valid clk cookie, so we should not be tested with IS_ERR_NULL(). Replace it with IS_ERR(). Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/mmc/host/mvsdio.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] mmc: mvsdio: Replace IS_ERR_NULL() is with IS_ERR()

2013-01-10 Thread Simon Baatz
Hi Andrew, On Thu, Jan 10, 2013 at 09:29:15PM +0100, Andrew Lunn wrote: A NULL is a valid clk cookie, so we should not be tested with IS_ERR_NULL(). Replace it with IS_ERR(). Signed-off-by: Andrew Lunn and...@lunn.ch --- drivers/mmc/host/mvsdio.c |2 +- 1 file changed, 1