Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-28 Thread Russell King - ARM Linux
On Thu, Apr 28, 2011 at 09:52:17AM +0200, Per Forlin wrote: I wanted to test the performance without cache penalty but removing dma_map_sg may not work since it produces the physical mapped sg list. This is not as simple as I first thought. Make a copy for dma_map_sg (call it

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-21 Thread Shawn Guo
On Wed, Apr 20, 2011 at 05:22:34PM +0200, Per Forlin wrote: [...] Do you have omap_hsmmc and mmci mmc_test result data to share? I keep the here: https://wiki.linaro.org/WorkingGroups/Kernel/Specs/StoragePerfMMC-async-req Actually, I have seen this page before. I was wondering if you have

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-21 Thread Shawn Guo
On Wed, Apr 20, 2011 at 05:30:22PM +0200, Per Forlin wrote: [...] Remove dma_map and dma_unmap from your host driver and run the tests (obviously nonblocking and blocking will have the same results). If there is still no performance gain the cache penalty is very small on your platform and

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-21 Thread Per Forlin
On 21 April 2011 08:29, Shawn Guo shawn@freescale.com wrote: On Wed, Apr 20, 2011 at 05:30:22PM +0200, Per Forlin wrote: [...] Remove dma_map and dma_unmap from your host driver and run the tests (obviously nonblocking and blocking will have the same results). If there is still no

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-21 Thread Per Forlin
On 21 April 2011 08:25, Shawn Guo shawn@freescale.com wrote: On Wed, Apr 20, 2011 at 05:22:34PM +0200, Per Forlin wrote: [...] Do you have omap_hsmmc and mmci mmc_test result data to share? I keep the here: https://wiki.linaro.org/WorkingGroups/Kernel/Specs/StoragePerfMMC-async-req

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-21 Thread Shawn Guo
On Thu, Apr 21, 2011 at 10:46:18AM +0200, Per Forlin wrote: On 21 April 2011 08:29, Shawn Guo shawn@freescale.com wrote: On Wed, Apr 20, 2011 at 05:30:22PM +0200, Per Forlin wrote: [...] Remove dma_map and dma_unmap from your host driver and run the tests (obviously nonblocking and

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-21 Thread Per Forlin
On 21 April 2011 11:11, Shawn Guo shawn@freescale.com wrote: On Thu, Apr 21, 2011 at 10:46:18AM +0200, Per Forlin wrote: On 21 April 2011 08:29, Shawn Guo shawn@freescale.com wrote: On Wed, Apr 20, 2011 at 05:30:22PM +0200, Per Forlin wrote: [...] Remove dma_map and dma_unmap from

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-21 Thread Per Forlin
On 21 April 2011 11:47, Per Forlin per.for...@linaro.org wrote: On 21 April 2011 11:11, Shawn Guo shawn@freescale.com wrote: On Thu, Apr 21, 2011 at 10:46:18AM +0200, Per Forlin wrote: On 21 April 2011 08:29, Shawn Guo shawn@freescale.com wrote: On Wed, Apr 20, 2011 at 05:30:22PM

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-20 Thread Per Forlin
On 17 April 2011 18:33, Shawn Guo shawn@linaro.org wrote: pre_req() runs dma_map_sg() post_req() runs dma_unmap_sg. If not calling pre_req() before mxs_mmc_request(), request() will prepare the cache just like it did it before. It is optional to use pre_req() and post_req().

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-20 Thread Per Forlin
On 17 April 2011 18:48, Shawn Guo shawn@freescale.com wrote: On Mon, Apr 18, 2011 at 12:33:30AM +0800, Shawn Guo wrote: pre_req() runs dma_map_sg() post_req() runs dma_unmap_sg. If not calling pre_req() before mxs_mmc_request(), request() will prepare the cache just like it did it before.

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-20 Thread Shawn Guo
On Wed, Apr 20, 2011 at 09:58:48AM +0200, Per Forlin wrote:  static struct dma_async_tx_descriptor *mxs_mmc_prep_dma(        struct mxs_mmc_host *host, unsigned int append)  { @@ -312,8 +342,8 @@ static struct dma_async_tx_descriptor *mxs_mmc_prep_dma(        if (data) {              

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-20 Thread Shawn Guo
On Wed, Apr 20, 2011 at 10:01:22AM +0200, Per Forlin wrote: On 17 April 2011 18:48, Shawn Guo shawn@freescale.com wrote: On Mon, Apr 18, 2011 at 12:33:30AM +0800, Shawn Guo wrote: pre_req() runs dma_map_sg() post_req() runs dma_unmap_sg. If not calling pre_req() before

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-20 Thread Per Forlin
On 20 April 2011 16:01, Shawn Guo shawn@freescale.com wrote: On Wed, Apr 20, 2011 at 10:01:22AM +0200, Per Forlin wrote: On 17 April 2011 18:48, Shawn Guo shawn@freescale.com wrote: On Mon, Apr 18, 2011 at 12:33:30AM +0800, Shawn Guo wrote: pre_req() runs dma_map_sg() post_req() runs

Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req

2011-04-20 Thread Per Forlin
On 20 April 2011 16:01, Shawn Guo shawn@freescale.com wrote: On Wed, Apr 20, 2011 at 10:01:22AM +0200, Per Forlin wrote: On 17 April 2011 18:48, Shawn Guo shawn@freescale.com wrote: On Mon, Apr 18, 2011 at 12:33:30AM +0800, Shawn Guo wrote: pre_req() runs dma_map_sg() post_req() runs