Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-28 Thread Javier Martinez Canillas
Hello Ulf, On 10/27/2015 11:10 AM, Ulf Hansson wrote: > On 21 October 2015 at 17:15, Javier Martinez Canillas > wrote: >> The pwrseq_emmc driver does a eMMC card reset before a system reboot to >> allow broken or limited ROM boot-loaders (that don't have an eMMC reset >> logic) to be able to read

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-27 Thread Ulf Hansson
On 21 October 2015 at 17:15, Javier Martinez Canillas wrote: > The pwrseq_emmc driver does a eMMC card reset before a system reboot to > allow broken or limited ROM boot-loaders (that don't have an eMMC reset > logic) to be able to read the second stage from the eMMC. > > But this has to be called

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-23 Thread Alim Akhtar
On 10/22/2015 09:04 PM, Doug Anderson wrote: Krzysztof, On Wed, Oct 21, 2015 at 6:43 PM, Krzysztof Kozlowski wrote: I think at least one platform may be affected because it used mmc-pwrseq-emmc and gpio-restart. Look at rk3288-veyron.dtsi. Both of restart handlers had the priority of 129 w

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Doug, On 10/22/2015 07:33 PM, Doug Anderson wrote: > On Thu, Oct 22, 2015 at 9:07 AM, Javier Martinez Canillas [snip] >> >> Do you know why the priority 200 was chosen for veyron gpi-restart ooi? > > In David Riley's original patch the example had 200: > https://patchwork.kernel.org/p

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Doug Anderson
Hi, On Thu, Oct 22, 2015 at 9:07 AM, Javier Martinez Canillas wrote: >> Note that personally I would only choose the "highest" priority as an >> absolute last resort. Leaving a little extra slack in there means >> that when the next person comes up with a really good reason to run >> before you

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Doug, On 10/22/2015 05:34 PM, Doug Anderson wrote: > Krzysztof, > > On Wed, Oct 21, 2015 at 6:43 PM, Krzysztof Kozlowski > wrote: >> I think at least one platform may be affected because it used >> mmc-pwrseq-emmc and gpio-restart. >> >> Look at rk3288-veyron.dtsi. >> >> Both of restart ha

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Heiko Stübner
Am Donnerstag, 22. Oktober 2015, 08:34:38 schrieb Doug Anderson: > Note that personally I would only choose the "highest" priority as an > absolute last resort. Leaving a little extra slack in there means > that when the next person comes up with a really good reason to run > before you do that th

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Doug Anderson
Krzysztof, On Wed, Oct 21, 2015 at 6:43 PM, Krzysztof Kozlowski wrote: > I think at least one platform may be affected because it used > mmc-pwrseq-emmc and gpio-restart. > > Look at rk3288-veyron.dtsi. > > Both of restart handlers had the priority of 129 which means that the > order of execution

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Marek, On 10/22/2015 12:07 PM, Marek Szyprowski wrote: > On 2015-10-22 06:14, Alim Akhtar wrote: >> On 10/22/2015 08:22 AM, Javier Martinez Canillas wrote: >>> On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: On 22.10.2015 10:20, Javier Martinez Canillas wrote:> Hello Krzysztof, [sni

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Marek Szyprowski
Hello, On 2015-10-22 06:14, Alim Akhtar wrote: CCing Doug, Heiko and Enric Balletbo To help us by testing on rk3288-veyron and am335x-sl50 boards. On 10/22/2015 08:22 AM, Javier Martinez Canillas wrote: Hello Krzysztof, On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: On 22.10.2015 10:20,

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Anand Moon
Hi Javier, On 22 October 2015 at 14:06, Javier Martinez Canillas wrote: > Hello Anand, > > On 10/22/2015 07:03 AM, Anand Moon wrote: >> Hi Javier, >> >> On 22 October 2015 at 08:22, Javier Martinez Canillas >> wrote: >>> Hello Krzysztof, >>> >>> On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote:

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-22 Thread Javier Martinez Canillas
Hello Anand, On 10/22/2015 07:03 AM, Anand Moon wrote: > Hi Javier, > > On 22 October 2015 at 08:22, Javier Martinez Canillas > wrote: >> Hello Krzysztof, >> >> On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: >>> On 22.10.2015 10:20, Javier Martinez Canillas wrote:> Hello Krzysztof,

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Anand Moon
Hi Javier, On 22 October 2015 at 08:22, Javier Martinez Canillas wrote: > Hello Krzysztof, > > On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: >> On 22.10.2015 10:20, Javier Martinez Canillas wrote:> Hello Krzysztof, >>> >>> Thanks for your feedback. >>> >>> On 10/22/2015 02:36 AM, Krzysztof K

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Alim Akhtar
CCing Doug, Heiko and Enric Balletbo To help us by testing on rk3288-veyron and am335x-sl50 boards. On 10/22/2015 08:22 AM, Javier Martinez Canillas wrote: Hello Krzysztof, On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: On 22.10.2015 10:20, Javier Martinez Canillas wrote:> Hello Krzysztof,

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 10/22/2015 03:43 AM, Krzysztof Kozlowski wrote: > On 22.10.2015 10:20, Javier Martinez Canillas wrote:> Hello Krzysztof, >> >> Thanks for your feedback. >> >> On 10/22/2015 02:36 AM, Krzysztof Kozlowski wrote: >>> On 22.10.2015 00:15, Javier Martinez Canillas wrote: The pw

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Krzysztof Kozlowski
On 22.10.2015 10:20, Javier Martinez Canillas wrote:> Hello Krzysztof, > > Thanks for your feedback. > > On 10/22/2015 02:36 AM, Krzysztof Kozlowski wrote: >> On 22.10.2015 00:15, Javier Martinez Canillas wrote: >>> The pwrseq_emmc driver does a eMMC card reset before a system reboot to >>> allow

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Javier Martinez Canillas
Hello Krzysztof, Thanks for your feedback. On 10/22/2015 02:36 AM, Krzysztof Kozlowski wrote: > On 22.10.2015 00:15, Javier Martinez Canillas wrote: >> The pwrseq_emmc driver does a eMMC card reset before a system reboot to >> allow broken or limited ROM boot-loaders (that don't have an eMMC rese

Re: [PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Krzysztof Kozlowski
On 22.10.2015 00:15, Javier Martinez Canillas wrote: > The pwrseq_emmc driver does a eMMC card reset before a system reboot to > allow broken or limited ROM boot-loaders (that don't have an eMMC reset > logic) to be able to read the second stage from the eMMC. > > But this has to be called before

[PATCH] mmc: pwrseq: Use highest priority for eMMC restart handler

2015-10-21 Thread Javier Martinez Canillas
The pwrseq_emmc driver does a eMMC card reset before a system reboot to allow broken or limited ROM boot-loaders (that don't have an eMMC reset logic) to be able to read the second stage from the eMMC. But this has to be called before a system reboot handler and while most of them use the priority