RE: [PATCH] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-09-28 Thread Yong Ding
-Original Message- From: Anton Vorontsov [mailto:anton.voront...@linaro.org] Sent: Thursday, September 27, 2012 7:50 AM To: Yong Ding Cc: Chris Ball; linux-mmc@vger.kernel.org; Daniel Drake; Zhangfei Gao Subject: Re: [PATCH] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host On Tue, Sep 25, 2012

Re: [PATCH] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-09-26 Thread Anton Vorontsov
On Tue, Sep 25, 2012 at 02:13:10AM -0700, Yong Ding wrote: [...] > So, in all, u are right if with my current patch, some host drivers need > some improvement to add MMC_CAP_NEEDS_POLL when it is actually needed. > But I think this shall be the right way to follow. Or, we might enable > polling for

RE: [PATCH] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-09-25 Thread Yong Ding
essor Systems Engineering > -Original Message- > From: Anton Vorontsov [mailto:anton.voront...@linaro.org] > Sent: Tuesday, September 25, 2012 3:04 PM > To: Yong Ding > Cc: Chris Ball; linux-mmc@vger.kernel.org; Daniel Drake; Zhangfei Gao > Subject: Re: [PATCH] mmc: remove MMC

Re: [PATCH] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-09-25 Thread Anton Vorontsov
On Tue, Sep 25, 2012 at 02:34:07PM +0800, yongd wrote: > From: yongd [...] > And the better one to decide whether we use polling or not should be > the host driver itself. Actually, some host driver has already been > like this. Eg, in drivers/mmc/host/Au1xmmc.c, polling will be enabled > only aft

[PATCH] mmc: remove MMC_CAP_NEEDS_POLL setting in sdhci_add_host

2012-09-24 Thread yongd
From: yongd In the current code logic, sdhci_add_host() will enable the polling method (set MMC_CAP_NEEDS_POLL) for a removable card (MMC_CAP_ NONREMOVABLE is not set) whose host's internal card detection method is disabled for some reason (SDHCI_QUIRK_BROKEN_CARD_DETECTION is set). However, thi