Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-17 Thread Stephen Boyd
On 09/18, Ulf Hansson wrote: > 2014-09-15 23:45 GMT+02:00 Stephen Boyd : > > On 09/04/14 15:01, Stephen Boyd wrote: > >> > >> 8< > >> From: Stephen Boyd > >> Subject: [PATCH] mmc: Consolidate emmc tuning blocks > >> > >> The same tuning block array exists in the dw_mmc h.c and sdhci-msm.c

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-17 Thread Ulf Hansson
2014-09-15 23:45 GMT+02:00 Stephen Boyd : > On 09/04/14 15:01, Stephen Boyd wrote: >> >> 8< >> From: Stephen Boyd >> Subject: [PATCH] mmc: Consolidate emmc tuning blocks >> >> The same tuning block array exists in the dw_mmc h.c and sdhci-msm.c >> files. Move these into mmc.c so that they

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-15 Thread Stephen Boyd
On 09/04/14 15:01, Stephen Boyd wrote: > > 8< > From: Stephen Boyd > Subject: [PATCH] mmc: Consolidate emmc tuning blocks > > The same tuning block array exists in the dw_mmc h.c and sdhci-msm.c > files. Move these into mmc.c so that they can be shared across > drivers. > > Reported-by: Ja

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-04 Thread Stephen Boyd
On 09/05, Jaehoon Chung wrote: > On 09/05/2014 06:22 AM, Stephen Boyd wrote: > > On 09/04/14 03:53, Ulf Hansson wrote: > >> On 4 September 2014 07:06, Jaehoon Chung wrote: > >>> > >>> In dw-mmc.c, tuning_block values are same. > >>> So I think we can move these value into generic header. how about

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-04 Thread Jaehoon Chung
On 09/05/2014 06:22 AM, Stephen Boyd wrote: > On 09/04/14 03:53, Ulf Hansson wrote: >> On 4 September 2014 07:06, Jaehoon Chung wrote: >>> >>> In dw-mmc.c, tuning_block values are same. >>> So I think we can move these value into generic header. how about? >> Actually, I believe these values comes

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-04 Thread Stephen Boyd
On 09/04/14 03:53, Ulf Hansson wrote: > On 4 September 2014 07:06, Jaehoon Chung wrote: >> >> In dw-mmc.c, tuning_block values are same. >> So I think we can move these value into generic header. how about? > Actually, I believe these values comes from the eMMC specification? > Shouldn't they be m

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-04 Thread Ulf Hansson
On 4 September 2014 07:06, Jaehoon Chung wrote: > Hi, Stephen. > > On 09/03/2014 10:57 PM, Stephen Boyd wrote: >> If we're tuning on a big-endian CPU we'll never determine we properly >> tuned the device because we compare the data we received from the >> controller with a table that assumes the C

Re: [PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-03 Thread Jaehoon Chung
Hi, Stephen. On 09/03/2014 10:57 PM, Stephen Boyd wrote: > If we're tuning on a big-endian CPU we'll never determine we properly > tuned the device because we compare the data we received from the > controller with a table that assumes the CPU is little-endian. > Change the table to be an array of

[PATCH] mmc: sdhci-msm: Make tuning block table endian agnostic

2014-09-03 Thread Stephen Boyd
If we're tuning on a big-endian CPU we'll never determine we properly tuned the device because we compare the data we received from the controller with a table that assumes the CPU is little-endian. Change the table to be an array of bytes instead of 32-bit words so we can use memcmp() without need