Re: [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host

2014-09-10 Thread Ulf Hansson
On 10 September 2014 15:24, Laurent Pinchart wrote: > On Wednesday 16 July 2014 11:53:21 Laurent Pinchart wrote: >> On Wednesday 16 July 2014 15:50:09 Xiang Wang wrote: >> > From: Xiang Wang >> > >> > Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error >> > handling of sdhci_add_host.

Re: [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host

2014-09-10 Thread Laurent Pinchart
On Wednesday 16 July 2014 11:53:21 Laurent Pinchart wrote: > On Wednesday 16 July 2014 15:50:09 Xiang Wang wrote: > > From: Xiang Wang > > > > Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error > > handling of sdhci_add_host. However, "err_of_parse" and "err_cd_req" > > should be plac

Re: [PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host

2014-07-16 Thread Laurent Pinchart
Hi Xiang, Thank you for the patch. On Wednesday 16 July 2014 15:50:09 Xiang Wang wrote: > From: Xiang Wang > > Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error > handling of sdhci_add_host. However, "err_of_parse" and "err_cd_req" > should be placed after "pm_runtime_disable(&pdev

[PATCH] mmc: sdhci-pxav3: fix error handling of sdhci_add_host

2014-07-16 Thread Xiang Wang
From: Xiang Wang Commit 0dcaa2499b7d111bd70da5b0976c34210c850fb3 improved error handling of sdhci_add_host. However, "err_of_parse" and "err_cd_req" should be placed after "pm_runtime_disable(&pdev->dev)". Signed-off-by: Xiang Wang --- drivers/mmc/host/sdhci-pxav3.c |4 ++-- 1 files change