Re: [PATCH] mmc: sdhci-pxav3: fix setting of pdata->clk_delay_cycles

2015-01-29 Thread Ulf Hansson
On 28 January 2015 at 12:54, Jisheng Zhang wrote: > Current code checks "clk_delay_cycles > 0" to know whether the optional > "mrvl,clk_delay_cycles" is set or not. But of_property_read_u32() doesn't > touch clk_delay_cycles if the property is not set. And type of > clk_delay_cycles is u32, so we

[PATCH] mmc: sdhci-pxav3: fix setting of pdata->clk_delay_cycles

2015-01-28 Thread Jisheng Zhang
Current code checks "clk_delay_cycles > 0" to know whether the optional "mrvl,clk_delay_cycles" is set or not. But of_property_read_u32() doesn't touch clk_delay_cycles if the property is not set. And type of clk_delay_cycles is u32, so we may always set pdata->clk_delay_cycles as a random value.

[PATCH] mmc: sdhci-pxav3: fix setting of pdata->clk_delay_cycles

2015-01-28 Thread Jisheng Zhang
Current code checks "clk_delay_cycles > 0" to know whether the optional "mrvl,clk_delay_cycles" is set or not. But of_property_read_u32() doesn't touch clk_delay_cycles if the property is not set. And type of clk_delay_cycles is u32, so we may always set pdata->clk_delay_cycles as a random value.