Re: [PATCH] mmc: sdhci-sirf: add sirf tuning function (cmd 19)

2014-11-21 Thread Ulf Hansson
On 20 November 2014 10:25, Barry Song 21cn...@gmail.com wrote: These piece of code, which sends the tuning command don't belong in the host driver. Instead I would like this to be handled from a helper function from the mmc core. I realize that there already a few existing host drivers that

Re: [PATCH] mmc: sdhci-sirf: add sirf tuning function (cmd 19)

2014-11-20 Thread Barry Song
These piece of code, which sends the tuning command don't belong in the host driver. Instead I would like this to be handled from a helper function from the mmc core. I realize that there already a few existing host drivers that implemented similar code and I don't like it. We should convert

Re: [PATCH] mmc: sdhci-sirf: add sirf tuning function (cmd 19)

2014-11-17 Thread Barry Song
2014-11-12 17:35 GMT+08:00 Ulf Hansson ulf.hans...@linaro.org: On 11 November 2014 16:47, Barry Song 21cn...@gmail.com wrote: From: Minda Chen minda.c...@csr.com Add manual tuning function in CSR atlas7 SoC. It is mainly used for the UHS-I SD card working SDR50 SDR104 mode. The tuning

Re: [PATCH] mmc: sdhci-sirf: add sirf tuning function (cmd 19)

2014-11-17 Thread Ulf Hansson
On 17 November 2014 10:30, Barry Song 21cn...@gmail.com wrote: 2014-11-12 17:35 GMT+08:00 Ulf Hansson ulf.hans...@linaro.org: On 11 November 2014 16:47, Barry Song 21cn...@gmail.com wrote: From: Minda Chen minda.c...@csr.com Add manual tuning function in CSR atlas7 SoC. It is mainly used for

Re: [PATCH] mmc: sdhci-sirf: add sirf tuning function (cmd 19)

2014-11-12 Thread Ulf Hansson
On 11 November 2014 16:47, Barry Song 21cn...@gmail.com wrote: From: Minda Chen minda.c...@csr.com Add manual tuning function in CSR atlas7 SoC. It is mainly used for the UHS-I SD card working SDR50 SDR104 mode. The tuning principle can be seen in SD spec part1 v3.01 4.2.4.5 (tuning

[PATCH] mmc: sdhci-sirf: add sirf tuning function (cmd 19)

2014-11-11 Thread Barry Song
From: Minda Chen minda.c...@csr.com Add manual tuning function in CSR atlas7 SoC. It is mainly used for the UHS-I SD card working SDR50 SDR104 mode. The tuning principle can be seen in SD spec part1 v3.01 4.2.4.5 (tuning command). SD host send the cmd19 and set the delay value(0-127). and the