Re: [PATCH] mmc: slot-gpio: Add support for power gpios

2012-09-09 Thread Chris Ball
Hi Guennadi, Thanks for getting to this review so quickly! I agree with all of your comments. I'm sending out v2 of both patches now. On Sun, Sep 09 2012, Guennadi Liakhovetski wrote: >> The zero-length array trick might be becoming unmaintainable as we add >> more labels to the struct like thi

Re: [PATCH] mmc: slot-gpio: Add support for power gpios

2012-09-09 Thread Guennadi Liakhovetski
Hi Chris On Sat, 8 Sep 2012, Chris Ball wrote: > A power gpio is a sideband output gpio that controls card power. > > Signed-off-by: Chris Ball > --- > Hi Guennadi, what do you think of this patch? I'm hoping to use it Looks good in general to me, thanks! Just a couple of nit-picks below. >

[PATCH] mmc: slot-gpio: Add support for power gpios

2012-09-08 Thread Chris Ball
A power gpio is a sideband output gpio that controls card power. Signed-off-by: Chris Ball --- Hi Guennadi, what do you think of this patch? I'm hoping to use it first to de-duplicate power-gpio handling between sdhci-pxa and sdhci-tegra, and then to create a generic DT parser for MMC. The zero