Re: [PATCH] mmc: tmio: Fix race condition resulting in spurious interrupts

2011-06-30 Thread Chris Ball
Hi, On Sun, May 15 2011, Paul Parsons wrote: There is a race condition in the tmio_mmc_irq() interrupt handler, caused by the presence of a while loop, which results in warnings of spurious interrupts. This was found on an HP iPAQ hx4700 whose HTC ASIC3 reportedly incorporates the Toshiba

Re: [PATCH] mmc: tmio: Fix race condition resulting in spurious interrupts

2011-05-16 Thread Guennadi Liakhovetski
On Sun, 15 May 2011, Paul Parsons wrote: There is a race condition in the tmio_mmc_irq() interrupt handler, caused by the presence of a while loop, which results in warnings of spurious interrupts. This was found on an HP iPAQ hx4700 whose HTC ASIC3 reportedly incorporates the Toshiba

Re: [PATCH] mmc: tmio: Fix race condition resulting in spurious interrupts

2011-05-16 Thread Paul Parsons
I wouldn't call this a race. If the hardware sets the next status bit before the interrupt handler reaches the bottom of the loop, then the loop repeats, and the subsequent interrupt is reported as spurious. If the interrupt handler reaches the bottom of the loop before the hardware sets the

Re: [PATCH] mmc: tmio: Fix race condition resulting in spurious interrupts

2011-05-16 Thread Guennadi Liakhovetski
On Mon, 16 May 2011, Paul Parsons wrote: I wouldn't call this a race. If the hardware sets the next status bit before the interrupt handler reaches the bottom of the loop, then the loop repeats, and the subsequent interrupt is reported as spurious. If the interrupt handler reaches the