Re: [PATCH] mmc: tmio: fix address in kunmap_atomic() calls

2011-03-18 Thread Chris Ball
Hi Guennadi, On Mon, Mar 14 2011, Guennadi Liakhovetski wrote: > Hm, I've looked at them briefly and nothing in them struck me in them, but > if you want a formal reviewed-by or such I'll have to look at them in more > detail. I'm away from tomorrow until Saturday at a V4L2 meeting, so, will >

Re: [PATCH] mmc: tmio: fix address in kunmap_atomic() calls

2011-03-14 Thread Guennadi Liakhovetski
Hi Chris On Mon, 14 Mar 2011, Chris Ball wrote: > Hi Guennadi, > > On Fri, Mar 11 2011, Guennadi Liakhovetski wrote: > > Currently kunmap_atomic() doesn't take into account the offset, used > > with kmap_atomic(). On platforms, where kunmap_atomic() is not a NOP, > > this will lead to problems,

Re: [PATCH] mmc: tmio: fix address in kunmap_atomic() calls

2011-03-14 Thread Chris Ball
Hi Guennadi, On Fri, Mar 11 2011, Guennadi Liakhovetski wrote: > Currently kunmap_atomic() doesn't take into account the offset, used > with kmap_atomic(). On platforms, where kunmap_atomic() is not a NOP, > this will lead to problems, when offset != 0. > > Signed-off-by: Guennadi Liakhovetski >

[PATCH] mmc: tmio: fix address in kunmap_atomic() calls

2011-03-10 Thread Guennadi Liakhovetski
Currently kunmap_atomic() doesn't take into account the offset, used with kmap_atomic(). On platforms, where kunmap_atomic() is not a NOP, this will lead to problems, when offset != 0. Signed-off-by: Guennadi Liakhovetski --- No, I've never seen this bug trigger, so, not sure whether we need it