On Sat, Jan 25, 2014 at 5:47 PM, Chris Ball ch...@printf.net wrote:
Hi Grant,
On Thu, Jan 23 2014, Grant Grundler wrote:
respin sent with v2 in subject line and includes the '\0' assignment
change.
Apologies again.
Thanks, no worries. Would you like me to take this now, or wait for
Hi Grant,
On Thu, Jan 23 2014, Grant Grundler wrote:
respin sent with v2 in subject line and includes the '\0' assignment change.
Apologies again.
Thanks, no worries. Would you like me to take this now, or wait for
testing?
- Chris.
--
Chris Ball ch...@printf.net http://printf.net/
--
Field Firmware Update feature is new for 5.0 spec.
Code written per JESD84-B50.pdf spec available from:
http://www.jedec.org/standards-documents/technology-focus-areas/flash-memory-ssds-ufs-emmc/e-mmc
Signed-off-by: Grant Grundler grund...@chromium.org
---
This patch needs to be reviewed and
Hi Grant,
On Thu, Jan 23 2014, Grant Grundler wrote:
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
CC ?= gcc
AM_CFLAGS = -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2
CFLAGS ?= -g -O2
-objects = mmc.o mmc_cmds.o
+objects = mmc.o mmc_cmds.o mmc_cmds-emmc5.o
CHECKFLAGS = -Wall -Werror
Hi,
On Thu, Jan 23 2014, Grant Grundler wrote:
+ cid[13] = 0;/* make sure string is NULL terminated */
Ah, and if you're respinning the patch anyway, would you object to
using '\0' here? Just a style preference, either way is okay.
Thanks,
- Chris.
--
Chris Ball ch...@printf.net
On Thu, Jan 23, 2014 at 10:42 AM, Chris Ball ch...@printf.net wrote:
Hi Grant,
On Thu, Jan 23 2014, Grant Grundler wrote:
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
CC ?= gcc
AM_CFLAGS = -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2
CFLAGS ?= -g -O2
-objects = mmc.o mmc_cmds.o
On Thu, Jan 23, 2014 at 10:45 AM, Chris Ball ch...@printf.net wrote:
Hi,
On Thu, Jan 23 2014, Grant Grundler wrote:
+ cid[13] = 0;/* make sure string is NULL terminated */
Ah, and if you're respinning the patch anyway, would you object to
using '\0' here? Just a style preference,
On Thu, Jan 23, 2014 at 11:28 AM, Chris Ball ch...@printf.net wrote:
Hi Grant,
On Thu, Jan 23 2014, Grant Grundler wrote:
You can directly pull into a local branch/review with:
git fetch
https://chromium.googlesource.com/chromiumos/third_party/mmc-utils
refs/changes/21/179621/2 git
Hi Grant,
On Thu, Jan 23 2014, Grant Grundler wrote:
You can directly pull into a local branch/review with:
git fetch
https://chromium.googlesource.com/chromiumos/third_party/mmc-utils
refs/changes/21/179621/2 git cherry-pick FETCH_HEAD
Thanks, that worked fine. Now I'm seeing:
cc
On Thu, Jan 23, 2014 at 11:30 AM, Grant Grundler grund...@chromium.org wrote:
Will respin ASAP. and resend. *sigh*
respin sent with v2 in subject line and includes the '\0' assignment change.
Apologies again.
cheers,
grant
--
To unsubscribe from this list: send the line unsubscribe linux-mmc
On Thu, Jan 23, 2014 at 11:30 AM, Grant Grundler grund...@chromium.org wrote:
...
Sorry - I fixed that yesterday but apparently didn't update the git
format-patch output I used to send the patch out today. /o\
I figure out what happened. Sharing to remind others of this silly brain fart.
I
11 matches
Mail list logo