Re: [PATCH] mxcmmc: use dmaengine API

2011-01-12 Thread Shawn Guo
It seems all the tabs were turned into spaces. On Wed, Jan 12, 2011 at 11:09:56AM +0100, Sascha Hauer wrote: > This switches the mxcmmc driver to use the dmaengine API. Unlike > the old one this one is always present in the tree, even if no DMA > is implement, hence we can remove all the #ifdefs i

Re: [PATCH] mxcmmc: use dmaengine API

2011-01-12 Thread Sascha Hauer
On Wed, Jan 12, 2011 at 10:26:32AM +, Russell King - ARM Linux wrote: > On Wed, Jan 12, 2011 at 11:09:56AM +0100, Sascha Hauer wrote: > > + host->dma_nents = dma_map_sg(mmc_dev(host->mmc), data->sg, > > +data->sg_len, host->dma_dir); > > As recently discussed

Re: [PATCH] mxcmmc: use dmaengine API

2011-01-12 Thread Shawn Guo
On Wed, Jan 12, 2011 at 8:25 PM, Shawn Guo wrote: > It seems all the tabs were turned into spaces. > My problem. Sorry for the noise. > On Wed, Jan 12, 2011 at 11:09:56AM +0100, Sascha Hauer wrote: >> This switches the mxcmmc driver to use the dmaengine API. Unlike >> the old one this one is alw

Re: [PATCH] mxcmmc: use dmaengine API

2011-01-12 Thread Russell King - ARM Linux
On Wed, Jan 12, 2011 at 11:09:56AM +0100, Sascha Hauer wrote: > + host->dma_nents = dma_map_sg(mmc_dev(host->mmc), data->sg, > + data->sg_len, host->dma_dir); As recently discussed, you don't need to save dma_nents - the value to be passed to dma_unmap_sg() is

[PATCH] mxcmmc: use dmaengine API

2011-01-12 Thread Sascha Hauer
This switches the mxcmmc driver to use the dmaengine API. Unlike the old one this one is always present in the tree, even if no DMA is implement, hence we can remove all the #ifdefs in from the driver. The driver automatically switches to PIO mode if no DMA support or no suitable channel is availab