Re: [PATCH] sdhci: sdhci_dumpregs: allow private information to be dumped on error

2010-10-20 Thread Wolfram Sang
Hi Philip, > sdhci_dumpregs is used to debug the hardware/driver so I do not see an issue > here. The register info is not useful to a normal linux user. We can fine > tune the timing on the controller so knowing the settings is useful if there > are CRC errors. I'd prefer to keep such changes

Re: [PATCH] sdhci: sdhci_dumpregs: allow private information to be dumped on error

2010-10-19 Thread Philip Rakity
sdhci_dumpregs is used to debug the hardware/driver so I do not see an issue here. The register info is not useful to a normal linux user. We can fine tune the timing on the controller so knowing the settings is useful if there are CRC errors. The reason to add this -- rather than wait -- i

Re: [PATCH] sdhci: sdhci_dumpregs: allow private information to be dumped on error

2010-10-19 Thread Chris Ball
Hi, On Tue, Oct 19, 2010 at 09:47:24PM +0200, Wolfram Sang wrote: > On Tue, Oct 19, 2010 at 11:27:22AM -0700, Philip Rakity wrote: > > Our controller has private registers that are useful to see on error. > > define a new host->ops to allow these registers to be printed > > > > Signed-off-by: Phi

Re: [PATCH] sdhci: sdhci_dumpregs: allow private information to be dumped on error

2010-10-19 Thread Wolfram Sang
Hi Philip, On Tue, Oct 19, 2010 at 11:27:22AM -0700, Philip Rakity wrote: > Our controller has private registers that are useful to see on error. > define a new host->ops to allow these registers to be printed > > Signed-off-by: Philip Rakity I wonder if we really need such a thing in the mainl

[PATCH] sdhci: sdhci_dumpregs: allow private information to be dumped on error

2010-10-19 Thread Philip Rakity
Our controller has private registers that are useful to see on error. define a new host->ops to allow these registers to be printed Signed-off-by: Philip Rakity --- drivers/mmc/host/sdhci.c |2 ++ drivers/mmc/host/sdhci.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git