[PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Jaehoon Chung
This patch is added platform_8bit_width() function in sdhci-s3c. We has 8-bit width support but is not a v3 controller. So we need platform_8bit_width() to support 8-bit buswidth. Also we need MMC_CAP_8_BIT_DATA, so we added them in platdata. Signed-off-by: Jaehoon Chung jh80.ch...@samsung.com

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Chris Ball
Hi Jaehoon, Looks fine, just style corrections: On Wed, Jan 12, 2011 at 09:30:41AM +0900, Jaehoon Chung wrote: This patch is added platform_8bit_width() function in sdhci-s3c. ^ adds We has 8-bit width support but is not a v3 controller. ^ have So we need

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Jaehoon Chung
Hi Chris. Thanks for your comments. So i fixed them, and resend the patch. We have 8-bit width support bu is not a v3 controller. So we need platform_8bit_width() to support 8-bit buswidth. Also we need MMC_CAP_8_BIT_DATA, so we add it in platdata. Signed-off-by: Jaehoon Chung

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Chris Ball
Hi Jaehoon, On Wed, Jan 12, 2011 at 11:59:12AM +0900, Jaehoon Chung wrote: Hi Chris. Thanks for your comments. So i fixed them, and resend the patch. Thanks! I've pushed it to mmc-next. We have 8-bit width support bu is not a v3 controller. So we need platform_8bit_width() to support

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Kyungmin Park
On Wed, Jan 12, 2011 at 12:27 PM, Chris Ball c...@laptop.org wrote: Hi Jaehoon, On Wed, Jan 12, 2011 at 11:59:12AM +0900, Jaehoon Chung wrote: Hi Chris. Thanks for your comments. So i fixed them, and resend the patch. Thanks!  I've pushed it to mmc-next. We have 8-bit width support bu

Re: [PATCH] sdhci-s3c: add platform_8bit_width()

2011-01-11 Thread Chris Ball
On Wed, Jan 12, 2011 at 12:54:07PM +0900, Kyungmin Park wrote: Umm I think it's kind of bug fix since we used 8-bit buswidth previous code but recent change don't make it working So re-support the 8-bit buswidth. Can you merge it at 38.rc period? Okay, that should be fine. As always, though,