Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

2009-11-03 Thread Alan Cox
> > sdio_uart_irq > > sdio_uart_port_remove > > port->func = NULL; > > sdio_in > > BUG_ON > > This is actually happening? sdio_claim_host()/sdio_release_host() act Found by inspection > like a mutex so sdio_uart

Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

2009-11-03 Thread David Vrabel
Alan Cox wrote: > > The claim method takes the mutex, checks if it is NULL and acts > accordingly but it releases the mutex, which makes it useless as the code > then uses port->func. If I move the release of the mutex to the > release_func method then that fixes almost all cases. > > The one I'm

Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

2009-11-03 Thread Alan Cox
> With this folded in, the card does work with the full series applied. > However the kernel is now crashing when the card is pulled out while > some process is reading from the device. This used to behave well > before. I don't have time to investigate that one right now though. Going throug

Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

2009-11-02 Thread Nicolas Pitre
On Mon, 2 Nov 2009, Nicolas Pitre wrote: > With this folded in, the card does work with the full series applied. > However the kernel is now crashing when the card is pulled out while > some process is reading from the device. This used to behave well > before. I don't have time to investigat

Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

2009-11-02 Thread Alan Cox
> However the kernel is now crashing when the card is pulled out while > some process is reading from the device. This used to behave well > before. I don't have time to investigate that one right now though. That usually means I've goofed on the ref counting. I'll add your patch and review the

Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

2009-11-02 Thread Nicolas Pitre
On Mon, 2 Nov 2009, Alan Cox wrote: > > However I have problems applying your patches. Most of them require > > fuzzy patching to apply, and one of them even doesn't apply that way. > > What is your base tree? > > Linux-next, but there is a patch I posted afterwards that goes before the > sdi

Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

2009-11-02 Thread Alan Cox
> However I have problems applying your patches. Most of them require > fuzzy patching to apply, and one of them even doesn't apply that way. > What is your base tree? Linux-next, but there is a patch I posted afterwards that goes before the sdio_uart patches. Want me to send you a set with al

Re: [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

2009-11-02 Thread Nicolas Pitre
On Mon, 2 Nov 2009, Alan Cox wrote: > This sorts out the sdio uart handling of the tty layer. The existing code > has lots of races and other fun bugs. Beat it into the current tty format for > hotpluggable devices. The updates are intentionally modelled on Alan Stern's > USB serial approach which

[PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

2009-11-02 Thread Alan Cox
This sorts out the sdio uart handling of the tty layer. The existing code has lots of races and other fun bugs. Beat it into the current tty format for hotpluggable devices. The updates are intentionally modelled on Alan Stern's USB serial approach which is defintiely "best practice" right now. Als