Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-18 Thread Eric Bénard
Le 18/10/2010 13:38, Wolfram Sang a écrit : you seems to be right, the attached patch seems to fix it (tested on our board using a Linaro rootfs on a Transcend SDHC card and I didn't get errors after applying this patch but I'm stopped by udev errors now with this rootfs). Is this needed on MX3

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-18 Thread Wolfram Sang
Hi Richard, On Mon, Oct 18, 2010 at 04:48:07PM +0800, Zhu Richard-R65037 wrote: > The debug msg "mmc0: mmc_rescan: trying to init card at 40 Hz..." are > dumped out repeatedly. > ROOT: There are pr_info codes in the mmc_rescan func. There was already a patch on this list fixing it. > The o

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-18 Thread Wolfram Sang
> you seems to be right, the attached patch seems to fix it (tested on our > board using a Linaro rootfs on a Transcend SDHC card and I didn't get > errors after applying this patch but I'm stopped by udev errors now with > this rootfs). Is this needed on MX35, too? -- Pengutronix e.K.

RE: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-18 Thread Zhu Richard-R65037
inux-arm-ker...@lists.infradead.org; Guo Shawn-R65073; > linux-mmc@vger.kernel.org; Arnaud Patard > Subject: Re: [PATCH 0/6] SD/MMC driver for MX25/35/51 > > Hi Richard, > > Le 18/10/2010 10:48, Zhu Richard-R65037 a écrit : > > I tested your serial patches with Eric

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-18 Thread Eric Bénard
Hi Richard, Le 18/10/2010 10:48, Zhu Richard-R65037 a écrit : I tested your serial patches with Eric's platform related codes on i.MX51 BBG3.0 board. Two phenomena: The debug msg "mmc0: mmc_rescan: trying to init card at 40 Hz..." are dumped out repeatedly. ROOT: There are pr_info codes in

RE: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-18 Thread Zhu Richard-R65037
-Original Message- > From: Zhu Richard-R65037 > Sent: Monday, October 18, 2010 11:30 AM > To: 'Wolfram Sang' > Cc: Eric Bénard; Arnaud Patard; linux-mmc@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: RE: [PATCH 0/6] SD/MMC driver for MX25/35/

RE: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-17 Thread Zhu Richard-R65037
[mailto:w.s...@pengutronix.de] > Sent: Friday, October 15, 2010 6:27 PM > To: Zhu Richard-R65037 > Cc: Eric Bénard; Arnaud Patard; linux-mmc@vger.kernel.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH 0/6] SD/MMC driver for MX25/35/51 > > Richard, > > >

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-15 Thread Rtp
Wolfram Sang writes: Hi, > On Wed, Oct 13, 2010 at 11:28:15AM +0200, Arnaud Patard wrote: > >> >> it's actually not yet supported by the driver. There is a wp_gpio in >> >> struct esdhc_platform_data (arch/arm/plat-mxc/include/mach/esdhc.h) >> >> but it's not yet used by the driver. >> > >> > It

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-15 Thread Wolfram Sang
Richard, > > I take one day leave yesterday for one examination that had been booked a > > few days ago, > > and missed Eric's patches, so regretful. > > No problem, such things happen. If you'd have time to review those > patches now, that would be great, too. Do you have time to check the la

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-15 Thread Wolfram Sang
On Wed, Oct 13, 2010 at 11:28:15AM +0200, Arnaud Patard wrote: > >> it's actually not yet supported by the driver. There is a wp_gpio in > >> struct esdhc_platform_data (arch/arm/plat-mxc/include/mach/esdhc.h) > >> but it's not yet used by the driver. > > > > It's all prepared. I finally will have

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-13 Thread Wolfram Sang
> I take one day leave yesterday for one examination that had been booked a few > days ago, > and missed Eric's patches, so regretful. No problem, such things happen. If you'd have time to review those patches now, that would be great, too. -- Pengutronix e.K. | Wolf

RE: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-13 Thread Zhu Richard-R65037
r 13, 2010 6:10 PM > To: Wolfram Sang > Cc: Zhu Richard-R65037; Arnaud Patard; linux-mmc@vger.kernel.org; linux- > arm-ker...@lists.infradead.org > Subject: Re: [PATCH 0/6] SD/MMC driver for MX25/35/51 > > Hi Wolfram, > > Le 13/10/2010 12:06, Wolfram Sang a écrit : > > gr

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-13 Thread Eric Bénard
Hi Wolfram, Le 13/10/2010 12:06, Wolfram Sang a écrit : great to have you back! Did you have the chance to test my latest patch-series? And can you help Eric with the comments for the clock-calculation on MX51? that's solved in the latest version of the patch (and the max value checks in the f

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-13 Thread Wolfram Sang
Hi Richard, great to have you back! Did you have the chance to test my latest patch-series? And can you help Eric with the comments for the clock-calculation on MX51? > I can't access the external git repos because of the firewall.:(. Ouch! I hope you already complained ;) At least my repo shoul

RE: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-13 Thread Zhu Richard-R65037
rg; linux- > arm-ker...@lists.infradead.org > Subject: Re: [PATCH 0/6] SD/MMC driver for MX25/35/51 > > Wolfram Sang writes: > > Hi, > > > On Wed, Oct 13, 2010 at 10:15:04AM +0200, Eric Bénard wrote: > > > >> >I've tried it on a efika mx (to2 version) and I've

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-13 Thread Rtp
Wolfram Sang writes: Hi, > On Wed, Oct 13, 2010 at 10:15:04AM +0200, Eric Bénard wrote: > >> >I've tried it on a efika mx (to2 version) and I've a problem with the >> >write-protect. It's on a GPIO and I don't see any way to configure the >> >esdhc-imx driver to use it. Any idea on how it should

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-13 Thread Wolfram Sang
On Wed, Oct 13, 2010 at 10:15:04AM +0200, Eric Bénard wrote: > >I've tried it on a efika mx (to2 version) and I've a problem with the > >write-protect. It's on a GPIO and I don't see any way to configure the > >esdhc-imx driver to use it. Any idea on how it should be done ? > > > it's actually not

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-13 Thread Eric Bénard
Hi, Le 13/10/2010 00:06, Arnaud Patard (Rtp) a écrit : Wolfram Sang writes: Here is the hopefully final (famous last words) version of my patch series. The first four are still updates/improvements for sdhci and sdhci-pltfm and are of generic interest, too. Thanks to Eric for the tests on MX25

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-12 Thread Rtp
Wolfram Sang writes: Hi, > Here is the hopefully final (famous last words) version of my patch series. > The > first four are still updates/improvements for sdhci and sdhci-pltfm and are of > generic interest, too. Thanks to Eric for the tests on MX25/35. Looking > forward > to comments/applie

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-11 Thread Chris Ball
Hi Wolfram, On Mon, Oct 11, 2010 at 06:44:59PM +0200, Wolfram Sang wrote: > > Mind fixing up the >80 char lines in the last two patches? It's just: > > Sigh, I don't think it will help the readability of the code, but if it can't > be helped... Okay. Perhaps as a compromise, just reflow the tw

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-11 Thread Wolfram Sang
> > Wolfram Sang (6): > > mmc: sdhci-pltfm: Add structure for host-specific data > > mmc: sdhci-pltfm: move .h-file into apropriate subdir > > mmc: sdhci: introduce private get_ro > > mmc: sdhci_pltfm: pass more data on custom init-call > > mmc: sdhci-of-esdhc: factor out common stuff >

Re: [PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-11 Thread Chris Ball
Hi Wolfram, On Mon, Oct 11, 2010 at 04:21:00PM +0200, Wolfram Sang wrote: > Wolfram Sang (6): > mmc: sdhci-pltfm: Add structure for host-specific data > mmc: sdhci-pltfm: move .h-file into apropriate subdir > mmc: sdhci: introduce private get_ro > mmc: sdhci_pltfm: pass more data on custom

[PATCH 0/6] SD/MMC driver for MX25/35/51

2010-10-11 Thread Wolfram Sang
Here is the hopefully final (famous last words) version of my patch series. The first four are still updates/improvements for sdhci and sdhci-pltfm and are of generic interest, too. Thanks to Eric for the tests on MX25/35. Looking forward to comments/applied-to-mmc-next-messages ;) The series is b