Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-09 Thread jassi brar
On Mon, May 10, 2010 at 2:26 AM, Dan Williams wrote: > On Sun, May 9, 2010 at 3:06 AM, jassi brar wrote: >> This discussion is purely about what the current DMA API misses and what >> a generic DMA API should do. So, that the current DMA API fills up those >> gap, if possible. I would love to get

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-09 Thread Dan Williams
On Sun, May 9, 2010 at 3:06 AM, jassi brar wrote: > This discussion is purely about what the current DMA API misses and what > a generic DMA API should do. So, that the current DMA API fills up those > gap, if possible. I would love to get started implementing the generic > DMA API for reference b

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-09 Thread jassi brar
On Sun, May 9, 2010 at 4:47 PM, Dan Williams wrote: > On Sat, May 8, 2010 at 8:48 PM, jassi brar wrote: >> On Sun, May 9, 2010 at 7:24 AM, Dan Williams >> wrote: >>> On Fri, May 7, 2010 at 7:37 PM, jassi brar wrote:  IMHO, a DMA api should be as quick as possible - callbacks done in IRQ

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-09 Thread Dan Williams
On Sat, May 8, 2010 at 8:48 PM, jassi brar wrote: > On Sun, May 9, 2010 at 7:24 AM, Dan Williams wrote: >> On Fri, May 7, 2010 at 7:37 PM, jassi brar wrote: >>>  IMHO, a DMA api should be as quick as possible - callbacks done in IRQ >>> context. >>>  But since there maybe clients that need to d

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-08 Thread jassi brar
On Sun, May 9, 2010 at 7:24 AM, Dan Williams wrote: > On Fri, May 7, 2010 at 7:37 PM, jassi brar wrote: >>  IMHO, a DMA api should be as quick as possible - callbacks done in IRQ >> context. >>  But since there maybe clients that need to do sleepable stuff in > > None of the current clients slee

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-08 Thread Dan Williams
On Fri, May 7, 2010 at 7:37 PM, jassi brar wrote: > On Sat, May 8, 2010 at 1:10 AM, Linus Walleij > wrote: >> Surely circular linked buffers and other goodies can be retrofitted into the >> DMAengine without a complete redesign? I only see a new slave call >> to support that really, in addition t

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-07 Thread jassi brar
On Sat, May 8, 2010 at 1:10 AM, Linus Walleij wrote: > Surely circular linked buffers and other goodies can be retrofitted into the > DMAengine without a complete redesign? I only see a new slave call > to support that really, in addition to the existing sglist interface. well, before taking up th

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-07 Thread Dan Williams
On Fri, May 7, 2010 at 4:43 AM, Linus Walleij wrote: > 2010/5/7 Russell King - ARM Linux : > >> I would have thought given the concerns that I stated, merely running >> the drivers in PIO mode would not address those concerns.  So no, I'm >> not satisfied. > > Sorry didn't get it, I understood it

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-07 Thread Linus Walleij
2010/5/7 jassi brar : > On Fri, May 7, 2010 at 8:43 PM, Linus Walleij > wrote: >> 2010/5/7 Russell King - ARM Linux : >>> >>> Or let me put it another way - if people are happy for Linux to support >>> new ARM CPU architectures, but with very little attention given to DMA >>> support on those arch

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-07 Thread jassi brar
On Fri, May 7, 2010 at 8:43 PM, Linus Walleij wrote: > 2010/5/7 Russell King - ARM Linux : >> Or let me put it another way - if people are happy for Linux to support >> new ARM CPU architectures, but with very little attention given to DMA >> support on those architectures, then feel free to box t

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-07 Thread Linus Walleij
2010/5/7 Russell King - ARM Linux : > I would have thought given the concerns that I stated, merely running > the drivers in PIO mode would not address those concerns.  So no, I'm > not satisfied. Sorry didn't get it, I understood it as it should be tested on the Versatile without regressions. S

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-07 Thread Russell King - ARM Linux
On Fri, May 07, 2010 at 11:13:57AM +0200, Linus Walleij wrote: > Dan is this patch set OK? > > Sorry if you're busy, just need to check... > > Patches 1 thru 4 should be uncontroversial, only affects > our ST-Ericsson platforms and have been thorougly reviewed. > > As posted elsewhere this is te

Re: [PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-07 Thread Linus Walleij
Dan is this patch set OK? Sorry if you're busy, just need to check... Patches 1 thru 4 should be uncontroversial, only affects our ST-Ericsson platforms and have been thorougly reviewed. As posted elsewhere this is tested on an ARM reference design now as well, which IMHO would make it OK to app

[PATCH 0/7] DMAENGINE: fixes and PrimeCells

2010-05-02 Thread Linus Walleij
This patch set intended for Dan Williams tree includes: - A fixed up COH 901 318 PrimeCell extension (unless applied to your tree already) - Two DMA40 bug fixes. - The latest iteration of the PrimeCell DMA extensions, altered and tested to work as Russell wants them. The PL011 driver was tes