Re: [PATCH 01/16] gpio: rcar: use postcore_init()

2013-11-20 Thread Kuninori Morimoto
Hi Laurent, Linus, > > The general guideline, as everybody should be aware ;-) is that we > > should always use module_init(), i.e. device_initcall() and let deferred > > probe handle any dependencies. > > Thought so, good :-) > > > The only exception would be things like timers and interrupt c

Re: [PATCH 01/16] gpio: rcar: use postcore_init()

2013-11-19 Thread Laurent Pinchart
Hi Linus, On Tuesday 19 November 2013 10:57:43 Linus Walleij wrote: > On Mon, Nov 18, 2013 at 3:00 PM, Laurent Pinchart wrote: > > I'm not against moving the gpio-rcar initialization to postcore or subsys > > initcall, but in that case I believe we should standardize (or at least > > try > > to) t

Re: [PATCH 01/16] gpio: rcar: use postcore_init()

2013-11-19 Thread Linus Walleij
On Mon, Nov 18, 2013 at 3:00 PM, Laurent Pinchart wrote: > I'm not against moving the gpio-rcar initialization to postcore or subsys > initcall, but in that case I believe we should standardize (or at least try > to) this across the GPIO drivers. We currently have > > $ cat drivers/gpio/gpio-*.c

Re: [PATCH 01/16] gpio: rcar: use postcore_init()

2013-11-18 Thread Laurent Pinchart
Hi Morimoto-san, (CC'ing Linus Walleij) On Thursday 14 November 2013 16:26:53 Kuninori Morimoto wrote: > Hi Laurent > > > > Renesas GPIO is being interlocked with PFC, and GPIO is > > > very basic system for R-Car. > > > GPIO should be initialised in same timing as PFC. > > > The GPIO based syst

Re: [PATCH 01/16] gpio: rcar: use postcore_init()

2013-11-14 Thread Kuninori Morimoto
Hi Laurent > > Renesas GPIO is being interlocked with PFC, and GPIO is > > very basic system for R-Car. > > GPIO should be initialised in same timing as PFC. > > The GPIO based system doesn't work correctly without this patch. > > Could you please describe the failure in a bit more details ? Re

Re: [PATCH 01/16] gpio: rcar: use postcore_init()

2013-11-14 Thread Laurent Pinchart
Hi Morimoto-san, Thank you for the patch. On Thursday 14 November 2013 02:19:54 Kuninori Morimoto wrote: > Renesas GPIO is being interlocked with PFC, and GPIO is > very basic system for R-Car. > GPIO should be initialised in same timing as PFC. > The GPIO based system doesn't work correctly with

[PATCH 01/16] gpio: rcar: use postcore_init()

2013-11-14 Thread Kuninori Morimoto
Renesas GPIO is being interlocked with PFC, and GPIO is very basic system for R-Car. GPIO should be initialised in same timing as PFC. The GPIO based system doesn't work correctly without this patch. Signed-off-by: Kuninori Morimoto --- drivers/gpio/gpio-rcar.c | 12 +++- 1 file change