Re: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-05 Thread Heiko Stübner
Am Mittwoch, 5. Juni 2013, 19:18:49 schrieb Stephen Warren: > On 06/05/2013 01:01 AM, Linus Walleij wrote: > > On Tue, Jun 4, 2013 at 2:05 PM, Heiko Stübner wrote: > ... > > >> The only problem is the pull stuff mentioned above that is either pull > >> up or down without the driver having knowled

Re: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-05 Thread Stephen Warren
On 06/05/2013 01:01 AM, Linus Walleij wrote: > On Tue, Jun 4, 2013 at 2:05 PM, Heiko Stübner wrote: ... >> The only problem is the pull stuff mentioned above that is either pull up or >> down without the driver having knowledge about it. And generic_pinconf only >> knows about them separately righ

Re: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-05 Thread Linus Walleij
On Tue, Jun 4, 2013 at 2:05 PM, Heiko Stübner wrote: >> > +PULL_AUTO (1 << 0): indicate this pin needs a pull setting for SoCs >> > + that determine the pull up or down themselfs >> >> Hm, never saw that before... > > Citing the original gpio driver: > > /* >

Re: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-04 Thread Heiko Stübner
Hi, I'll just skip over the "right, will fix that" issues and just address the unclear ones. Am Dienstag, 4. Juni 2013, 09:08:09 schrieb Linus Walleij: > On Mon, Jun 3, 2013 at 12:59 AM, Heiko Stübner wrote: > > This driver adds support the Cortex-A9 based SoCs from Rockchip, > > so at least th

Re: [PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-04 Thread Linus Walleij
On Mon, Jun 3, 2013 at 12:59 AM, Heiko Stübner wrote: > This driver adds support the Cortex-A9 based SoCs from Rockchip, > so at least the RK2928, RK3066 (a and b) and RK3188. > Earlier Rockchip SoCs seem to use similar mechanics for gpio > handling so should be supportable with relative small ch

[PATCH 07/10] pinctrl: add pinctrl driver for Rockchip SoCs

2013-06-02 Thread Heiko Stübner
This driver adds support the Cortex-A9 based SoCs from Rockchip, so at least the RK2928, RK3066 (a and b) and RK3188. Earlier Rockchip SoCs seem to use similar mechanics for gpio handling so should be supportable with relative small changes. Pull handling on the rk3188 is currently a stub, due to i