Re: [PATCH 07/17] spi: pl022: Don't ignore power domain and amba bus at system suspend

2014-02-19 Thread Ulf Hansson
On 10 February 2014 13:51, Mark Brown broo...@kernel.org wrote: On Mon, Feb 10, 2014 at 01:33:50PM +0100, Ulf Hansson wrote: On 4 February 2014 20:16, Mark Brown broo...@kernel.org wrote: This seems like a fairly hideous thing to be having to open code in an individual driver, it all looks

Re: [PATCH 07/17] spi: pl022: Don't ignore power domain and amba bus at system suspend

2014-02-10 Thread Ulf Hansson
On 4 February 2014 20:16, Mark Brown broo...@kernel.org wrote: On Tue, Feb 04, 2014 at 04:58:48PM +0100, Ulf Hansson wrote: @@ -2328,8 +2300,23 @@ static int pl022_suspend(struct device *dev) return ret; } - pm_runtime_get_sync(dev); -

Re: [PATCH 07/17] spi: pl022: Don't ignore power domain and amba bus at system suspend

2014-02-10 Thread Mark Brown
On Mon, Feb 10, 2014 at 01:33:50PM +0100, Ulf Hansson wrote: On 4 February 2014 20:16, Mark Brown broo...@kernel.org wrote: This seems like a fairly hideous thing to be having to open code in an individual driver, it all looks generic and like something that most if ... Putting it in a

[PATCH 07/17] spi: pl022: Don't ignore power domain and amba bus at system suspend

2014-02-04 Thread Ulf Hansson
Due to the available runtime PM callbacks for CONFIG_PM, we are now able to put the device into complete low power state at system suspend. Previously only the resources controlled by the driver were put into low power state at system suspend. Both the amba bus and a potential power domain were

Re: [PATCH 07/17] spi: pl022: Don't ignore power domain and amba bus at system suspend

2014-02-04 Thread Mark Brown
On Tue, Feb 04, 2014 at 04:58:48PM +0100, Ulf Hansson wrote: @@ -2328,8 +2300,23 @@ static int pl022_suspend(struct device *dev) return ret; } - pm_runtime_get_sync(dev); - pl022_suspend_resources(pl022, false); + pm_runtime_disable(dev); + + if