Re: [PATCH 1/1] mmc: dw_mmc: Fix card detection regression

2014-01-15 Thread Sachin Kamat
On 15 January 2014 15:13, zhangfei wrote: > > > On 01/15/2014 05:39 PM, Sachin Kamat wrote: >>> >>> Thanks for the patch >>> I just submitted one patch to fix the issue, in case you missed it. >> >> >> Yes I did as I am not subscribed to mmc list. >> >>> Also spin_lock is required for atomic acces

Re: [PATCH 1/1] mmc: dw_mmc: Fix card detection regression

2014-01-15 Thread zhangfei
On 01/15/2014 05:39 PM, Sachin Kamat wrote: Thanks for the patch I just submitted one patch to fix the issue, in case you missed it. Yes I did as I am not subscribed to mmc list. Also spin_lock is required for atomic accessing DW_MMC_CARD_PRESENT. Otherwise sd detect may be failed sometimes

Re: [PATCH 1/1] mmc: dw_mmc: Fix card detection regression

2014-01-15 Thread Sachin Kamat
Hi Zhangfei, On 15 January 2014 14:11, zhangfei wrote: > Hi, Sachin > > > > > On 01/15/2014 04:31 PM, Sachin Kamat wrote: >> >> mmc_gpio_get_cd returns a negative error value upon failure. >> However gpio_cd was initialised with the negated return value >> of the above function. This negation res

Re: [PATCH 1/1] mmc: dw_mmc: Fix card detection regression

2014-01-15 Thread zhangfei
Hi, Sachin On 01/15/2014 04:31 PM, Sachin Kamat wrote: mmc_gpio_get_cd returns a negative error value upon failure. However gpio_cd was initialised with the negated return value of the above function. This negation resulted in losing of the error value thereby triggering the code to take a wro

[PATCH 1/1] mmc: dw_mmc: Fix card detection regression

2014-01-15 Thread Sachin Kamat
mmc_gpio_get_cd returns a negative error value upon failure. However gpio_cd was initialised with the negated return value of the above function. This negation resulted in losing of the error value thereby triggering the code to take a wrong path as IS_ERR_VALUE(gpio_cd) now returned 0 even when mm