Re: [PATCH 1/1]sdhci-pxa: support tune_timming for various cards

2010-11-10 Thread Philip Rakity
We should rename sdhci-pxa.c to sdhci-mmp2.c and adjust Kconfig and the makefile accordingly since it is clear code is clearly processor dependent or The additional changes to support the pxa family of chips should be posted to the web. On Nov 10, 2010, at 6:08 PM, zhangfei gao wrote: > On

Re: [PATCH 1/1]sdhci-pxa: support tune_timming for various cards

2010-11-10 Thread zhangfei gao
On Wed, Nov 10, 2010 at 4:58 PM, Philip Rakity wrote: > > > >> +#define SD_CLOCK_AND_BURST_SIZE_SETUP          0x10A > > This offset is only for MMP2.  On other pxa processors use a  different > offset.  sdhci-pxa.c needs changing to support other pxa soc chips. The first stage is only consider

[PATCH 1/1]sdhci-pxa: support tune_timming for various cards

2010-11-10 Thread Philip Rakity
> +#define SD_CLOCK_AND_BURST_SIZE_SETUP 0x10A This offset is only for MMP2. On other pxa processors use a different offset. sdhci-pxa.c needs changing to support other pxa soc chips. The value only needs setting at initialization time or sdhci reset (RESET_ALL) -- To unsubscrib

Re: [PATCH 1/1]sdhci-pxa: support tune_timming for various cards

2010-11-09 Thread Eric Miao
On Tue, Nov 9, 2010 at 10:17 PM, zhangfei gao wrote: > Haojian, > > Would you help review, since arch/arm/plat-pxa/include/plat/sdhci.h is > updated, thanks > > From 6619812b749aa12ebf0efbe057366c2f99051bfe Mon Sep 17 00:00:00 2001 > From: Zhangfei Gao > Date: Tue, 2 Nov 2010 07:37:44 -0400 > Sub

[PATCH 1/1]sdhci-pxa: support tune_timming for various cards

2010-11-09 Thread zhangfei gao
Haojian, Would you help review, since arch/arm/plat-pxa/include/plat/sdhci.h is updated, thanks >From 6619812b749aa12ebf0efbe057366c2f99051bfe Mon Sep 17 00:00:00 2001 From: Zhangfei Gao Date: Tue, 2 Nov 2010 07:37:44 -0400 Subject: [PATCH] sdhci-pxa: support tune_timming for various cards

Re: [PATCH 1/1]sdhci-pxa: support tune_timming for various cards

2010-11-09 Thread Chris Ball
Hi, Here are some obvious changes: On Tue, Nov 09, 2010 at 09:17:21AM -0500, zhangfei gao wrote: > Haojian, > > Would you help review, since arch/arm/plat-pxa/include/plat/sdhci.h is > updated, thanks > > >From 6619812b749aa12ebf0efbe057366c2f99051bfe Mon Sep 17 00:00:00 2001 > From: Zhangfei G