Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-12-07 Thread Takashi Iwai
At Wed, 24 Nov 2010 23:04:25 +0100, Wolfram Sang wrote: > > On Wed, Nov 24, 2010 at 12:29:57PM +0100, Takashi Iwai wrote: > > At Wed, 24 Nov 2010 10:59:35 +0100, > > Wolfram Sang wrote: > > > > > > On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote: > > > > > > > +/* Controller doesn't

Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-24 Thread Wolfram Sang
On Wed, Nov 24, 2010 at 12:29:57PM +0100, Takashi Iwai wrote: > At Wed, 24 Nov 2010 10:59:35 +0100, > Wolfram Sang wrote: > > > > On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote: > > > > > +/* Controller doesn't support VDD 180 for MMC (for SD/MMC combo chips) */ > > > +#define SDHCI

Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-24 Thread Takashi Iwai
1d3ccdd3373598b91125c049e3f0dfdeb2598 Mon Sep 17 00:00:00 2001 From: Takashi Iwai Date: Tue, 2 Nov 2010 09:10:20 +0100 Subject: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller (v2) JMicron 388 SD/MMC combo controller supports the 1.8V low-voltage for SD, but MMC doesn't work

Re: [PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-24 Thread Wolfram Sang
On Wed, Nov 24, 2010 at 07:21:13AM +0100, Takashi Iwai wrote: > +/* Controller doesn't support VDD 180 for MMC (for SD/MMC combo chips) */ > +#define SDHCI_QUIRK_MMC_VDD_180 (1<<30) Can't we handle this more generic? Like setting ocr_avail_* from sdhci-pci.c somehow (

[PATCH 1/2] mmc: Add support for JMicron 388 SD/MMC controller

2010-11-23 Thread Takashi Iwai
JMicron 388 SD/MMC combo controller supports the 1.8V low-voltage for SD, but MMC doesn't work with the low-voltage, resulting in an error at probing. This patch adds the support for multiple voltage mask per device type, so that SD works with 1.8V while MMC forces 3.3V. Here new ocr_avail_* fiel