Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-18 Thread Mika Westerberg
On Wed, Aug 17, 2011 at 03:19:14PM +0300, Mika Westerberg wrote: On Wed, Aug 17, 2011 at 09:51:31AM +0200, Linus Walleij wrote: I would suggest that in all patches using these functions, try to replace: mmc_host_clk_disable() - mmc_host_clk_ungate() mmc_host_clk_enable() -

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-18 Thread Andy Shevchenko
On Thu, Aug 18, 2011 at 1:34 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: I'll prepare a new series which uses mmc_host_clk_{ungate|gate}(). Mika, do the patches to check host-clock in (mmc|sdhci)_set_data_timeout() become useless after? If so, probably you could revert them as

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-18 Thread Mika Westerberg
On Thu, Aug 18, 2011 at 02:11:23PM +0300, Andy Shevchenko wrote: Mika, do the patches to check host-clock in (mmc|sdhci)_set_data_timeout() become useless after? If so, probably you could revert them as well. IMHO these functions should work also when the clock is gated, so I suggest that we

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-17 Thread Linus Walleij
On Mon, Aug 15, 2011 at 12:03 PM, Mika Westerberg mika.westerb...@linux.intel.com wrote: There are few places where we want to make sure that no clock gating takes place. For example when we are updating several related fields in ios structure and we don't want to accidentally pass the

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-17 Thread Mika Westerberg
On Wed, Aug 17, 2011 at 09:51:31AM +0200, Linus Walleij wrote: I would suggest that in all patches using these functions, try to replace: mmc_host_clk_disable() - mmc_host_clk_ungate() mmc_host_clk_enable() - mmc_host_clk_gate() Wow, that is indeed *much* cleaner way of doing this! One

Re: [PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-16 Thread Mika Westerberg
On Mon, Aug 15, 2011 at 01:03:37PM +0300, Mika Westerberg wrote: There are few places where we want to make sure that no clock gating takes place. For example when we are updating several related fields in ios structure and we don't want to accidentally pass the partially filled ios to the

[PATCH 1/2] mmc: add functions to enable/disable aggressive clock gating

2011-08-15 Thread Mika Westerberg
There are few places where we want to make sure that no clock gating takes place. For example when we are updating several related fields in ios structure and we don't want to accidentally pass the partially filled ios to the host driver. To solve this we add two functions to enable/disable the