RE: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-09 Thread Seungwon Jeon
On Thu, August 01, 2013, Jingoo Han wrote: dw_mci_socfpga_probe() is used only in this file. Fix the following sparse warning: drivers/mmc/host/dw_mmc-socfpga.c:116:5: warning: symbol 'dw_mci_socfpga_probe' was not declared. Should it be static? Signed-off-by: Jingoo Han

Re: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-05 Thread Jingoo Han
On Friday, August 02, 2013 5:34 PM, Dan Carpenter wrote: On Fri, Aug 02, 2013 at 09:11:19AM +0900, Jingoo Han wrote: On Friday, August 02, 2013 1:19 AM, Dinh Nguyen wrote: [...] drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol 'dw_mci_pltfm_register' was not declared. Should it be

Re: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-02 Thread Dan Carpenter
On Fri, Aug 02, 2013 at 09:11:19AM +0900, Jingoo Han wrote: On Friday, August 02, 2013 1:19 AM, Dinh Nguyen wrote: drivers/mmc/host/dw_mmc-pltfm.c:58:24: warning: incorrect type in argument 1 (different address spaces) drivers/mmc/host/dw_mmc-pltfm.c:58:24:expected void const *ptr

[PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-01 Thread Jingoo Han
dw_mci_socfpga_probe() is used only in this file. Fix the following sparse warning: drivers/mmc/host/dw_mmc-socfpga.c:116:5: warning: symbol 'dw_mci_socfpga_probe' was not declared. Should it be static? Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/mmc/host/dw_mmc-socfpga.c |2

Re: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-01 Thread Dinh Nguyen
Hi, On Thu, 2013-08-01 at 15:30 +0900, Jingoo Han wrote: dw_mci_socfpga_probe() is used only in this file. Fix the following sparse warning: drivers/mmc/host/dw_mmc-socfpga.c:116:5: warning: symbol 'dw_mci_socfpga_probe' was not declared. Should it be static? Signed-off-by: Jingoo Han

Re: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

2013-08-01 Thread Jingoo Han
On Friday, August 02, 2013 1:19 AM, Dinh Nguyen wrote: On Thu, 2013-08-01 at 15:30 +0900, Jingoo Han wrote: dw_mci_socfpga_probe() is used only in this file. Fix the following sparse warning: drivers/mmc/host/dw_mmc-socfpga.c:116:5: warning: symbol 'dw_mci_socfpga_probe' was not