Re: [PATCH 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

[...] >> I understand the phy is optional, but you still need to handle the >> EPROBE_DEFER case. >> >> Perhaps you should also use devm_phy_optional_get() instead!? > > > I already changed it in version-2 [1]. :) > phy is mandatory for sdhci-arasan,5.1. > > [1]:

Re: [PATCH 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

[...] >>> > + ret = phy_power_on(sdhci_arasan->phy); This looks a bit weird. Shouldn't you do phy_init() prior phy_power_on()? Similar comment applies to phy_exit() and phy_power_off(). >>> >>> >>> >>> Both are okay. It depends how the

Re: [PATCH 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

On 2015/10/19 15:50, Ulf Hansson wrote: [...] I understand the phy is optional, but you still need to handle the EPROBE_DEFER case. Perhaps you should also use devm_phy_optional_get() instead!? I already changed it in version-2 [1]. :) phy is mandatory for sdhci-arasan,5.1. [1]:

Re: [PATCH 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

On 2015/10/19 18:54, Ulf Hansson wrote: [...] [...] 2) Considering the runtime PM case for the sdhci device. Typically you can gate clocks etc at runtime suspend to save power, but what about the phy? Can you power off it in runtime suspend? yes, we can power off it in runtime

Re: [PATCH 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

On 2015/10/16 20:35, Ulf Hansson wrote: On 11 September 2015 at 10:54, Shawn Lin wrote: This patch adds Generic PHY access for sdhci-of-arasan. Driver can get PHY handler from dt-binding, and power-on/init the PHY. Also we add pm ops for PHY here if CONFIG_PM_SLEEP is

Re: [PATCH 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

On 11 September 2015 at 10:54, Shawn Lin wrote: > This patch adds Generic PHY access for sdhci-of-arasan. Driver > can get PHY handler from dt-binding, and power-on/init the PHY. > Also we add pm ops for PHY here if CONFIG_PM_SLEEP is enabled. > > Signed-off-by: Shawn

[PATCH 1/2] mmc: sdhci-of-arasan: add phy support for sdhci-of-arasan

This patch adds Generic PHY access for sdhci-of-arasan. Driver can get PHY handler from dt-binding, and power-on/init the PHY. Also we add pm ops for PHY here if CONFIG_PM_SLEEP is enabled. Signed-off-by: Shawn Lin --- drivers/mmc/host/sdhci-of-arasan.c | 90