Re: [PATCH 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-05 Thread Thomas Abraham
Dear Mr. Kim, On 5 September 2011 10:46, Kukjin Kim wrote: > Thomas Abraham wrote: >> >> The default controller configuration which was previously setup by >> platform helper functions is moved into the driver. >> >> Cc: Ben Dooks >> Signed-off-by: Thomas Abraham >> --- >>  drivers/mmc/host/sdh

Re: [PATCH 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-05 Thread Thomas Abraham
Hi Jaehoon, On 5 September 2011 07:01, Jaehoon Chung wrote: > Hi Thomas. > > I have some question. This patch looks good. > Some names are used S3C_SDHCI_. but some names are used > S3C64XX_SDHCI_. > Do you know what differ them? I am not sure why there are S3C_SDHCI_xxx and S3C64XX_SDH

RE: [PATCH 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-04 Thread Kukjin Kim
Thomas Abraham wrote: > > The default controller configuration which was previously setup by > platform helper functions is moved into the driver. > > Cc: Ben Dooks > Signed-off-by: Thomas Abraham > --- > drivers/mmc/host/sdhci-s3c.c | 28 +--- > 1 files changed, 17 i

Re: [PATCH 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-04 Thread Jaehoon Chung
Hi Thomas. I have some question. This patch looks good. Some names are used S3C_SDHCI_. but some names are used S3C64XX_SDHCI_. Do you know what differ them? Thanks, Jaehoon Chung Thomas Abraham wrote: > The default controller configuration which was previously setup by > platform helpe

[PATCH 1/2] mmc: sdhci-s3c: add default controller configuration

2011-09-02 Thread Thomas Abraham
The default controller configuration which was previously setup by platform helper functions is moved into the driver. Cc: Ben Dooks Signed-off-by: Thomas Abraham --- drivers/mmc/host/sdhci-s3c.c | 28 +--- 1 files changed, 17 insertions(+), 11 deletions(-) diff --git