Re: [PATCH 1/3] mmc: add per device quirk placeholder

2011-01-22 Thread Ohad Ben-Cohen
On Sun, Jan 9, 2011 at 6:26 PM, Pierre Tardy wrote: > From: Pierre Tardy > > Some cards have quirks valid for every platforms > using current platform quirk hooks leads to a lot > of code and debug duplication. > > So we inspire a bit from what exists in PCI subsystem > and do our own per vendori

Re: [PATCH 1/3] mmc: add per device quirk placeholder

2011-01-10 Thread Pierre Tardy
>> + >> +     for (f = mmc_fixup_methods; f->hook; f++) { >> +             if ((f->vendor == card->cis.vendor >> +                  || f->vendor == (u16) SDIO_ANY_ID) && >> +                 (f->device == card->cis.device >> +                  || f->device == (u16) SDIO_ANY_ID)) { >> +            

Re: [PATCH 1/3] mmc: add per device quirk placeholder

2011-01-10 Thread Philip Rakity
On Jan 9, 2011, at 8:26 AM, Pierre Tardy wrote: > From: Pierre Tardy > > Some cards have quirks valid for every platforms > using current platform quirk hooks leads to a lot > of code and debug duplication. > > So we inspire a bit from what exists in PCI subsystem > and do our own per vendorid

[PATCH 1/3] mmc: add per device quirk placeholder

2011-01-09 Thread Pierre Tardy
From: Pierre Tardy Some cards have quirks valid for every platforms using current platform quirk hooks leads to a lot of code and debug duplication. So we inspire a bit from what exists in PCI subsystem and do our own per vendorid/deviceid quirk We still drop the complexity of the pci quirk syst