Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-08 Thread Ohad Ben-Cohen
On Tue, Mar 8, 2011 at 7:02 PM, Maxim Levitsky wrote: >> Maxim, does this work for you too ? > > Yep, just tested. Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/ma

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-08 Thread Maxim Levitsky
On Tue, 2011-03-08 at 18:44 +0200, Ohad Ben-Cohen wrote: > On Mon, Mar 7, 2011 at 9:01 PM, Dmitry Shmidt wrote: > > On Sat, Mar 5, 2011 at 7:03 AM, Ohad Ben-Cohen wrote: > >> On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky > >> wrote: > >>> This patch breaks the CONFIG_MMC_UNSAFE_RESUME > >> > >

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-08 Thread Ohad Ben-Cohen
On Mon, Mar 7, 2011 at 9:01 PM, Dmitry Shmidt wrote: > On Sat, Mar 5, 2011 at 7:03 AM, Ohad Ben-Cohen wrote: >> On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky >> wrote: >>> This patch breaks the CONFIG_MMC_UNSAFE_RESUME >> >> Does the below work for you (untested) ? >> >> diff --git a/drivers/m

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-07 Thread Dmitry Shmidt
On Sat, Mar 5, 2011 at 7:03 AM, Ohad Ben-Cohen wrote: > On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky > wrote: >> On Mon, 2010-12-20 at 00:11 +0200, Ohad Ben-Cohen wrote: >>> Hi Chris, >>> >>> On Fri, Dec 17, 2010 at 2:51 AM, Chris Ball wrote: >>> ... >>> > Thanks, pushed to mmc-next with triv

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-05 Thread Ohad Ben-Cohen
On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky wrote: > On Mon, 2010-12-20 at 00:11 +0200, Ohad Ben-Cohen wrote: >> Hi Chris, >> >> On Fri, Dec 17, 2010 at 2:51 AM, Chris Ball wrote: >> ... >> > Thanks, pushed to mmc-next with trivial cleanup as below: >> >> Looks good, thanks. >> >> I just brief

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-04 Thread Maxim Levitsky
On Fri, 2011-03-04 at 14:25 +0900, Jaehoon Chung wrote: > Hi.. > > I agreed Chris's opinion..If use CONFIG_MMC_UNSAFE_RESUME, you can know to > occur some problem..so mentions to "DANGEROUS" > If card can be removed during suspend, i think we have too many cases. > So this configuration...i think

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-03 Thread Jaehoon Chung
Hi.. I agreed Chris's opinion..If use CONFIG_MMC_UNSAFE_RESUME, you can know to occur some problem..so mentions to "DANGEROUS" If card can be removed during suspend, i think we have too many cases. So this configuration...i think good that use only non-removable card. If you considered every case,

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-03 Thread Maxim Levitsky
On Thu, 2011-03-03 at 21:28 -0500, Chris Ball wrote: > Hi, > > On Thu, Mar 03 2011, Maxim Levitsky wrote: > > This patch breaks the CONFIG_MMC_UNSAFE_RESUME, because it sets fake > > non-removeable flag, but the intended use of this option is to assume > > that card is not removed _during_ suspend

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-03 Thread Chris Ball
Hi, On Thu, Mar 03 2011, Maxim Levitsky wrote: > This patch breaks the CONFIG_MMC_UNSAFE_RESUME, because it sets fake > non-removeable flag, but the intended use of this option is to assume > that card is not removed _during_ suspend, and it can still be removed > during normal use. > With this c

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-03 Thread Maxim Levitsky
On Mon, 2010-12-20 at 00:11 +0200, Ohad Ben-Cohen wrote: > Hi Chris, > > On Fri, Dec 17, 2010 at 2:51 AM, Chris Ball wrote: > ... > > Thanks, pushed to mmc-next with trivial cleanup as below: > > Looks good, thanks. > > I just briefly tested mmc-next and it looks fine. This patch breaks the CO

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan

2010-12-19 Thread Ohad Ben-Cohen
Hi Chris, On Fri, Dec 17, 2010 at 2:51 AM, Chris Ball wrote: ... > Thanks, pushed to mmc-next with trivial cleanup as below: Looks good, thanks. I just briefly tested mmc-next and it looks fine. Thanks, Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body o

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan

2010-12-16 Thread Chris Ball
Hi Ohad, On Sun, Nov 28, 2010 at 07:21:28AM +0200, Ohad Ben-Cohen wrote: > mmc_rescan checks whether registered cards are still present before > skipping them, by calling the bus-specific ->detect() handler. > > With buses that support runtime PM, the card may be powered off at > this point, so t

[PATCH 1/3] mmc: skip detection of nonremovable cards on rescan

2010-11-27 Thread Ohad Ben-Cohen
mmc_rescan checks whether registered cards are still present before skipping them, by calling the bus-specific ->detect() handler. With buses that support runtime PM, the card may be powered off at this point, so they need to be powered on and fully reinitialized before ->detect() executes. This