Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-08 Thread Ohad Ben-Cohen
On Mon, Mar 7, 2011 at 9:01 PM, Dmitry Shmidt dimitr...@google.com wrote: On Sat, Mar 5, 2011 at 7:03 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky maximlevit...@gmail.com wrote: This patch breaks the CONFIG_MMC_UNSAFE_RESUME Does the below work

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-08 Thread Maxim Levitsky
On Tue, 2011-03-08 at 18:44 +0200, Ohad Ben-Cohen wrote: On Mon, Mar 7, 2011 at 9:01 PM, Dmitry Shmidt dimitr...@google.com wrote: On Sat, Mar 5, 2011 at 7:03 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky maximlevit...@gmail.com wrote: This

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-08 Thread Ohad Ben-Cohen
On Tue, Mar 8, 2011 at 7:02 PM, Maxim Levitsky maximlevit...@gmail.com wrote: Maxim, does this work for you too ? Yep, just tested. Thanks -- To unsubscribe from this list: send the line unsubscribe linux-mmc in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-07 Thread Dmitry Shmidt
On Sat, Mar 5, 2011 at 7:03 AM, Ohad Ben-Cohen o...@wizery.com wrote: On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Mon, 2010-12-20 at 00:11 +0200, Ohad Ben-Cohen wrote: Hi Chris, On Fri, Dec 17, 2010 at 2:51 AM, Chris Ball c...@laptop.org wrote: ...

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-05 Thread Ohad Ben-Cohen
On Fri, Mar 4, 2011 at 4:22 AM, Maxim Levitsky maximlevit...@gmail.com wrote: On Mon, 2010-12-20 at 00:11 +0200, Ohad Ben-Cohen wrote: Hi Chris, On Fri, Dec 17, 2010 at 2:51 AM, Chris Ball c...@laptop.org wrote: ... Thanks, pushed to mmc-next with trivial cleanup as below: Looks good,

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-04 Thread Maxim Levitsky
On Fri, 2011-03-04 at 14:25 +0900, Jaehoon Chung wrote: Hi.. I agreed Chris's opinion..If use CONFIG_MMC_UNSAFE_RESUME, you can know to occur some problem..so mentions to DANGEROUS If card can be removed during suspend, i think we have too many cases. So this configuration...i think good

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-03 Thread Maxim Levitsky
On Mon, 2010-12-20 at 00:11 +0200, Ohad Ben-Cohen wrote: Hi Chris, On Fri, Dec 17, 2010 at 2:51 AM, Chris Ball c...@laptop.org wrote: ... Thanks, pushed to mmc-next with trivial cleanup as below: Looks good, thanks. I just briefly tested mmc-next and it looks fine. This patch breaks

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-03 Thread Chris Ball
Hi, On Thu, Mar 03 2011, Maxim Levitsky wrote: This patch breaks the CONFIG_MMC_UNSAFE_RESUME, because it sets fake non-removeable flag, but the intended use of this option is to assume that card is not removed _during_ suspend, and it can still be removed during normal use. With this

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-03 Thread Maxim Levitsky
On Thu, 2011-03-03 at 21:28 -0500, Chris Ball wrote: Hi, On Thu, Mar 03 2011, Maxim Levitsky wrote: This patch breaks the CONFIG_MMC_UNSAFE_RESUME, because it sets fake non-removeable flag, but the intended use of this option is to assume that card is not removed _during_ suspend, and

Re: [PATCH 1/3] mmc: skip detection of nonremovable cards on rescan - card removal detection regression

2011-03-03 Thread Jaehoon Chung
Hi.. I agreed Chris's opinion..If use CONFIG_MMC_UNSAFE_RESUME, you can know to occur some problem..so mentions to DANGEROUS If card can be removed during suspend, i think we have too many cases. So this configuration...i think good that use only non-removable card. If you considered every case,